Skip to content

HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l… - #5425

Merged
NihalJain merged 1 commit into
apache:branch-2from
NihalJain:HBASE-27991_branch-2
Sep 26, 2023
Merged

HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l…#5425
NihalJain merged 1 commit into
apache:branch-2from
NihalJain:HBASE-27991_branch-2

Conversation

@NihalJain

@NihalJainNihalJain commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

…ang.ClassCastException

@nikita15p@NihalJain
HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l…
92cfcef
…ang.ClassCastException (apache#5346)
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Sep 21, 2023
@NihalJain

NihalJain commented Sep 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Backports #5346
Raised on behalf of @nikita15p

@Apache-HBase

Apache-HBase commented Sep 21, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 19sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 48sbranch-2 passed
+1 💚compile0m 14sbranch-2 passed
+1 💚shadedjars4m 55sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 14sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 10sthe patch passed
+1 💚compile0m 13sthe patch passed
+1 💚javac0m 13sthe patch passed
+1 💚shadedjars4m 53spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 11sthe patch passed
_ Other Tests _
+1 💚unit1m 37shbase-examples in the patch passed.
19m 31s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#5425
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a0396a4c779e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 3ddadcf
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/testReport/
Max. process+thread count1654 (vs. ulimit of 30000)
modulesC: hbase-examples U: hbase-examples
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 21, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 17sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall3m 28sbranch-2 passed
+1 💚compile0m 19sbranch-2 passed
+1 💚shadedjars5m 24sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 18sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile0m 17sthe patch passed
+1 💚javac0m 17sthe patch passed
+1 💚shadedjars4m 54spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 15sthe patch passed
_ Other Tests _
+1 💚unit1m 40shbase-examples in the patch passed.
20m 32s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5425
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1105512afd9c 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 3ddadcf
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/testReport/
Max. process+thread count1478 (vs. ulimit of 30000)
modulesC: hbase-examples U: hbase-examples
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 21, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚mvninstall3m 52sbranch-2 passed
+1 💚compile0m 26sbranch-2 passed
+1 💚checkstyle0m 12sbranch-2 passed
+1 💚spotless0m 55sbranch has no errors when running spotless:check.
+1 💚spotbugs0m 33sbranch-2 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile0m 25sthe patch passed
-0 ⚠️javac0m 25shbase-examples generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
+1 💚checkstyle0m 10sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck16m 50sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚spotless0m 45spatch has no errors when running spotless:check.
+1 💚spotbugs0m 37sthe patch passed
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
30m 23s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5425
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 5f19ff8d6f4e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 3ddadcf
Default JavaEclipse Adoptium-11.0.17+8
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-examples.txt
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-examples U: hbase-examples
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain

NihalJain commented Sep 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Will merge this to branch-2 tomorrow!

Also as mentioned earlier in #5346MultiThreadedClientExample is broken on branch-2.x . This patch fixes the issue and adds a test for ensuring it does not break again in future. Please let me know if we would want this in branch-2.5, branch-2.4
CC: @Apache9 , @ndimiduk, @petersomogyi

@NihalJain
NihalJain merged commit 8caebc3 into apache:branch-2Sep 26, 2023
NihalJain added a commit that referenced this pull request Sep 26, 2023
@NihalJain@nikita15p
HBASE-27991[hbase-examples] MultiThreadedClientExample throws java.l…
70d136b
…ang.ClassCastException (#5346) (#5425)
Co-authored-by: Nikita Pande <nikita15p@gmail.com>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 8caebc3)
NihalJain added a commit that referenced this pull request Sep 26, 2023
@NihalJain@nikita15p
HBASE-27991[hbase-examples] MultiThreadedClientExample throws java.l…
ae7dc1d
…ang.ClassCastException (#5346) (#5425)
Co-authored-by: Nikita Pande <nikita15p@gmail.com>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 8caebc3)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@NihalJain@nikita15p@petersomogyi
HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l…
15524d7
…ang.ClassCastException (apache#5346) (apache#5425)
Co-authored-by: Nikita Pande <nikita15p@gmail.com>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 8caebc3)
(cherry picked from commit ae7dc1d)
Change-Id: I219fe1b66e224291193c0c41d72056e8004731c1
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NihalJain@Apache-HBase@Apache9@nikita15p