Uh oh!
There was an error while loading. Please reload this page.
HBASE-28113 Modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock - #5442
Merged
Conversation
… modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock.
Apache-HBase
commented
Sep 28, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 28, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 28, 2023
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Oct 7, 2023
Apache9
left a comment
Contributor
There was a problem hiding this comment.
Make the tryLock timeout configurable? And is 10 seconds a suitable default value? For me I think it is too long...
| serverName, regionNode, diff); | ||
| // It is likely that another thread is currently holding the lock. To avoid deadlock, use | ||
| // tryLock waiting for a specified period of time | ||
| if (regionNode.tryLock(10, TimeUnit.SECONDS)) { |
Contributor
There was a problem hiding this comment.
tryLock should be placed outside the try block, as we do not need to unlock if we get a false here.
ContributorAuthor
There was a problem hiding this comment.
@Apache9 Thank you for your suggestion. The position of the tryLock has been adjusted.
Contributor
There was a problem hiding this comment.
Maybe we could just use tryLock without any timeout? Then it will not throw any exceptions so we do not need this two level try catch block. For me I think it is OK as this is not a critical check.
ContributorAuthor
There was a problem hiding this comment.
This is a very good suggestion, and it has been adjusted accordingly.
Apache-HBase
commented
Oct 7, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 7, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 7, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 16, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 16, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 16, 2023
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Oct 16, 2023
| if (diff > lag) { | ||
| LOG.warn("Reporting {} state does not match {} (time since last update={}ms)", | ||
| serverName, regionNode, diff); | ||
| // It is likely that another thread is currently holding the lock. To avoid deadlock, use |
Contributor
There was a problem hiding this comment.
The comment is incorrect now? And better mention that this is just a fallback check for checking unexpected incosistency. This is what ChatGPT suggested
This is just a fallback check designed to identify unexpected data inconsistencies, so we use tryLock to attempt to acquire the lock, and if the lock cannot be acquired, we skip the check. This will not cause any additional problems and also prevents the regionServerReport call from being stuck for too long which may cause deadlock on region assignment.
ContributorAuthor
There was a problem hiding this comment.
Thank you for your advice and the suggestions from ChatGPT are very valuable and worth considering.
Apache-HBase
commented
Oct 16, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 16, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 16, 2023
💔 -1 overall
This message was automatically generated. |
Apache9
approved these changes
Oct 17, 2023
hiping-tech
commented
Oct 18, 2023
ContributorAuthor
Hi, @Apache9 Based on my assessment, the failure of the unit test is not related to this modification. I can manually run the unit test and still pass. |
Apache9 pushed a commit
that referenced
this pull request
Oct 19, 2023
…heckOnlineRegionsReport to tryLock (#5442) * To prevent threads from being blocked by the lock of RegionStateNode, modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock. Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit e07d1fe)
Apache9 pushed a commit
that referenced
this pull request
Oct 19, 2023
…heckOnlineRegionsReport to tryLock (#5442) * To prevent threads from being blocked by the lock of RegionStateNode, modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock. Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit e07d1fe)
Apache9 pushed a commit
that referenced
this pull request
Oct 19, 2023
…heckOnlineRegionsReport to tryLock (#5442) * To prevent threads from being blocked by the lock of RegionStateNode, modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock. Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit e07d1fe)
Apache9 pushed a commit
that referenced
this pull request
Oct 19, 2023
…heckOnlineRegionsReport to tryLock (#5442) * To prevent threads from being blocked by the lock of RegionStateNode, modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock. Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit e07d1fe)
wchevreuil pushed a commit
to wchevreuil/hbase
that referenced
this pull request
Nov 2, 2023
…heckOnlineRegionsReport to tryLock (apache#5442) * To prevent threads from being blocked by the lock of RegionStateNode, modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock. Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com> Signed-off-by: Duo Zhang <zhangduo@apache.org>
vinayakphegde pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…heckOnlineRegionsReport to tryLock (apache#5442) * To prevent threads from being blocked by the lock of RegionStateNode, modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock. Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit e07d1fe) (cherry picked from commit cd3a83f) Change-Id: Ib90080d08c703c30c25e52faa0a597fc3970bc62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent threads from being blocked by the lock of RegionStateNode, modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock.