HBASE-22930 Set unique name to longCompactions/shortCompactions threads by pankaj72981 · Pull Request #548 · apache/hbase

pankaj72981 · 2019-08-27T08:57:59Z

Appended the counter in the thread name.

Apache-HBase · 2019-08-27T22:27:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	32	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	361	master passed
+1	compile	62	master passed
+1	checkstyle	97	master passed
+1	shadedjars	323	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	41	master passed
0	spotbugs	307	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	305	master passed
		_ Patch Compile Tests _
+1	mvninstall	352	the patch passed
+1	compile	60	the patch passed
+1	javac	60	the patch passed
+1	checkstyle	89	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	307	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1053	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	37	the patch passed
+1	findbugs	283	the patch passed
		_ Other Tests _
-1	unit	10004	hbase-server in the patch failed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		13835

Reason	Tests
Failed junit tests	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/1/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux acb677970e79 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `5106f28`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/1/testReport/
Max. process+thread count	4779 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-28T10:33:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	141	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	506	master passed
+1	compile	79	master passed
+1	checkstyle	121	master passed
+1	shadedjars	419	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	56	master passed
0	spotbugs	344	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	338	master passed
		_ Patch Compile Tests _
+1	mvninstall	488	the patch passed
+1	compile	85	the patch passed
+1	javac	85	the patch passed
+1	checkstyle	92	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	381	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1351	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	53	the patch passed
+1	findbugs	396	the patch passed
		_ Other Tests _
+1	unit	14942	hbase-server in the patch passed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		20027

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/2/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4b4503141960 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `56980fb`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/2/testReport/
Max. process+thread count	4821 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-28T21:29:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	49	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	1	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	434	master passed
+1	compile	68	master passed
+1	checkstyle	98	master passed
+1	shadedjars	329	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	43	master passed
0	spotbugs	304	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	301	master passed
		_ Patch Compile Tests _
+1	mvninstall	422	the patch passed
+1	compile	70	the patch passed
+1	javac	70	the patch passed
+1	checkstyle	101	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	363	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1294	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	42	the patch passed
+1	findbugs	311	the patch passed
		_ Other Tests _
-1	unit	10250	hbase-server in the patch failed.
+1	asflicense	30	The patch does not generate ASF License warnings.
		14693

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestReplicationDroppedTables

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/3/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 72fd170c811d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `56980fb`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/3/testReport/
Max. process+thread count	5705 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-29T22:42:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	327	master passed
+1	compile	56	master passed
+1	checkstyle	77	master passed
+1	shadedjars	267	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	239	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	237	master passed
		_ Patch Compile Tests _
+1	mvninstall	297	the patch passed
+1	compile	56	the patch passed
+1	javac	56	the patch passed
+1	checkstyle	77	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	273	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	925	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	35	the patch passed
+1	findbugs	242	the patch passed
		_ Other Tests _
+1	unit	9561	hbase-server in the patch passed.
+1	asflicense	30	The patch does not generate ASF License warnings.
		12920

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/4/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7aa3d957947d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `83e7794`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/4/testReport/
Max. process+thread count	5043 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-30T05:42:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	335	master passed
+1	compile	60	master passed
+1	checkstyle	78	master passed
+1	shadedjars	269	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	master passed
0	spotbugs	247	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	245	master passed
		_ Patch Compile Tests _
+1	mvninstall	312	the patch passed
+1	compile	56	the patch passed
+1	javac	56	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	277	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	944	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	249	the patch passed
		_ Other Tests _
+1	unit	10307	hbase-server in the patch passed.
+1	asflicense	30	The patch does not generate ASF License warnings.
		13725

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/5/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1a67dd1182a8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `090c55f`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/5/testReport/
Max. process+thread count	5038 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-30T11:38:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	48	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	404	master passed
+1	compile	69	master passed
+1	checkstyle	98	master passed
+1	shadedjars	303	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	master passed
0	spotbugs	250	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	249	master passed
		_ Patch Compile Tests _
+1	mvninstall	297	the patch passed
+1	compile	57	the patch passed
+1	javac	57	the patch passed
+1	checkstyle	83	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	282	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	978	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	249	the patch passed
		_ Other Tests _
+1	unit	10364	hbase-server in the patch passed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		13971

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/6/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d4a523e76468 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `090c55f`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/6/testReport/
Max. process+thread count	4627 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-31T18:26:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	142	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	489	master passed
+1	compile	78	master passed
+1	checkstyle	102	master passed
+1	shadedjars	360	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	41	master passed
0	spotbugs	290	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	285	master passed
		_ Patch Compile Tests _
+1	mvninstall	440	the patch passed
+1	compile	77	the patch passed
+1	javac	77	the patch passed
+1	checkstyle	103	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	366	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1278	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	46	the patch passed
+1	findbugs	248	the patch passed
		_ Other Tests _
-1	unit	14312	hbase-server in the patch failed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		18860

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/7/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 59c13823f575 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `ee5cf0d`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/7/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/7/testReport/
Max. process+thread count	5116 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-31T23:27:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	406	master passed
+1	compile	68	master passed
+1	checkstyle	94	master passed
+1	shadedjars	343	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	45	master passed
0	spotbugs	281	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	279	master passed
		_ Patch Compile Tests _
+1	mvninstall	378	the patch passed
+1	compile	65	the patch passed
+1	javac	65	the patch passed
+1	checkstyle	97	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	352	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1178	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	39	the patch passed
+1	findbugs	287	the patch passed
		_ Other Tests _
-1	unit	9487	hbase-server in the patch failed.
+1	asflicense	32	The patch does not generate ASF License warnings.
		13649

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/8/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 5708e40cd87e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `b642ee0`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/8/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/8/testReport/
Max. process+thread count	4866 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/8/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-01T17:47:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	200	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	371	master passed
+1	compile	62	master passed
+1	checkstyle	90	master passed
+1	shadedjars	308	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	master passed
0	spotbugs	284	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	282	master passed
		_ Patch Compile Tests _
+1	mvninstall	346	the patch passed
+1	compile	64	the patch passed
+1	javac	64	the patch passed
+1	checkstyle	94	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	308	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1063	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	39	the patch passed
+1	findbugs	278	the patch passed
		_ Other Tests _
-1	unit	15195	hbase-server in the patch failed.
+1	asflicense	34	The patch does not generate ASF License warnings.
		19180

Reason	Tests
Failed junit tests	hadoop.hbase.io.hfile.bucket.TestBucketCache

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/9/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b6f678bc5d88 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `97fbaa6`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/9/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/9/testReport/
Max. process+thread count	4954 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-02T03:12:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	130	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	420	master passed
+1	compile	82	master passed
+1	checkstyle	100	master passed
+1	shadedjars	380	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	46	master passed
0	spotbugs	329	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	326	master passed
		_ Patch Compile Tests _
+1	mvninstall	413	the patch passed
+1	compile	80	the patch passed
+1	javac	80	the patch passed
+1	checkstyle	99	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	374	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1336	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	50	the patch passed
+1	findbugs	311	the patch passed
		_ Other Tests _
-1	unit	19449	hbase-server in the patch failed.
+1	asflicense	50	The patch does not generate ASF License warnings.
		24149

Reason	Tests
Failed junit tests	hadoop.hbase.master.TestMasterShutdown
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.util.TestFromClientSide3WoUnsafe
	hadoop.hbase.master.procedure.TestTruncateTableProcedure
	hadoop.hbase.replication.TestReplicationSmallTests
	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/10/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b4832cc871e8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `a5ef6b2`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/10/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/10/testReport/
Max. process+thread count	5450 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/10/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-02T09:51:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	323	master passed
+1	compile	57	master passed
+1	checkstyle	80	master passed
+1	shadedjars	278	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	master passed
0	spotbugs	242	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	241	master passed
		_ Patch Compile Tests _
+1	mvninstall	297	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
+1	checkstyle	78	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	270	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	921	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	242	the patch passed
		_ Other Tests _
-1	unit	9588	hbase-server in the patch failed.
+1	asflicense	36	The patch does not generate ASF License warnings.
		12944

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/11/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b5fe48b3a038 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `d32bf8d`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/11/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/11/testReport/
Max. process+thread count	4754 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/11/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-02T21:30:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	417	master passed
+1	compile	68	master passed
+1	checkstyle	92	master passed
+1	shadedjars	299	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	258	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	256	master passed
		_ Patch Compile Tests _
+1	mvninstall	324	the patch passed
+1	compile	57	the patch passed
+1	javac	57	the patch passed
+1	checkstyle	86	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	292	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1008	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	254	the patch passed
		_ Other Tests _
+1	unit	9320	hbase-server in the patch passed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		13006

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/12/artifact/out/Dockerfile
GITHUB PR	#548
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux cca8ec230999 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-548/out/precommit/personality/provided.sh
git revision	master / `8e8bd8b`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/12/testReport/
Max. process+thread count	4402 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-548/12/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack · 2019-08-27T22:21:33Z

+ new ThreadPoolExecutor(largeThreads, largeThreads, 60, TimeUnit.SECONDS, stealJobQueue,
+ new ThreadFactoryBuilder().setNameFormat(n + "-longCompactions-"
+ + longCompactionThreadCounter.getAndIncrement() + "-" + System.currentTimeMillis())
+ .setDaemon(true).build());


Does this work @pankaj72981 ? Each time we create a new thread in ThreadPoolExecutor, does the local longCompactionThreadCounter get a #getAndIncrement call so each thread gets an id? If so, do we need the System.currentTimeMillis thing?

Thanks @saintstack Sir for looking into this issue.
Each time we create a new thread in ThreadPoolExecutor, does the local longCompactionThreadCounter get a #getAndIncrement call so each thread gets an id?
longCompactionThreadCounter works properly, each thread will have incremented ID.
do we need the System.currentTimeMillis thing?
Not so much required, will be better to have.

saintstack · 2019-08-27T22:23:37Z

+ this.shortCompactions = new ThreadPoolExecutor(smallThreads, smallThreads, 60, TimeUnit.SECONDS,
+ stealJobQueue.getStealFromQueue(),
+ new ThreadFactoryBuilder().setNameFormat(n + "-shortCompactions-"
+ + shortCompactionThreadCounter.getAndIncrement() + "-" + System.currentTimeMillis())


Does the 'n' have a thread number in it? If so, do we need this AtomicInteger? Drop the currentTimeMillis and counter and just decorate with -short or -long compaction addition?

Does the 'n' have a thread number in it?
No, it will be just RS name/ip-port.
May be you can have a look into below discussion,
https://issues.apache.org/jira/browse/HBASE-22930?focusedCommentId=16922548&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16922548

saintstack · 2019-09-03T18:02:06Z

Sorry @pankaj72981 I'm figuring that I do reviews but forget to do the 'submit' step so you don't see them.. they just hang out. My fault.

…ds (#548)

…ns threads (#548)" This reverts commit b6d17f6.

…ns threads (#548)" This reverts commit d3cb7b4.

…ns threads (#548)" This reverts commit 018181c.

…ns threads (#548)" This reverts commit 0f0a3a2.

…ds (apache#548)

…ns threads (apache#548)" This reverts commit d3cb7b4.

…ds (apache#548) (cherry picked from commit d3cb7b4) Change-Id: Ibe941d57377a84847c2a85048742c7e523b8de08

…ns threads (apache#548)" This reverts commit d3cb7b4. (cherry picked from commit 6a778b8) Change-Id: I8f05d4e8aebe5e2f94ca982a53dd46102ccc0f26

HBASE-22930 Set unique name to longCompactions/shortCompactions threads
1e0b25f

saintstack reviewed Sep 3, 2019
View reviewed changes

saintstack merged commit 0f0a3a2 into apache:masterSep 4, 2019

asfgit pushed a commit that referenced this pull request Sep 4, 2019
HBASE-22930Set unique name to longCompactions/shortCompactions threa…
018181c
…ds (#548)

asfgit pushed a commit that referenced this pull request Sep 4, 2019
HBASE-22930Set unique name to longCompactions/shortCompactions threa…
d3cb7b4
…ds (#548)

asfgit pushed a commit that referenced this pull request Sep 4, 2019
HBASE-22930Set unique name to longCompactions/shortCompactions threa…
b6d17f6
…ds (#548)

asfgit pushed a commit that referenced this pull request Sep 4, 2019
Revert "HBASE-22930Set unique name to longCompactions/shortCompactio…
352240c
…ns threads (#548)" This reverts commit b6d17f6.

asfgit pushed a commit that referenced this pull request Sep 4, 2019
Revert "HBASE-22930Set unique name to longCompactions/shortCompactio…
6a778b8
…ns threads (#548)" This reverts commit d3cb7b4.

asfgit pushed a commit that referenced this pull request Sep 4, 2019
Revert "HBASE-22930Set unique name to longCompactions/shortCompactio…
aeacfd3
…ns threads (#548)" This reverts commit 018181c.

asfgit pushed a commit that referenced this pull request Sep 4, 2019
Revert "HBASE-22930Set unique name to longCompactions/shortCompactio…
0d338a1
…ns threads (#548)" This reverts commit 0f0a3a2.

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
HBASE-22930 Set unique name to longCompactions/shortCompactions threa…
e5a904f
…ds (apache#548)

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
Revert "HBASE-22930 Set unique name to longCompactions/shortCompactio…
4b25c2a
…ns threads (apache#548)" This reverts commit d3cb7b4.

symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
HBASE-22930 Set unique name to longCompactions/shortCompactions threa…
6db4386
…ds (apache#548) (cherry picked from commit d3cb7b4) Change-Id: Ibe941d57377a84847c2a85048742c7e523b8de08

Uh oh!

Conversation

pankaj72981 commented Aug 27, 2019

Uh oh!

Apache-HBase commented Aug 27, 2019

Uh oh!

Apache-HBase commented Aug 28, 2019

Uh oh!

Apache-HBase commented Aug 28, 2019

Uh oh!

Apache-HBase commented Aug 29, 2019

Uh oh!

Apache-HBase commented Aug 30, 2019

Uh oh!

Apache-HBase commented Aug 30, 2019

Uh oh!

Apache-HBase commented Aug 31, 2019

Uh oh!

Apache-HBase commented Aug 31, 2019

Uh oh!

Apache-HBase commented Sep 1, 2019

Uh oh!

Apache-HBase commented Sep 2, 2019

Uh oh!

Apache-HBase commented Sep 2, 2019

Uh oh!

Apache-HBase commented Sep 2, 2019

Uh oh!

saintstackAug 27, 2019

Choose a reason for hiding this comment

Uh oh!

pankaj72981Sep 4, 2019

Choose a reason for hiding this comment

Uh oh!

saintstackAug 27, 2019

Choose a reason for hiding this comment

Uh oh!

pankaj72981Sep 4, 2019

Choose a reason for hiding this comment

Uh oh!

saintstack commented Sep 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants