Skip to content

HBASE-28186 Rebase CacheAwareBalance related commits into master branch - #5500

Closed
wchevreuil wants to merge 4 commits into
masterfrom
HBASE-27389-master-rebase
Closed

HBASE-28186 Rebase CacheAwareBalance related commits into master branch#5500
wchevreuil wants to merge 4 commits into
masterfrom
HBASE-27389-master-rebase

Conversation

@wchevreuil

@wchevreuilwchevreuil commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

This PR is for rebasing all the CacheAwareBalancer commits into master. Rahul has shared the design doc in HBASE-27999.

Documentation on how this works and how it can be enabled has been provided in the HBASE-28097 PR

This is relevant for cloud storage deployments, where the cost of moving a large, fully cached region to a new RS is high, requiring reads to go all the way to the cloud storage whilst the region is being "re-cached" on the new RS.

@ragarkar can share more details about his tests results.

@Apache-HBase

Apache-HBase commented Nov 3, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall2m 55smaster passed
+1 💚compile4m 45smaster passed
+1 💚checkstyle1m 13smaster passed
+0 🆗refguide2m 39sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
+1 💚spotbugs11m 35smaster passed
-0 ⚠️patch1m 53sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 38sthe patch passed
+1 💚compile4m 46sthe patch passed
+1 💚cc4m 46sthe patch passed
-0 ⚠️javac4m 46sroot generated 2 new + 910 unchanged - 0 fixed = 912 total (was 910)
-0 ⚠️checkstyle1m 6sroot: The patch generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+0 🆗refguide1m 54spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck9m 47sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚hbaseprotoc3m 46sthe patch passed
+1 💚spotless0m 39spatch has no errors when running spotless:check.
+1 💚spotbugs12m 35sthe patch passed
_ Other Tests _
+1 💚asflicense0m 46sThe patch does not generate ASF License warnings.
69m 42s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5500
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool refguide
unameLinux 044d63166233 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fa4c896
Default JavaEclipse Adoptium-11.0.17+8
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5500/1/yetus-general-check/output/branch-site/book.html
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5500/1/yetus-general-check/output/patch-site/book.html
Max. process+thread count175 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 3, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 21smaster passed
+1 💚compile2m 13smaster passed
+1 💚shadedjars6m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 12smaster passed
-0 ⚠️patch11m 15sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 32sthe patch passed
+1 💚compile2m 30sthe patch passed
+1 💚javac2m 30sthe patch passed
+1 💚shadedjars6m 55spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 11sthe patch passed
_ Other Tests _
-1 ❌unit34m 9sroot in the patch failed.
71m 11s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5500
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7fb1ff50b06e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fa4c896
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/testReport/
Max. process+thread count2460 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 3, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 12sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 28smaster passed
+1 💚compile1m 41smaster passed
+1 💚shadedjars4m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 33smaster passed
-0 ⚠️patch7m 59sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 17sthe patch passed
+1 💚compile1m 41sthe patch passed
+1 💚javac1m 41sthe patch passed
+1 💚shadedjars4m 52spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 34sthe patch passed
_ Other Tests _
-1 ❌unit315m 25sroot in the patch failed.
344m 31s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5500
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e4f08803bf80 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fa4c896
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/testReport/
Max. process+thread count5472 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ragarkar

ragarkar commented Nov 3, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@ragarkar can share more details about his tests results.
Added test results showing that the regions are retained by the region server beyond server restart and the impact on cache has been attached to HBASE-27999.

@Apache-HBase

Apache-HBase commented Nov 3, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 51smaster passed
+1 💚compile4m 49smaster passed
+1 💚checkstyle1m 3smaster passed
+0 🆗refguide3m 15sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
+1 💚spotbugs14m 49smaster passed
-0 ⚠️patch2m 4sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 39sthe patch passed
+1 💚compile4m 54sthe patch passed
+1 💚cc4m 54sthe patch passed
-0 ⚠️javac4m 54sroot generated 2 new + 910 unchanged - 0 fixed = 912 total (was 910)
-0 ⚠️checkstyle1m 7sroot: The patch generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+0 🆗refguide2m 14spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck9m 20sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚hbaseprotoc3m 58sthe patch passed
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs14m 5sthe patch passed
_ Other Tests _
+1 💚asflicense0m 57sThe patch does not generate ASF License warnings.
75m 21s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5500
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool refguide
unameLinux c1f097f48cbf 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fa4c896
Default JavaEclipse Adoptium-11.0.17+8
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5500/2/yetus-general-check/output/branch-site/book.html
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5500/2/yetus-general-check/output/patch-site/book.html
Max. process+thread count177 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 3, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 34smaster passed
+1 💚compile1m 50smaster passed
+1 💚shadedjars5m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 46smaster passed
-0 ⚠️patch8m 33sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 36sthe patch passed
+1 💚compile1m 47sthe patch passed
+1 💚javac1m 47sthe patch passed
+1 💚shadedjars5m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 50sthe patch passed
_ Other Tests _
+1 💚unit269m 41sroot in the patch passed.
301m 38s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5500
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 393a8ee3566e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fa4c896
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/testReport/
Max. process+thread count8226 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 3, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 31smaster passed
+1 💚compile1m 34smaster passed
+1 💚shadedjars5m 21sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 24smaster passed
-0 ⚠️patch8m 16sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 14sthe patch passed
+1 💚compile1m 36sthe patch passed
+1 💚javac1m 36sthe patch passed
+1 💚shadedjars5m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 24sthe patch passed
_ Other Tests _
-1 ❌unit348m 36sroot in the patch failed.
377m 40s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5500
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 24d61e652182 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / fa4c896
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/testReport/
Max. process+thread count5154 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

taklwu
taklwu previously approved these changes Nov 9, 2023
View reviewed changes

@taklwutaklwu left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed all patches and they are the same as the feature branch.

@taklwu
taklwu self-requested a review November 9, 2023 21:49
taklwu
taklwu reviewed Nov 9, 2023
View reviewed changes

@taklwutaklwu left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this commit 895d865 , can we remove the message as part of the commit body ?

Change-Id: I1fc241eaa334b438adbf0e245a1f6a56be605f8d

also I'm wondered how these patches will be landing in master, will it be a single commit ? or will we keep the history of those verified commits , and those rebasing commit how would you handle it ? 2469aca and 917bfce

@taklwu
taklwu dismissed their stale reviewNovember 9, 2023 22:19

I was reviewing the first commit but I didn't know i cannot review and submit approve per each commit

@wchevreuil

wchevreuil commented Nov 10, 2023

Copy link
Copy Markdown
ContributorAuthor

also I'm wondered how these patches will be landing in master, will it be a single commit ? or will we keep the history of those verified commits , and those rebasing commit how would you handle it ? 2469aca and 917bfce

No, idea is to preserve the original commits. Let me squash the rebasing commits in, so that we only have the 4 original commits from Rahul.

@ragarkar@wchevreuil
HBASE-27997Enhance prefetch executor to record region prefetch infor… (
4da1aca
#5339)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewew-by: Kota-SH <shanmukhaharipriya@gmail.com>
@ragarkar@wchevreuil
HBASE-27998Enhance region metrics to include prefetch ratio for each… (
373b6ce
#5342)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@ragarkar@wchevreuil
HBASE-27999Implement cache prefetch aware load balancer (#5376)
07a44b2
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@ragarkar@wchevreuil
HBASE-28097Add documentation section for the Cache Aware balancer fu… (
d3f8d16
#5495)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@wchevreuil
wchevreuilforce-pushed the HBASE-27389-master-rebase branch from 484030f to d3f8d16CompareNovember 10, 2023 12:37
@wchevreuil

wchevreuil commented Nov 10, 2023

Copy link
Copy Markdown
ContributorAuthor

@taklwu , I had now squashed the rebase commits with the original ones and solved the conflicts. I believe this would allow us to merge only the original 4 commits from @ragarkar into master branch.

@Apache-HBase

Apache-HBase commented Nov 10, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 12sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 20smaster passed
+1 💚compile1m 41smaster passed
+1 💚shadedjars4m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 35smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
-1 ❌mvninstall0m 26sroot in the patch failed.
-1 ❌compile0m 9sroot in the patch failed.
-0 ⚠️javac0m 9sroot in the patch failed.
-1 ❌shadedjars1m 22spatch has 76 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 7shbase-protocol-shaded in the patch failed.
-0 ⚠️javadoc0m 22shbase-server generated 3 new + 22 unchanged - 0 fixed = 25 total (was 22)
-0 ⚠️javadoc0m 9sroot in the patch failed.
_ Other Tests _
-1 ❌unit3m 25sroot in the patch failed.
20m 18s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5500
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 411022a6aa8d 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7f3921a
Default JavaTemurin-1.8.0_352-b08
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-protocol-shaded.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-root.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/testReport/
Max. process+thread count651 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 10, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall2m 55smaster passed
+1 💚compile1m 49smaster passed
+1 💚shadedjars5m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
-1 ❌mvninstall0m 26sroot in the patch failed.
-1 ❌compile0m 9sroot in the patch failed.
-0 ⚠️javac0m 9sroot in the patch failed.
-1 ❌shadedjars1m 22spatch has 76 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 6shbase-protocol-shaded in the patch failed.
-0 ⚠️javadoc0m 21shbase-server generated 3 new + 94 unchanged - 1 fixed = 97 total (was 95)
-0 ⚠️javadoc0m 9sroot in the patch failed.
_ Other Tests _
-1 ❌unit3m 31sroot in the patch failed.
22m 18s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5500
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 57e126674fe3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7f3921a
Default JavaEclipse Adoptium-11.0.17+8
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-protocol-shaded.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
javadochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/testReport/
Max. process+thread count641 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 10, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 53smaster passed
+1 💚compile4m 50smaster passed
+1 💚checkstyle1m 10smaster passed
+0 🆗refguide2m 24sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs11m 38smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
-1 ❌mvninstall0m 26sroot in the patch failed.
-1 ❌compile0m 10sroot in the patch failed.
-0 ⚠️cc0m 10sroot in the patch failed.
-0 ⚠️javac0m 10sroot in the patch failed.
-0 ⚠️checkstyle1m 3sroot: The patch generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+0 🆗refguide1m 58spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
-1 ❌hadoopcheck0m 7sThe patch causes 76 errors with Hadoop v3.2.4.
-1 ❌hadoopcheck0m 14sThe patch causes 76 errors with Hadoop v3.3.6.
-1 ❌hbaseprotoc0m 5shbase-protocol-shaded in the patch failed.
-1 ❌hbaseprotoc0m 15shbase-client in the patch failed.
-1 ❌hbaseprotoc0m 11shbase-balancer in the patch failed.
-1 ❌hbaseprotoc0m 26shbase-server in the patch failed.
-1 ❌hbaseprotoc0m 9sroot in the patch failed.
+1 💚spotless0m 37spatch has no errors when running spotless:check.
-1 ❌spotbugs0m 6shbase-protocol-shaded in the patch failed.
-1 ❌spotbugs0m 13shbase-client in the patch failed.
-1 ❌spotbugs0m 10shbase-balancer in the patch failed.
-1 ❌spotbugs0m 26shbase-server in the patch failed.
-1 ❌spotbugs0m 12sroot in the patch failed.
_ Other Tests _
+1 💚asflicense0m 39sThe patch does not generate ASF License warnings.
34m 20s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5500
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool refguide
unameLinux eff3038966fe 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7f3921a
Default JavaEclipse Adoptium-11.0.17+8
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5500/3/yetus-general-check/output/branch-site/book.html
mvninstallhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-compile-root.txt
cchttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-compile-root.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-compile-root.txt
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
refguidehttps://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5500/3/yetus-general-check/output/patch-site/book.html
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-protocol-shaded.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-balancer.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
hbaseprotochttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-hbaseprotoc-root.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-protocol-shaded.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-balancer.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
spotbugshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/artifact/yetus-general-check/output/patch-spotbugs-root.txt
Max. process+thread count175 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-balancer hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5500/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
wchevreuil deleted the HBASE-27389-master-rebase branch November 13, 2023 14:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtellapurtellAwaiting requested review from apurtell
@bbeaudreaultbbeaudreaultAwaiting requested review from bbeaudreault
@ankitsinghalankitsinghalAwaiting requested review from ankitsinghal
@petersomogyipetersomogyiAwaiting requested review from petersomogyi
@Apache9Apache9Awaiting requested review from Apache9
@taklwutaklwuAwaiting requested review from taklwu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wchevreuil@Apache-HBase@ragarkar@taklwu