Uh oh!
There was an error while loading. Please reload this page.
HBASE-28186 Rebase CacheAwareBalance related commits into master branch - #5519
Conversation
Apache-HBase
commented
Nov 13, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 13, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 13, 2023
💔 -1 overall
This message was automatically generated. |
taklwu
commented
Nov 13, 2023
mostly good but can you fix all build failures? |
#5339) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Reviewew-by: Kota-SH <shanmukhaharipriya@gmail.com>
591e01b to
ae45634CompareApache-HBase
commented
Nov 14, 2023
🎊 +1 overall
This message was automatically generated. |
| // If two servers have same region cache ratio, then the server currently hosting the | ||
| // region | ||
| // should retain the region |
| toPB(Map<String, Boolean> prefetchedHfileNames) { | ||
| return PersistentPrefetchProtos.PrefetchedHfileName.newBuilder() | ||
| .putAllPrefetchedFiles(prefetchedHfileNames).build(); | ||
| toPB(Map<String, Pair<String, Long>> prefetchedHfileNames) { |
There was a problem hiding this comment.
It is hard for me to find out what is in Map<String, Pair<String, Long>>. Is it possible to replaces at least Pair<String, Long> with a class?
Apache-HBase
commented
Nov 14, 2023
🎊 +1 overall
This message was automatically generated. |
Thanks @taklwu@meszibalu for the suggestions. I'm trying to get the PR passing build first by pushing each commit individually, please hold on from reviewing it for now until I have all the four commits passing. |
Apache-HBase
commented
Nov 14, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 14, 2023
Apache-HBase
commented
Nov 14, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 14, 2023
💔 -1 overall
This message was automatically generated. |
wchevreuil
commented
Nov 14, 2023
It looks like the pre-commit build fails to acknowledge the protobuf changes, ain't sure why. |
Apache-HBase
commented
Nov 15, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 15, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 15, 2023
💔 -1 overall
This message was automatically generated. |
1797e44 to
ae45634CompareApache-HBase
commented
Nov 15, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 15, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 15, 2023
🎊 +1 overall
This message was automatically generated. |
No description provided.