Uh oh!
There was an error while loading. Please reload this page.
HBASE-27795: Define RPC API for cache cleaning - #5525
Closed
Kota-SH wants to merge 1 commit into
Closed
Conversation
Kota-SHforce-pushed
the
hbase-27398-new
branch
from
November 17, 2023 04:32
b13033d to
d4baad9CompareApache-HBase
commented
Nov 17, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 17, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 17, 2023
💔 -1 overall
This message was automatically generated. |
Kota-SHforce-pushed
the
hbase-27398-new
branch
from
November 17, 2023 22:04
d4baad9 to
f721c7cCompareApache-HBase
commented
Nov 17, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 18, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Nov 18, 2023
💔 -1 overall
This message was automatically generated. |
Apache9
reviewed
Nov 25, 2023
Apache9
left a comment
Contributor
There was a problem hiding this comment.
What will happen if the region is moved back while we are cleaning its blocks in block cache?
And we only implement the uncache method for BucketCache? What about other types of BlockCache?
| * @param server HRegionServer | ||
| * @return A map of filename and number of blocks evicted. | ||
| */ | ||
| default Optional<Map<String, Integer>> uncacheStaleBlocks(HRegionServer server) { |
Contributor
There was a problem hiding this comment.
I prefer here we pass an interface, for testing whether a region is available, instead of pass a HRegionServer directly. It will be easier for testing.
And just returning a Map is enough? If we do not clean any blocks, just return an empty map?
| } else { | ||
| blocksEvicted = 0; | ||
| } | ||
| } catch (NotServingRegionException nsre) { |
Contributor
There was a problem hiding this comment.
Is this the normal path? In the above if condition, we test isAvailable, so why here we could still get a NotServingRegionException?
Kota-SH
commented
Dec 1, 2023
ContributorAuthor
@Apache9 - Thanks for the review.
Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.