HBASE-22887 Fix HFileOutputFormat2 writer roll by langdamao · Pull Request #554 · apache/hbase

langdamao · 2019-08-28T10:34:04Z

Issue detail: https://issues.apache.org/jira/browse/HBASE-22887

writer roll only if wl.written is too long and previousRow is not equal.
delete bool rollRequested because different writter roll independently, so they don't need to communicate.

Signed-off-by: langdamao lang--lang--lang@163.com

Signed-off-by: langdamao <lang--lang--lang@163.com>

Apache-HBase · 2019-08-28T18:42:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	76	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	360	master passed
+1	compile	27	master passed
+1	checkstyle	21	master passed
+1	shadedjars	300	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	18	master passed
0	spotbugs	54	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	52	master passed
		_ Patch Compile Tests _
+1	mvninstall	336	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	21	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	308	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1036	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	17	the patch passed
+1	findbugs	60	the patch passed
		_ Other Tests _
+1	unit	1392	hbase-mapreduce in the patch passed.
+1	asflicense	17	The patch does not generate ASF License warnings.
		4493

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/1/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6678b9bd62b5 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `56980fb`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/1/testReport/
Max. process+thread count	5036 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-29T20:00:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	47	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	331	master passed
+1	compile	27	master passed
+1	checkstyle	23	master passed
+1	shadedjars	273	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	20	master passed
0	spotbugs	53	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	50	master passed
		_ Patch Compile Tests _
+1	mvninstall	295	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	20	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	275	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	914	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	18	the patch passed
+1	findbugs	55	the patch passed
		_ Other Tests _
-1	unit	1094	hbase-mapreduce in the patch failed.
+1	asflicense	15	The patch does not generate ASF License warnings.
		3850

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/2/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 69ee9677daf8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `83e7794`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/2/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/2/testReport/
Max. process+thread count	5384 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-29T23:40:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	446	master passed
+1	compile	29	master passed
+1	checkstyle	21	master passed
+1	shadedjars	300	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	18	master passed
0	spotbugs	51	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	48	master passed
		_ Patch Compile Tests _
+1	mvninstall	331	the patch passed
+1	compile	26	the patch passed
+1	javac	26	the patch passed
+1	checkstyle	19	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	302	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1044	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	16	the patch passed
+1	findbugs	61	the patch passed
		_ Other Tests _
-1	unit	1115	hbase-mapreduce in the patch failed.
+1	asflicense	15	The patch does not generate ASF License warnings.
		4240

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshot
	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/3/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1aff48fd2c04 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `f6a4c66`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/3/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/3/testReport/
Max. process+thread count	5253 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-30T06:39:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	376	master passed
+1	compile	30	master passed
+1	checkstyle	23	master passed
+1	shadedjars	289	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	20	master passed
0	spotbugs	55	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	52	master passed
		_ Patch Compile Tests _
+1	mvninstall	308	the patch passed
+1	compile	30	the patch passed
+1	javac	30	the patch passed
+1	checkstyle	22	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	285	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	957	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	18	the patch passed
+1	findbugs	58	the patch passed
		_ Other Tests _
-1	unit	1083	hbase-mapreduce in the patch failed.
+1	asflicense	20	The patch does not generate ASF License warnings.
		3997

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/4/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 57e954d8bc83 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `090c55f`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/4/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/4/testReport/
Max. process+thread count	5428 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-31T14:22:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	83	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	344	master passed
+1	compile	28	master passed
+1	checkstyle	26	master passed
+1	shadedjars	305	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	18	master passed
0	spotbugs	55	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	53	master passed
		_ Patch Compile Tests _
+1	mvninstall	321	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	19	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	290	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	977	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	17	the patch passed
+1	findbugs	53	the patch passed
		_ Other Tests _
+1	unit	1336	hbase-mapreduce in the patch passed.
+1	asflicense	16	The patch does not generate ASF License warnings.
		4301

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/5/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b4dda039e94b 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `ee5cf0d`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/5/testReport/
Max. process+thread count	5313 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-31T16:24:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	347	master passed
+1	compile	27	master passed
+1	checkstyle	21	master passed
+1	shadedjars	289	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	20	master passed
0	spotbugs	57	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	54	master passed
		_ Patch Compile Tests _
+1	mvninstall	309	the patch passed
+1	compile	28	the patch passed
+1	javac	28	the patch passed
+1	checkstyle	21	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	282	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	981	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	18	the patch passed
+1	findbugs	55	the patch passed
		_ Other Tests _
+1	unit	1225	hbase-mapreduce in the patch passed.
+1	asflicense	17	The patch does not generate ASF License warnings.
		4113

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/6/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 0b7391ee575c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `b642ee0`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/6/testReport/
Max. process+thread count	5475 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-01T13:55:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	121	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	486	master passed
+1	compile	35	master passed
+1	checkstyle	30	master passed
+1	shadedjars	361	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	25	master passed
0	spotbugs	68	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	65	master passed
		_ Patch Compile Tests _
+1	mvninstall	402	the patch passed
+1	compile	32	the patch passed
+1	javac	32	the patch passed
+1	checkstyle	24	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	368	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1433	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	20	the patch passed
+1	findbugs	76	the patch passed
		_ Other Tests _
-1	unit	1669	hbase-mapreduce in the patch failed.
+1	asflicense	17	The patch does not generate ASF License warnings.
		5710

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/7/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux befec5fd6679 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `97fbaa6`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/7/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/7/testReport/
Max. process+thread count	5208 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-01T18:07:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	75	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	357	master passed
+1	compile	27	master passed
+1	checkstyle	23	master passed
+1	shadedjars	307	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	19	master passed
0	spotbugs	61	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	58	master passed
		_ Patch Compile Tests _
+1	mvninstall	334	the patch passed
+1	compile	28	the patch passed
+1	javac	28	the patch passed
+1	checkstyle	20	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	302	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1047	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	17	the patch passed
+1	findbugs	57	the patch passed
		_ Other Tests _
-1	unit	1438	hbase-mapreduce in the patch failed.
+1	asflicense	18	The patch does not generate ASF License warnings.
		4538

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/8/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 09ec40216e72 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `345c21d`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/8/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/8/testReport/
Max. process+thread count	5411 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/8/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-01T23:01:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	34	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	323	master passed
+1	compile	27	master passed
+1	checkstyle	21	master passed
+1	shadedjars	271	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	23	master passed
0	spotbugs	49	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	48	master passed
		_ Patch Compile Tests _
+1	mvninstall	296	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	20	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	273	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	917	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	18	the patch passed
+1	findbugs	51	the patch passed
		_ Other Tests _
-1	unit	1059	hbase-mapreduce in the patch failed.
+1	asflicense	19	The patch does not generate ASF License warnings.
		3792

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/9/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 36d1a6ba9823 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `a5ef6b2`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/9/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/9/testReport/
Max. process+thread count	5405 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-02T06:17:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	359	master passed
+1	compile	29	master passed
+1	checkstyle	24	master passed
+1	shadedjars	293	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	20	master passed
0	spotbugs	57	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	54	master passed
		_ Patch Compile Tests _
+1	mvninstall	314	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	21	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	291	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	989	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	19	the patch passed
+1	findbugs	57	the patch passed
		_ Other Tests _
+1	unit	1135	hbase-mapreduce in the patch passed.
+1	asflicense	19	The patch does not generate ASF License warnings.
		4077

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/10/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 767348ce9935 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `d32bf8d`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/10/testReport/
Max. process+thread count	5487 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/10/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-02T13:27:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	90	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	361	master passed
+1	compile	27	master passed
+1	checkstyle	22	master passed
+1	shadedjars	309	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	19	master passed
0	spotbugs	55	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	52	master passed
		_ Patch Compile Tests _
+1	mvninstall	334	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	21	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	308	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1077	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	20	the patch passed
+1	findbugs	63	the patch passed
		_ Other Tests _
+1	unit	1387	hbase-mapreduce in the patch passed.
+1	asflicense	15	The patch does not generate ASF License warnings.
		4532

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/11/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 368755c45303 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `8e8bd8b`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/11/testReport/
Max. process+thread count	5066 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/11/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack

Any chance of a UT?

saintstack

Patch LGTM. Can we have a unit test? Thanks.

langdamao · 2019-09-17T08:04:15Z

Patch LGTM. Can we have a unit test? Thanks.

Sorry for miss the last message.
Yes， I think TestHFileOutputFormat2 fits this. Is this comprehensive enought for this patch?
I don't know how to make it more strong for this patch. Could you give me some suggestions, please？
Thank you so much :)

infraio · 2019-09-24T06:01:11Z

@langdamao You can check TestHFileOutputFormat2#testWritingPEData to write a ut and test the generated files size is small than a value.

langdamao · 2019-09-24T10:00:27Z

@langdamao You can check TestHFileOutputFormat2#testWritingPEData to write a ut and test the generated files size is small than a value.

Got it, thank you so much! I'll try!

Signed-off-by: langdamao <lang--lang--lang@163.com>

Apache-HBase · 2019-10-08T14:25:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
💙	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
💚	dupname	0m 0s	No case conflicting files found.
💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
💚	@author	0m 0s	The patch does not contain any @author tags.
💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
💚	mvninstall	6m 24s	master passed
💚	compile	0m 27s	master passed
💚	checkstyle	0m 22s	master passed
💚	shadedjars	4m 36s	branch has no errors when building our shaded downstream artifacts.
💚	javadoc	0m 20s	master passed
💙	spotbugs	0m 55s	Used deprecated FindBugs config; considering switching to SpotBugs.
💚	findbugs	0m 53s	master passed
		_ Patch Compile Tests _
💚	mvninstall	4m 56s	the patch passed
💚	compile	0m 26s	the patch passed
💚	javac	0m 26s	the patch passed
💚	checkstyle	0m 22s	the patch passed
💚	whitespace	0m 0s	The patch has no whitespace issues.
💚	shadedjars	4m 35s	patch has no errors when building our shaded downstream artifacts.
💚	hadoopcheck	15m 31s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚	javadoc	0m 19s	the patch passed
💚	findbugs	0m 53s	the patch passed
		_ Other Tests _
💚	unit	17m 19s	hbase-mapreduce in the patch passed.
💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		64m 48s

Subsystem	Report/Notes
Docker	Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/12/artifact/out/Dockerfile
GITHUB PR	#554
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 901e909e4ce6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-554/out/precommit/personality/provided.sh
git revision	master / `e911bb7`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/12/testReport/
Max. process+thread count	5646 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-554/12/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: langdamao <lang--lang--lang@163.com>

HBASE-22887 Fix HFileOutputFormat2 writer roll
b8e0db3
Signed-off-by: langdamao <lang--lang--lang@163.com>

saintstack reviewed Sep 14, 2019
View reviewed changes

Comment threadhbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java

saintstack requested changes Sep 16, 2019
View reviewed changes

add ut
f726e2f
Signed-off-by: langdamao <lang--lang--lang@163.com>

langdamao requested a review from saintstack October 8, 2019 13:17

saintstack merged commit 128b480 into apache:masterOct 8, 2019

asfgit pushed a commit that referenced this pull request Oct 8, 2019
HBASE-22887Fix HFileOutputFormat2 writer roll (#554)
f40c745
Signed-off-by: langdamao <lang--lang--lang@163.com>

Uh oh!

Conversation

langdamao commented Aug 28, 2019

Uh oh!

Apache-HBase commented Aug 28, 2019

Uh oh!

Apache-HBase commented Aug 29, 2019

Uh oh!

Apache-HBase commented Aug 29, 2019

Uh oh!

Apache-HBase commented Aug 30, 2019

Uh oh!

Apache-HBase commented Aug 31, 2019

Uh oh!

Apache-HBase commented Aug 31, 2019

Uh oh!

Apache-HBase commented Sep 1, 2019

Uh oh!

Apache-HBase commented Sep 1, 2019

Uh oh!

Apache-HBase commented Sep 1, 2019

Uh oh!

Apache-HBase commented Sep 2, 2019

Uh oh!

Apache-HBase commented Sep 2, 2019

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

langdamao commented Sep 17, 2019

Uh oh!

infraio commented Sep 24, 2019

Uh oh!

langdamao commented Sep 24, 2019

Uh oh!

Apache-HBase commented Oct 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants