Skip to content

HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera… - #5567

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28248
Dec 9, 2023
Merged

HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…#5567
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28248

Conversation

@Apache9

@Apache9Apache9 commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

…tion could lead to ROLLEDBACK state be persisent to procedure store

@Apache9
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
d81357a
…tion could lead to ROLLEDBACK state be persisent to procedure store
@Apache9Apache9 self-assigned this Dec 7, 2023
@Apache-HBase

Apache-HBase commented Dec 7, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 11smaster passed
+1 💚compile2m 38smaster passed
+1 💚checkstyle0m 38smaster passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 31smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile2m 34sthe patch passed
+1 💚javac2m 34sthe patch passed
+1 💚checkstyle0m 35sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 46sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless1m 3spatch has no errors when running spotless:check.
+1 💚spotbugs2m 11sthe patch passed
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
36m 1s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5567
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 933ace10f036 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6e421e9
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 7, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 7sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 11smaster passed
+1 💚compile0m 54smaster passed
+1 💚shadedjars5m 30sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile0m 46sthe patch passed
+1 💚javac0m 46sthe patch passed
+1 💚shadedjars5m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sthe patch passed
_ Other Tests _
+1 💚unit220m 17shbase-server in the patch passed.
245m 41s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5567
Optional Testsjavac javadoc unit shadedjars compile
unameLinux db51bcf3d6ab 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6e421e9
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/testReport/
Max. process+thread count4574 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 7, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 53smaster passed
+1 💚compile0m 51smaster passed
+1 💚shadedjars5m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile0m 37sthe patch passed
+1 💚javac0m 37sthe patch passed
+1 💚shadedjars5m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 22sthe patch passed
_ Other Tests _
-1 ❌unit258m 25shbase-server in the patch failed.
281m 12s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5567
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3e2b3d0541cc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6e421e9
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/testReport/
Max. process+thread count4694 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

GeorryHuang
GeorryHuang approved these changes Dec 8, 2023
View reviewed changes

@GeorryHuangGeorryHuang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache-HBase

Apache-HBase commented Dec 8, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 9smaster passed
+1 💚compile2m 37smaster passed
+1 💚checkstyle0m 36smaster passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 43smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 45sthe patch passed
+1 💚compile2m 35sthe patch passed
+1 💚javac2m 35sthe patch passed
+1 💚checkstyle0m 34sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 56sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs1m 37sthe patch passed
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
35m 17s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5567
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 8db735b55fa8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6e421e9
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count80 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 8, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 49smaster passed
+1 💚compile0m 45smaster passed
+1 💚shadedjars5m 26sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 47sthe patch passed
+1 💚compile0m 45sthe patch passed
+1 💚javac0m 45sthe patch passed
+1 💚shadedjars5m 27spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 23sthe patch passed
_ Other Tests _
+1 💚unit218m 7shbase-server in the patch passed.
241m 22s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5567
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 75e8ff4f0b72 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6e421e9
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/testReport/
Max. process+thread count4742 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 8, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 40smaster passed
+1 💚compile0m 35smaster passed
+1 💚shadedjars5m 0sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 21smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile0m 35sthe patch passed
+1 💚javac0m 35sthe patch passed
+1 💚shadedjars5m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 20sthe patch passed
_ Other Tests _
-1 ❌unit224m 40shbase-server in the patch failed.
245m 52s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5567
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 21c255cd19c8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 6e421e9
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/testReport/
Max. process+thread count4709 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5567/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 82a2ce1 into apache:masterDec 9, 2023
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248Race between RegionRemoteProcedureBase and rollback opera…
a253472
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248Race between RegionRemoteProcedureBase and rollback opera…
a46f736
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248Race between RegionRemoteProcedureBase and rollback opera…
276e083
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248Race between RegionRemoteProcedureBase and rollback opera…
0d1ffbd
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
Apache9 added a commit that referenced this pull request Dec 9, 2023
@Apache9
HBASE-28248Race between RegionRemoteProcedureBase and rollback opera…
218bde7
…tion could lead to ROLLEDBACK state be persisent to procedure store (#5567)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
kadirozde pushed a commit to kadirozde/hbase that referenced this pull request Jan 5, 2024
@Apache9@kadirozde
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
804e8fe
…tion could lead to ROLLEDBACK state be persisent to procedure store (apache#5567)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@Apache9@petersomogyi
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
37dcb30
…tion could lead to ROLLEDBACK state be persisent to procedure store (apache#5567)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
(cherry picked from commit 82a2ce1)
(cherry picked from commit a253472)
Change-Id: I3674501c0eb4a4fc9f1ae17283bf900474c3a3e3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mymeiyimymeiyimymeiyi approved these changes
@GeorryHuangGeorryHuangGeorryHuang approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@mymeiyi@GeorryHuang