Uh oh!
There was an error while loading. Please reload this page.
HBASE-22944 Space Quota: TableNotFoundException: hbase:quota is thrown when region server is restarted. - #559
Closed
shardul-cr7 wants to merge 4 commits into
Closed
HBASE-22944 Space Quota: TableNotFoundException: hbase:quota is thrown when region server is restarted.#559shardul-cr7 wants to merge 4 commits into
shardul-cr7 wants to merge 4 commits into
Conversation
Apache-HBase
commented
Aug 29, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 29, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 29, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 29, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 30, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 30, 2019
🎊 +1 overall
This message was automatically generated. |
shardul-cr7
commented
Aug 30, 2019
ContributorAuthor
Hi @jatsakthi, Can you review this? :) |
the-sakthi
left a comment
Member
There was a problem hiding this comment.
Skimmed through it. Looks good to me. Will come back to take a look again.
Apache-HBase
commented
Aug 31, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 31, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 1, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 2, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 2, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 2, 2019
💔 -1 overall
This message was automatically generated. |
| protected void chore() { | ||
| try { | ||
| // check whether Quota table is present or not. | ||
| if (!checkQuotaTableExists()) { |
Contributor
There was a problem hiding this comment.
This will result in a META read. This can be done only once in the life time of an RS right if we found Quota table exists? A Boolean state can help here.
Why do you think we should do a WARN log? It can be just INFO at max IMO.
ContributorAuthor
There was a problem hiding this comment.
Hi @anoopsjohn , Thanks for the review. Added a boolean state to avoid the Meta read again and added info level log.
Apache-HBase
commented
Sep 6, 2019
🎊 +1 overall
This message was automatically generated. |
| // check whether Quota table is present or not. | ||
| if (!quotaTablePresent && !checkQuotaTableExists()) { | ||
| LOG.info("Quota table not found, skipping quota manager cache refresh."); | ||
| quotaTablePresent = true; |
Contributor
There was a problem hiding this comment.
Is this right? Setting it to true? Should it be false? The table was 'not found'.
ContributorAuthor
There was a problem hiding this comment.
ohh yes..I should set it after the if condition...my bad :)
ContributorAuthor
There was a problem hiding this comment.
Thanks for the review. Made the changes. :)
shardul-cr7force-pushed
the
HBASE-22944
branch
from
September 15, 2019 08:35
c908fd3 to
e66e8b4CompareApache-HBase
commented
Sep 15, 2019
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 15, 2019
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Sep 16, 2019
saintstack
left a comment
Contributor
There was a problem hiding this comment.
Good by me. Another for your list @joshelser Thanks boss.
joshelser
approved these changes
Sep 18, 2019
joshelser
left a comment
Member
There was a problem hiding this comment.
LGTM. Nice little trick on the if-block.
Let me try to get this in.
asfgit pushed a commit
that referenced
this pull request
Sep 20, 2019
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closes#559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>
asfgit pushed a commit
that referenced
this pull request
Sep 20, 2019
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closes#559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>
asfgit pushed a commit
that referenced
this pull request
Sep 20, 2019
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closes#559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>
| return; | ||
| } | ||
| // since quotaTable is present so setting the flag as true. | ||
| quotaTablePresent = true; |
Contributor
There was a problem hiding this comment.
Better we move flag setting inside checkQuotaTableExists().
Sorry for the late review.
infraio pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closesapache#559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>
symat pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closesapache#559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> (cherry picked from commit f1682a1) Change-Id: Iedb0bfe9591c0957a151acc8d2b3bd31a91237d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During Master startup if quota feature is enabled and region server is running TableNotFoundException occurs in regionServer logs
SpaceQuotaRefresherChore does not checks whether hbase:quota table is present,before starting its operation which sometimes may result to TableNotFoundExceptions.
This is because master has not created the hbase:quota table and SpaceQuotaRefresherChore is running.
This is little tricky and will happen in below scenario: