Uh oh!
There was an error while loading. Please reload this page.
HBASE-26268: Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache - #5593
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Apache-HBase
commented
Dec 21, 2023
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 21, 2023
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Dec 21, 2023
🎊 +1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ((MasterCoprocessorHost) coprocessorHost).preUpdateConfiguration(conf); | ||
| } | ||
| } catch (IOException e) { | ||
| LOG.error("Error while calling coprocessor preUpdateConfiguration()", e); |
There was a problem hiding this comment.
Instead of catching there here, can we throw them up the call chain? In particular, this will show up in client log when the reload request comes in via RPC. Maybe the signal handler will have to log.
Apache-HBase
commented
Jan 4, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 4, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 4, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 5, 2024
🎊 +1 overall
This message was automatically generated. |
charlesconnell
commented
Jan 5, 2024
If there is interest in backporting this to 2.5, I can make that branch once this is approved. It's not a super straightforward backport. |
Apache-HBase
commented
Jan 5, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jan 5, 2024
🎊 +1 overall
This message was automatically generated. |
ndimiduk
commented
Jan 8, 2024
@charlesconnell This new permission enforcement makes for a backward incompatible change that is not acceptable for a patch release, so as of now, there's no need for a branch-2.5 backport. After discussing it with the release managers, I think we'll prefer to accelerate the EOL of the 2.5 release line. |
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
ndimiduk
commented
Jan 8, 2024
I've posted the backport to branch-3, #5609. However the backport to branch-2 has some conflicts. @charlesconnell would you mind working through those and putting up a new backport PR? Thanks. |
…arRegionBlockCache (#5593) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…arRegionBlockCache (#5593) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…arRegionBlockCache (apache#5593) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…arRegionBlockCache (#5593) Co-authored-by: Charles Connell <cconnell@hubspot.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache. Also, use these new hooks in AccessController to gate access to these operations. This closes a minor security hole.