Uh oh!
There was an error while loading. Please reload this page.
HBASE-28342 Decommissioned hosts should be rejected by the HMaster - #5667
Closed
aalhour wants to merge 16 commits into
Closed
HBASE-28342 Decommissioned hosts should be rejected by the HMaster#5667aalhour wants to merge 16 commits into
aalhour wants to merge 16 commits into
Conversation
aalhour
marked this pull request as draft
February 7, 2024 14:05
added 3 commits
February 7, 2024 15:20
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Apache-HBase
commented
Feb 12, 2024
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 12, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 13, 2024
🎊 +1 overall
This message was automatically generated. |
ndimiduk
requested changes
Feb 13, 2024
ndimiduk
left a comment
Member
There was a problem hiding this comment.
Starting here -- I haven't read through your tests yet.
Summary:
- nothing in zookeeper is permanent
- an operator should be able to remove a host from the draining list, however it's specified -- we need APIs for this.
- the "match host name only" boolean is strange. I think what you actually want here is a unix-style field mask, specifying which of the ServerName triple are omitted when considering a match.
- don't swallow exceptions
| * Region unloading is asynchronous. | ||
| * @param servers The list of servers to decommission. | ||
| * @param offload True to offload the regions from the decommissioned servers | ||
| * @param matchHostNameOnly True to prevent the hostname from ever joining again, regardless of |
Member
There was a problem hiding this comment.
This language is a bit exaggerated, right? The host can join again, just remove this entry. You can tone it back and say something like "True to reject this host regardless of its startcode or port."
| boolean offload) { | ||
| // By default, when we decommission a RegionServer we don't mark the hostname as permanently | ||
| // decommissioned and instead mark the server location (host + port + startCode) as such | ||
| boolean matchHostNameOnly = false; |
Member
There was a problem hiding this comment.
By calling down to the higher arity method you're duplicating the default decision that's already described in protobuf. Doing so is not a terrible thing, but it is redundant. I'd say, leave the default in one place if at all possible.
| public static DecommissionRegionServersRequest | ||
| buildDecommissionRegionServersRequest(List<ServerName> servers, boolean offload) { | ||
| return RequestConverter.buildDecommissionRegionServersRequest(servers, offload, false); |
Member
There was a problem hiding this comment.
Same comment here about duplicating the default state.
| message DecommissionRegionServersRequest { | ||
| repeated ServerName server_name = 1; | ||
| required bool offload = 2; | ||
| optional bool match_host_name_only = 3 [default = false]; |
Member
There was a problem hiding this comment.
Please add comments for maintainers in both proto files that this default value should match the other.
| ZKUtil.listChildrenAndWatchThem(watcher, watcher.getZNodePaths().drainingZNode); | ||
| add(servers); | ||
| if (servers != null) { |
Member
There was a problem hiding this comment.
nit -- it's safer to put the null-check in the method than to burden all callers with the responsibility.
| byte[] data = DrainedZNodeServerData.newBuilder().setMatchHostNameOnly(matchHostNameOnly) | ||
| .build().toByteArray(); | ||
| // Create a node with binary data | ||
| ZKUtil.createAndFailSilent(getZooKeeper(), node, data); |
Member
There was a problem hiding this comment.
This should not fail silently. If it cannot create the znode that marks the decommissioning , it should fail the RPC. Let the exception throw -- the existing catch clause appears to handle it appropriately.
| try { | ||
| byte[] rawData = ZKUtil.getData(getZooKeeper(), node); | ||
| // Check if the data is present for backwards compatibility, some nodes may not have it |
Member
There was a problem hiding this comment.
Most nodes won't have this data as the common use-case is to drain by hostname,port,startcode.
| try { | ||
| ZKUtil.deleteNodeFailSilent(getZooKeeper(), node); | ||
| if (shouldBePermanentlyDecommissioned) { |
Member
There was a problem hiding this comment.
There should be a variant of this method that allows the operator to remove a server by hostname only to be removed from the decommissioning list. Unless I'm missing something, once a server is added to the list with this flag enabled, it cannot be removed again.
| message DecommissionRegionServersRequest { | ||
| repeated ServerName server_name = 1; | ||
| required bool offload = 2; | ||
| optional bool match_host_name_only = 3 [default = false]; |
Member
There was a problem hiding this comment.
I don't think that we want to prescribe a default value in the protobuf. Instead, the service should interpret the absence of a value appropriately.
| if (!this.isServerOnline(sn)) { | ||
| LOG.warn("Server " + sn + " is not currently online. " | ||
| + "Removing from draining list anyway, as requested."); | ||
| LOG.warn( |
Member
There was a problem hiding this comment.
Please don't clean up all these logger usages in files that you don't otherwise touch. Lets fix them up in a dedicated PR.
ndimiduk
commented
Feb 13, 2024
Member
Please do reviewers a favor and name the PR following the project conventions -- "jira_id jira_title" |
Apache-HBase
commented
Feb 13, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 13, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 13, 2024
🎊 +1 overall
This message was automatically generated. |
aalhour
commented
Feb 14, 2024
ContributorAuthor
Closed this PR in favor of a smaller and simpler solution. I will open a different PR with a fresh branch in a little bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: HBASE-28342
This PR adds support to specifying whether the host should be rejected by the HMaster when it gets decommissioned via the Admin API. If a host is specified as such, the HMaster will ignore the default path of recommissioning it even if it hears back from a RegionServer location (host + port + startcode) in the future as long as the hostname is marked as decommissioned.
TODO: This PR also adds an API for removing a regionserver from the drained server pool which overrides the flag hostname in the draining znode.