Backport "HBASE-28349 Count atomic operations against read quotas" to branch-2 by rmdmattingly · Pull Request #5670 · apache/hbase

rmdmattingly · 2024-02-08T22:55:31Z

Backport #5668 to branch-2

Right now atomic operations are just treated as a single write from the quota perspective. Since an atomic operation also encompasses a read, it would make sense to increment readNum and readSize counts appropriately.

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

Apache-HBase · 2024-02-08T23:39:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 42s	branch-2 passed
+1 💚	compile	3m 20s	branch-2 passed
+1 💚	checkstyle	0m 44s	branch-2 passed
+1 💚	spotless	0m 56s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 4s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	3m 0s	the patch passed
+1 💚	javac	3m 0s	the patch passed
+1 💚	checkstyle	0m 37s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 47s	Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚	spotless	0m 49s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 53s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		33m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5670
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b8db041f9825 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `dd76f83`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-09T03:10:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 0s	branch-2 passed
+1 💚	compile	0m 48s	branch-2 passed
+1 💚	shadedjars	5m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 46s	the patch passed
+1 💚	compile	0m 48s	the patch passed
+1 💚	javac	0m 48s	the patch passed
+1 💚	shadedjars	5m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	221m 37s	hbase-server in the patch failed.
		245m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5670
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 735ea7ef1d05 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `dd76f83`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/1/testReport/
Max. process+thread count	4471 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-09T03:27:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 19s	branch-2 passed
+1 💚	compile	0m 50s	branch-2 passed
+1 💚	shadedjars	5m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	0m 45s	the patch passed
+1 💚	javac	0m 45s	the patch passed
+1 💚	shadedjars	5m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	236m 59s	hbase-server in the patch passed.
		262m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5670
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 707531939c76 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `dd76f83`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/1/testReport/
Max. process+thread count	4221 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-09T04:02:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 12s	branch-2 passed
+1 💚	compile	3m 3s	branch-2 passed
+1 💚	checkstyle	0m 37s	branch-2 passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 34s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	3m 9s	the patch passed
+1 💚	javac	3m 9s	the patch passed
+1 💚	checkstyle	0m 43s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 45s	Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚	spotless	0m 50s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 5s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		32m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5670
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 3be5ccd02a14 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `dd76f83`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-09T07:35:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 57s	branch-2 passed
+1 💚	compile	0m 49s	branch-2 passed
+1 💚	shadedjars	5m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	0m 49s	the patch passed
+1 💚	javac	0m 49s	the patch passed
+1 💚	shadedjars	5m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	221m 33s	hbase-server in the patch passed.
		245m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5670
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 66a275178e13 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `dd76f83`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/2/testReport/
Max. process+thread count	4375 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-09T07:36:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 0s	branch-2 passed
+1 💚	compile	0m 42s	branch-2 passed
+1 💚	shadedjars	5m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	0m 42s	the patch passed
+1 💚	javac	0m 42s	the patch passed
+1 💚	shadedjars	6m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	the patch passed
		_ Other Tests _
+1 💚	unit	221m 22s	hbase-server in the patch passed.
		246m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5670
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d26274bd69cd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `dd76f83`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/2/testReport/
Max. process+thread count	4258 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5670/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…t read quotas (apache#5670) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

HBASE-28349 Count atomic operations against read quotas (apache#5668)
d97d9b9
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

rmdmattingly force-pushed the HBASE-28349-branch-2 branch from fa83436 to ae0ce68Compare February 8, 2024 23:25

backport
2760645

rmdmattingly force-pushed the HBASE-28349-branch-2 branch from ae0ce68 to 2760645Compare February 8, 2024 23:50

bbeaudreault approved these changes Feb 9, 2024
View reviewed changes

bbeaudreault merged commit d5aefbc into apache:branch-2Feb 9, 2024

bbeaudreault deleted the HBASE-28349-branch-2 branch February 9, 2024 13:31

bbeaudreault pushed a commit that referenced this pull request Feb 9, 2024
HBASE-28349Count atomic operations against read quotas (#5670)
68cce0c
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Feb 9, 2024
HubSpot Backport: Addendum HBASE-28349 Count atomic operations agains…
fc3fb26
…t read quotas (apache#5670) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

Navigation Menu

Uh oh!

Backport "HBASE-28349 Count atomic operations against read quotas" to branch-2 - #5670

Backport "HBASE-28349 Count atomic operations against read quotas" to branch-2#5670
bbeaudreault merged 2 commits into
apache:branch-2from
HubSpot:HBASE-28349-branch-2

rmdmattingly commented Feb 8, 2024

Uh oh!

Apache-HBase commented Feb 8, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rmdmattingly commented Feb 8, 2024

Uh oh!

Apache-HBase commented Feb 8, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Apache-HBase commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants