Skip to content

HBASE-28353 Close HBase connection on implicit exit from HBase shell - #5673

Merged
meszibalu merged 1 commit into
apache:masterfrom
stoty:HBASE-28353
Feb 13, 2024
Merged

HBASE-28353 Close HBase connection on implicit exit from HBase shell#5673
meszibalu merged 1 commit into
apache:masterfrom
stoty:HBASE-28353

Conversation

@stoty

@stotystoty commented Feb 9, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 51smaster passed
+1 💚spotless0m 56sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 39sthe patch passed
-0 ⚠️rubocop0m 5sThe patch generated 3 new + 31 unchanged - 2 fixed = 34 total (was 33)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 50spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
11m 42s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5673
Optional Testsdupname asflicense javac spotless rubocop
unameLinux ecd4deb35f9d 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 98eb3e0
Default JavaEclipse Adoptium-11.0.17+8
rubocophttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count72 (vs. ulimit of 30000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/console
versionsgit=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 12smaster passed
+1 💚javadoc0m 12smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 44sthe patch passed
+1 💚javadoc0m 11sthe patch passed
_ Other Tests _
+1 💚unit7m 21shbase-shell in the patch passed.
15m 1s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5673
Optional Testsjavac javadoc unit
unameLinux 633dfba2f517 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 98eb3e0
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/testReport/
Max. process+thread count1983 (vs. ulimit of 30000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 22smaster passed
+1 💚javadoc0m 10smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 56sthe patch passed
+1 💚javadoc0m 8sthe patch passed
_ Other Tests _
+1 💚unit7m 42shbase-shell in the patch passed.
15m 38s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5673
Optional Testsjavac javadoc unit
unameLinux 336b4c4e0092 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 98eb3e0
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/testReport/
Max. process+thread count2010 (vs. ulimit of 30000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreaultbbeaudreault left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a ruby expert, but this makes sense based on my reading of at_exit

@meszibalu
meszibalu merged commit 9656006 into apache:masterFeb 13, 2024
asfgit pushed a commit that referenced this pull request Feb 13, 2024
…5673)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
asfgit pushed a commit that referenced this pull request Feb 13, 2024
…5673)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
asfgit pushed a commit that referenced this pull request Feb 13, 2024
…5673)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
asfgit pushed a commit that referenced this pull request Feb 13, 2024
…5673)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@stoty@Apache-HBase@bbeaudreault@meszibalu