Uh oh!
There was an error while loading. Please reload this page.
HBASE-22724 Add a emoji on the vote table for pre commit result on gi… - #568
Merged
Conversation
Apache-HBase
commented
Aug 31, 2019
💔 -1 overall
This message was automatically generated. |
busbey
commented
Aug 31, 2019
Contributor
Interesting. It can't get far enough to load the new personality. Do we no longer need |
Apache9
commented
Aug 31, 2019
ContributorAuthor
It should be skip-dirs and I tried to remove it when testing on the branch HBASE-22724 and nothing went wrong, so... |
Apache-HBase
commented
Aug 31, 2019
💔 -1 overall
This message was automatically generated. |
busbey
commented
Sep 1, 2019
Contributor
I think it'll only go wrong if there's a change to dev-support and a change to some Java file. Basically we'll do unit tests for the whole project instead of just the one that changed. |
Apache9
commented
Sep 1, 2019
ContributorAuthor
Here I just modified a file under the dev-support directory and the pre commit was fine. So I do not think this is a big deal? We do not use this in the past, it is copied from the Jenkins file in hadoop. So if no other concerns, let’s merge this to master and try it first? If it is fine, then cherry pick to other branches. |
Apache-HBase
commented
Sep 1, 2019
💔 -1 overall
This message was automatically generated. |
busbey
commented
Sep 1, 2019
Contributor
No, that doesn't test the issue. To get the conditions I'm talking about you need a file under dev-support and a Java file in a small module. e.g. hbase-endpoint. |
Apache-HBase
commented
Sep 1, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 1, 2019
💔 -1 overall
This message was automatically generated. |
Apache9
commented
Sep 2, 2019
ContributorAuthor
OK, let me try a new PR on HBASE-22724 branch. |
Apache-HBase
commented
Sep 2, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 2, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 2, 2019
💔 -1 overall
This message was automatically generated. |
Apache9
commented
Sep 2, 2019
ContributorAuthor
OK, seems you are right. https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/view/change-requests/job/PR-573/1/console Here we will run all the UTs although we only modified the hbase-common module. Let me add the skip-dirs option. |
Apache-HBase
commented
Sep 3, 2019
💔 -1 overall
This message was automatically generated. |
busbey
approved these changes
Sep 3, 2019
Closed
Apache9
commented
Sep 4, 2019
ContributorAuthor
The pre commit result in #573 is fine, the skip-dirs works as expected. Let me merge this. |
asfgit pushed a commit
that referenced
this pull request
Sep 4, 2019
…thub (#568) Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
Sep 4, 2019
…thub (#568) Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
Sep 4, 2019
…thub (#568) Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
Sep 4, 2019
…thub (#568) Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
Sep 4, 2019
…thub (#568) Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit
that referenced
this pull request
Sep 4, 2019
…thub (#568) Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Stack <stack@apache.org>
symat pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…thub (apache#568) Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Stack <stack@apache.org> (cherry picked from commit c3ad579) Change-Id: Ia8c5d75918f8c547b00155d9695494e4f8cfc67b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…thub