Uh oh!
There was an error while loading. Please reload this page.
HBASE-28370 Set updateTs on default UserQuotaState - #5686
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Feb 16, 2024
🎊 +1 overall
This message was automatically generated. |
ee066d6 to
b603cb3CompareUh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Feb 16, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 16, 2024
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 16, 2024
🎊 +1 overall
This message was automatically generated. |
rmdmattingly
commented
Feb 16, 2024
Test failures here look unrelated. |
Apache-HBase
commented
Feb 17, 2024
💔 -1 overall
This message was automatically generated. |
rmdmattingly
commented
Feb 17, 2024
Looks like my test is flappy, I can investigate early next week |
Apache-HBase
commented
Feb 17, 2024
💔 -1 overall
This message was automatically generated. |
rmdmattingly
commented
Feb 18, 2024
Oh, I just forgot the @ClassRule. Pushing a fix now |
Apache-HBase
commented
Feb 18, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 18, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Feb 18, 2024
💔 -1 overall
This message was automatically generated. |
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…#5686) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…frequently (apache#5686) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
…frequently (apache#5686) (#83) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
In #5666 we introduced default user quotas, but I accidentally called UserQuotaState's default constructor rather than passing in the current timestamp. The consequence is that we're constantly refreshing these default user quotas, and this can be a bottleneck for horizontal cluster scalability.
We have deployed this to a cluster with thousands of unique quota users and verified that the refresh workload was significantly reduced.
@bbeaudreault@hgromer@eab148@bozzkar