Skip to content

HBASE-28321 RpcConnectionRegistry is broken when security is enabled … - #5688

Merged
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-28321
Feb 25, 2024
Merged

HBASE-28321 RpcConnectionRegistry is broken when security is enabled …#5688
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-28321

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…and we use different principal for master and region server

@Apache9Apache9 self-assigned this Feb 17, 2024
@Apache9

Copy link
Copy Markdown
ContributorAuthor

Almost done, still need to add some tests to test more corner cases, and also enable the UTs for blocking rpc client.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 57smaster passed
+1 💚compile4m 11smaster passed
+1 💚checkstyle1m 10smaster passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 59smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 43sthe patch passed
+1 💚compile4m 10sthe patch passed
+1 💚cc4m 10sthe patch passed
+1 💚javac4m 10sthe patch passed
-0 ⚠️checkstyle0m 36shbase-server: The patch generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck4m 50sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚hbaseprotoc1m 42sthe patch passed
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs5m 32sthe patch passed
_ Other Tests _
+1 💚asflicense0m 39sThe patch does not generate ASF License warnings.
43m 23s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5688
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux fcf74ef4fe00 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d925754
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 8sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 56smaster passed
+1 💚compile1m 56smaster passed
+1 💚shadedjars5m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 58smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile1m 52sthe patch passed
+1 💚javac1m 52sthe patch passed
+1 💚shadedjars5m 29spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 57sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-protocol-shaded in the patch passed.
-1 ❌unit1m 12shbase-client in the patch failed.
-1 ❌unit245m 8shbase-server in the patch failed.
+1 💚unit2m 7shbase-examples in the patch passed.
279m 7s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1059416f5a90 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d925754
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/testReport/
Max. process+thread count5331 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 14sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 37smaster passed
+1 💚compile1m 47smaster passed
+1 💚shadedjars5m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 24sthe patch passed
+1 💚compile1m 50sthe patch passed
+1 💚javac1m 50sthe patch passed
+1 💚shadedjars5m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 4sthe patch passed
_ Other Tests _
+1 💚unit0m 32shbase-protocol-shaded in the patch passed.
-1 ❌unit1m 3shbase-client in the patch failed.
-1 ❌unit258m 19shbase-server in the patch failed.
+1 💚unit2m 19shbase-examples in the patch passed.
288m 53s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8316053fb133 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d925754
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/testReport/
Max. process+thread count5327 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 41smaster passed
+1 💚compile4m 9smaster passed
+1 💚checkstyle1m 9smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 57smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 41sthe patch passed
+1 💚compile4m 10sthe patch passed
+1 💚cc4m 10sthe patch passed
+1 💚javac4m 10sthe patch passed
-0 ⚠️checkstyle0m 17shbase-client: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck4m 48sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚hbaseprotoc1m 43sthe patch passed
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs5m 31sthe patch passed
_ Other Tests _
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
42m 46s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5688
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux d92f1e4fd27b 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d925754
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 0smaster passed
+1 💚compile1m 52smaster passed
+1 💚shadedjars5m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile1m 53sthe patch passed
+1 💚javac1m 53sthe patch passed
+1 💚shadedjars5m 29spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 58sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-protocol-shaded in the patch passed.
+1 💚unit1m 32shbase-client in the patch passed.
-1 ❌unit218m 25shbase-server in the patch failed.
+1 💚unit1m 54shbase-examples in the patch passed.
250m 26s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 59e19cf0ae40 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d925754
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/testReport/
Max. process+thread count5157 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 11sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 24smaster passed
+1 💚compile1m 49smaster passed
+1 💚shadedjars4m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 4smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 25sthe patch passed
+1 💚compile1m 50sthe patch passed
+1 💚javac1m 50sthe patch passed
+1 💚shadedjars5m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 5sthe patch passed
_ Other Tests _
+1 💚unit0m 31shbase-protocol-shaded in the patch passed.
+1 💚unit1m 19shbase-client in the patch passed.
-1 ❌unit231m 1shbase-server in the patch failed.
+1 💚unit2m 12shbase-examples in the patch passed.
261m 32s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6b336bcbf1cd 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d925754
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/testReport/
Max. process+thread count5799 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 45smaster passed
+1 💚compile4m 16smaster passed
+1 💚checkstyle1m 12smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs5m 1smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 44sthe patch passed
+1 💚compile4m 10sthe patch passed
+1 💚cc4m 10sthe patch passed
+1 💚javac4m 10sthe patch passed
-0 ⚠️checkstyle0m 17shbase-client: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck4m 49sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚hbaseprotoc1m 47sthe patch passed
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs5m 35sthe patch passed
_ Other Tests _
+1 💚asflicense0m 40sThe patch does not generate ASF License warnings.
43m 33s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5688
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux 474c64adcd3e 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7bc07a6
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 56smaster passed
+1 💚compile1m 54smaster passed
+1 💚shadedjars5m 41sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 43sthe patch passed
+1 💚compile1m 53sthe patch passed
+1 💚javac1m 53sthe patch passed
+1 💚shadedjars5m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-protocol-shaded in the patch passed.
+1 💚unit1m 34shbase-client in the patch passed.
-1 ❌unit226m 25shbase-server in the patch failed.
+1 💚unit2m 26shbase-examples in the patch passed.
259m 11s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ee2c36197ed3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7bc07a6
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/testReport/
Max. process+thread count5580 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 12sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 38smaster passed
+1 💚compile1m 50smaster passed
+1 💚shadedjars5m 7sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 30sthe patch passed
+1 💚compile1m 51sthe patch passed
+1 💚javac1m 51sthe patch passed
+1 💚shadedjars5m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 6sthe patch passed
_ Other Tests _
+1 💚unit0m 31shbase-protocol-shaded in the patch passed.
+1 💚unit1m 20shbase-client in the patch passed.
-1 ❌unit262m 54shbase-server in the patch failed.
+1 💚unit2m 33shbase-examples in the patch passed.
294m 35s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c11d16d8dd54 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7bc07a6
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/testReport/
Max. process+thread count4601 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…and we use different principal for master and region server
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 48smaster passed
+1 💚compile4m 10smaster passed
+1 💚checkstyle1m 12smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
+1 💚spotbugs4m 58smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 44sthe patch passed
+1 💚compile4m 14sthe patch passed
+1 💚cc4m 14sthe patch passed
+1 💚javac4m 14sthe patch passed
-0 ⚠️checkstyle0m 16shbase-client: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck4m 49sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚hbaseprotoc1m 45sthe patch passed
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs5m 35sthe patch passed
_ Other Tests _
+1 💚asflicense0m 40sThe patch does not generate ASF License warnings.
43m 23s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5688
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux 54d78ef2b6a1 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7be588e
Default JavaEclipse Adoptium-11.0.17+8
checkstylehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count87 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 3smaster passed
+1 💚compile1m 54smaster passed
+1 💚shadedjars5m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 2smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile1m 55sthe patch passed
+1 💚javac1m 55sthe patch passed
+1 💚shadedjars5m 37spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 59sthe patch passed
_ Other Tests _
+1 💚unit0m 34shbase-protocol-shaded in the patch passed.
+1 💚unit1m 34shbase-client in the patch passed.
+1 💚unit219m 36shbase-server in the patch passed.
+1 💚unit2m 7shbase-examples in the patch passed.
252m 35s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3e405dcc21e8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7be588e
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/testReport/
Max. process+thread count5269 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 23sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 27smaster passed
+1 💚compile1m 51smaster passed
+1 💚shadedjars5m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall2m 27sthe patch passed
+1 💚compile1m 50sthe patch passed
+1 💚javac1m 50sthe patch passed
+1 💚shadedjars5m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 6sthe patch passed
_ Other Tests _
+1 💚unit0m 32shbase-protocol-shaded in the patch passed.
+1 💚unit1m 20shbase-client in the patch passed.
-1 ❌unit233m 47shbase-server in the patch failed.
+1 💚unit2m 13shbase-examples in the patch passed.
265m 3s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 91dc4e6e2997 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7be588e
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/testReport/
Max. process+thread count5237 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/4/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 59smaster passed
+1 💚compile4m 18smaster passed
+1 💚checkstyle1m 13smaster passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
+1 💚spotbugs5m 7smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile4m 10sthe patch passed
+1 💚cc4m 10sthe patch passed
+1 💚javac4m 10sthe patch passed
+1 💚checkstyle1m 11sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck4m 53sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚hbaseprotoc1m 47sthe patch passed
+1 💚spotless0m 41spatch has no errors when running spotless:check.
+1 💚spotbugs5m 36sthe patch passed
_ Other Tests _
+1 💚asflicense0m 41sThe patch does not generate ASF License warnings.
44m 2s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5688
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
unameLinux a526f8e0aaca 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7be588e
Default JavaEclipse Adoptium-11.0.17+8
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 13smaster passed
+1 💚compile2m 4smaster passed
+1 💚shadedjars5m 52sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 3smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile1m 58sthe patch passed
+1 💚javac1m 58sthe patch passed
+1 💚shadedjars5m 48spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 2sthe patch passed
_ Other Tests _
+1 💚unit0m 35shbase-protocol-shaded in the patch passed.
+1 💚unit1m 35shbase-client in the patch passed.
+1 💚unit220m 28shbase-server in the patch passed.
+1 💚unit2m 10shbase-examples in the patch passed.
254m 17s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9a6a5d34907e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7be588e
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/testReport/
Max. process+thread count5789 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 14sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 26smaster passed
+1 💚compile1m 48smaster passed
+1 💚shadedjars5m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 31sthe patch passed
+1 💚compile1m 49sthe patch passed
+1 💚javac1m 49sthe patch passed
+1 💚shadedjars5m 6spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 7sthe patch passed
_ Other Tests _
+1 💚unit0m 31shbase-protocol-shaded in the patch passed.
+1 💚unit1m 20shbase-client in the patch passed.
+1 💚unit230m 36shbase-server in the patch passed.
+1 💚unit2m 17shbase-examples in the patch passed.
261m 47s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5688
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 77f7670f9b4b 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 7be588e
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/testReport/
Max. process+thread count5949 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-examples U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5688/5/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreaultbbeaudreault left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Apache9 Sorry for the delay here. Note that I am out of office next week, so won't be able to look back until the following week.

Overall this looks good. I had a few comments/questions. I don't have hbase kerberos in my environment, so I won't be able to test this for the 2.6.0 release. I will rely on someone else in the RC vote process. I can test it without kerberos though.

// preamble call, so we should fallback to randomly select a principal to use
// TODO: find a way to reconnect without failing all the pending calls, for now, when we
// reach here, shutdown should have already been scheduled
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this fallback to random happen? I had the same question when reading the blocking client impl.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent a discuss email to the dev list, there is no response so I just choose the easiest way, just do not implement the fallback logic. In our current architecture it really not easy to implement the logic here, as said in the comment, when we reach here, the connection should have already been closed because server will close the connection immediately when preamble header mismatches. And at client side, all the calls are associated with a connection, so closing a connection means failing these calls.

https://lists.apache.org/thread/81p7f5f5lrrqh1v51mvct43spx8l0rhc

// Call[id=32153218,methodName=Get]
return new ToStringBuilder(this, ToStringStyle.SHORT_PREFIX_STYLE).append("id", id)
.append("methodName", md.getName()).toString();
.append("methodName", md != null ? md.getName() : "").toString();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be weird to see Call[id=23123123,methodName=] in null case. Is there anything more useful we can put?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log has been like this for a long time so just want to keep it align, as this is not a problem which want to resolve here. Can open another issue for optimizing this message. For logging in this PR, I outout the response type so we could know the preamble call type.

// fail all pending calls
ch.pipeline().fireUserEventTriggered(BufferCallEvent.fail(e));
shutdown0();
rpcClient.failedServers.addToFailedServers(remoteId.getAddress(), e);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is new right? what's the reason. it's probably good, but just checking

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this line right after the failInit call when connecting fail, it is at line 334 in the old code. I moved it here since we will call failInit at other places, I think for all those cases we should add the server to failedServers.

@Apache9
Apache9 merged commit c4a02f7 into apache:masterFeb 25, 2024
Apache9 added a commit that referenced this pull request Feb 25, 2024
…and we use different principal for master and region server (#5688)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit c4a02f7)
Apache9 added a commit to Apache9/hbase that referenced this pull request Feb 25, 2024
…and we use different principal for master and region server (apache#5688)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit c4a02f7)
Apache9 added a commit that referenced this pull request Feb 28, 2024
…and we use different principal for master and region server (#5688) (#5707)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit c4a02f7)
Apache9 added a commit that referenced this pull request Feb 28, 2024
…and we use different principal for master and region server (#5688) (#5707)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit c4a02f7)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@bbeaudreault