Uh oh!
There was an error while loading. Please reload this page.
HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas - #570
Closed
shardul-cr7 wants to merge 4 commits into
Closed
HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas#570shardul-cr7 wants to merge 4 commits into
shardul-cr7 wants to merge 4 commits into
Conversation
Apache-HBase
commented
Sep 1, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 1, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 2, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 2, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 2, 2019
💔 -1 overall
This message was automatically generated. |
joshelser
requested changes
Sep 4, 2019
| List<RegionInfo> regions = this.conn.getAdmin().getRegions(table); | ||
| if (regions == null) { | ||
| return 0; | ||
| } else { |
Member
There was a problem hiding this comment.
Nit: the else branch is unnecessary. Just make this if (regions==null) {return 0;} RegionReplicaUtil... (but properly formatted).
ContributorAuthor
There was a problem hiding this comment.
Hi @joshelser , Thanks for the review. Did all the changes and pushed. :)
| p.addColumn(Bytes.toBytes(SpaceQuotaHelperForTests.F1), Bytes.toBytes("to"), | ||
| Bytes.toBytes("reject")); | ||
| // Adding a sleep for 5 sec, so all the chores run and to void flakiness of the test. | ||
| Thread.sleep(5000); |
Member
There was a problem hiding this comment.
👎 Make this an explicit check. What do you need to propagate so that this test can pass? The RegionServerQuotaManager needs to be aware of the quota that was set? You can look at that via HBaseTestingUtility and the HRegionServer object you can get from there.
Is that clear? Like your other PR, there should be examples of doing this already in the o.a.h.h.quotas package.
ContributorAuthor
There was a problem hiding this comment.
Not required here since verifyViolation() has NUM_RETRIES as 10 and also has some wait. So removing the Thread.Sleep here. Even without it, testcase will always pass.
| @Test | ||
| public void testSetQuotaWithRegionReplicaMultipleRegion() throws Exception { | ||
| setQuotaAndVerifyForRegionReplication(5, 3, SpaceViolationPolicy.NO_INSERTS); |
Member
There was a problem hiding this comment.
Is it intentional that this is 5 and the other lines are 6?
ContributorAuthor
There was a problem hiding this comment.
Not intentional. changed it to 6 only.
| @Test | ||
| public void testSetQuotaWithRegionReplicaSingleRegion() throws Exception { | ||
| setQuotaAndVerifyForRegionReplication(1, 2, SpaceViolationPolicy.NO_INSERTS); |
Member
There was a problem hiding this comment.
Turn this into a for-loop with SpaceViolationPolicy.values()?
joshelser
approved these changes
Sep 6, 2019
joshelser
left a comment
Member
There was a problem hiding this comment.
Thanks for the fixing this up. Will wait for QA to come back before committing, but otherwise looks fine.
Apache-HBase
commented
Sep 6, 2019
💔 -1 overall
This message was automatically generated. |
joshelser
commented
Sep 6, 2019
Member
Looks like the new test (and all of the old quota tests) passed. Will get this in. |
shardul-cr7
commented
Sep 7, 2019
ContributorAuthor
Thank you @joshelser :-) |
asfgit pushed a commit
that referenced
this pull request
Sep 9, 2019
…ons for a table Closes#570 Signed-off-by: Josh Elser <elserj@apache.org>
asfgit pushed a commit
that referenced
this pull request
Sep 9, 2019
…ons for a table Closes#570 Signed-off-by: Josh Elser <elserj@apache.org>
asfgit pushed a commit
that referenced
this pull request
Sep 9, 2019
…ons for a table Closes#570 Signed-off-by: Josh Elser <elserj@apache.org>
infraio pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…ons for a table Closesapache#570 Signed-off-by: Josh Elser <elserj@apache.org>
symat pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…ons for a table Closesapache#570 Signed-off-by: Josh Elser <elserj@apache.org> (cherry picked from commit 973ec21) Change-Id: I1a9dd12df50867672042e7cf4738ea94896f6085
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Space Quota: Space Quota Issue: If a table is created with region replica then quota calculation is not happening
Steps:
1: Create a table with 100 regions with region replica 3
2: Observe that 'hbase:quota' table doesn't have entry of usage for this table So In UI only policy Limit and Policy is shown but not Usage and State.
Reason:
It looks like File system utilization core is sending data of 100 reiogns but not the size of region replicas.
But in quota observer chore, it is considering total region(actual regions+ replica reasons)
So the ratio of reported regions is less then configured percentRegionsReportedThreshold.
So quota calculation is not happening