HBASE-28408 Rephrase confusing log message by DieterDP-ng · Pull Request #5718 · apache/hbase

DieterDP-ng · 2024-02-28T17:08:16Z

Assume a user has a series of backups: Full1, Inc2, Inc3, where a table has not changed between Full1 and Inc3, but has changed after Inc3.
When restoring that table to Inc3, a log warning was outputted mentioning there was no need for a restore. This message in fact means there is no need for the incremental restore portion of the restore process.

Assume a user has a series of backups: Full1, Inc2, Inc3, where a table has not changed between Full1 and Inc3, but has changed after Inc3. When restoring that table to Inc3, a log warning was outputted mentioning there was no need for a restore. This message in fact means there is no need for the incremental restore portion of the restore process.

Apache-HBase · 2024-02-28T17:42:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.6 Compile Tests _
+1 💚	mvninstall	3m 7s	branch-2.6 passed
+1 💚	compile	0m 24s	branch-2.6 passed
+1 💚	checkstyle	0m 9s	branch-2.6 passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 29s	branch-2.6 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
-0 ⚠️	checkstyle	0m 7s	hbase-backup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 36s	Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
-1 ❌	spotless	0m 38s	patch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 34s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		21m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5718
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 0e4a8b390276 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `e103736`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-backup.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-28T17:49:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.6 Compile Tests _
+1 💚	mvninstall	2m 55s	branch-2.6 passed
+1 💚	compile	0m 19s	branch-2.6 passed
+1 💚	shadedjars	5m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	branch-2.6 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 51s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	5m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 27s	hbase-backup in the patch passed.
		28m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5718
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d2963653820c 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `e103736`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/testReport/
Max. process+thread count	4085 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-28T17:50:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.6 Compile Tests _
+1 💚	mvninstall	3m 6s	branch-2.6 passed
+1 💚	compile	0m 18s	branch-2.6 passed
+1 💚	shadedjars	5m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	branch-2.6 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 21s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	5m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	10m 33s	hbase-backup in the patch passed.
		29m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5718
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 20438ab860df 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `e103736`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/testReport/
Max. process+thread count	3521 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-29T15:04:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.6 Compile Tests _
+1 💚	mvninstall	3m 5s	branch-2.6 passed
+1 💚	compile	0m 28s	branch-2.6 passed
+1 💚	checkstyle	0m 13s	branch-2.6 passed
+1 💚	spotless	0m 47s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 33s	branch-2.6 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	checkstyle	0m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 25s	Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚	spotless	0m 44s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 38s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		21m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5718
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f7881d8b2bef 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `c8eb184`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-29T15:09:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.6 Compile Tests _
+1 💚	mvninstall	2m 28s	branch-2.6 passed
+1 💚	compile	0m 17s	branch-2.6 passed
+1 💚	shadedjars	4m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	branch-2.6 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 23s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	4m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	9m 55s	hbase-backup in the patch passed.
		26m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5718
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a8abb8f4bbac 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `c8eb184`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/2/testReport/
Max. process+thread count	3463 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-29T15:13:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.6 Compile Tests _
+1 💚	mvninstall	3m 2s	branch-2.6 passed
+1 💚	compile	0m 17s	branch-2.6 passed
+1 💚	shadedjars	5m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	branch-2.6 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 46s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	5m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 50s	hbase-backup in the patch passed.
		28m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5718
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 38ca57ed0d77 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `c8eb184`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/2/testReport/
Max. process+thread count	3797 (vs. ulimit of 30000)
modules	C: hbase-backup U: hbase-backup
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5718/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-03-01T07:08:13Z

Will merge this later today.

NihalJain · 2024-03-01T12:08:21Z

Hi @DieterDP-ng thanks for the PR. I have merged this PR. But going forward, please raise PRs targeted at master first. We merge PRs in master and then backport to older branches. Let me try to forward port this change to newer branching. Will let you know if any help is needed.

Assume a user has a series of backups: Full1, Inc2, Inc3, where a table has not changed between Full1 and Inc3, but has changed after Inc3. When restoring that table to Inc3, a log warning was outputted mentioning there was no need for a restore. This message in fact means there is no need for the incremental restore portion of the restore process. Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit 102c1b6)

DieterDP-ng · 2024-03-01T15:24:46Z

Thanks @NihalJain, I'll do so in the future.

Fix spotless failure.
ade8c9f

NihalJain reviewed Feb 29, 2024
View reviewed changes

Comment threadhbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java

NihalJain approved these changes Feb 29, 2024
View reviewed changes

NihalJain merged commit 102c1b6 into apache:branch-2.6Mar 1, 2024

Navigation Menu

Uh oh!

HBASE-28408 Rephrase confusing log message - #5718

HBASE-28408 Rephrase confusing log message#5718
NihalJain merged 2 commits into
apache:branch-2.6from
DieterDP-ng:HBASE-28408_Confusing-log-for-restore

DieterDP-ng commented Feb 28, 2024

Uh oh!

Apache-HBase commented Feb 28, 2024

Uh oh!

Apache-HBase commented Feb 28, 2024

Uh oh!

Apache-HBase commented Feb 28, 2024

Uh oh!

Uh oh!

Apache-HBase commented Feb 29, 2024

Uh oh!

Apache-HBase commented Feb 29, 2024

Uh oh!

Apache-HBase commented Feb 29, 2024

Uh oh!

NihalJain commented Mar 1, 2024

Uh oh!

NihalJain commented Mar 1, 2024

Uh oh!

DieterDP-ng commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

DieterDP-ng commented Feb 28, 2024

Uh oh!

Apache-HBase commented Feb 28, 2024

Uh oh!

Apache-HBase commented Feb 28, 2024

Uh oh!

Apache-HBase commented Feb 28, 2024

Uh oh!

Uh oh!

Apache-HBase commented Feb 29, 2024

Uh oh!

Apache-HBase commented Feb 29, 2024

Uh oh!

Apache-HBase commented Feb 29, 2024

Uh oh!

NihalJain commented Mar 1, 2024

Uh oh!

NihalJain commented Mar 1, 2024

Uh oh!

DieterDP-ng commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants