HBASE-28444 Bump org.apache.zookeeper:zookeeper from 3.8.3 to 3.8.4 by Apache9 · Pull Request #5765 · apache/hbase

Apache9 · 2024-03-20T09:24:37Z

No description provided.

Apache9 · 2024-03-20T09:25:10Z

Use mockito to rewrite the code, to make sure that we enter the NoAuthException path and exists returns true.

Apache-HBase · 2024-03-20T10:24:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 6s	master passed
+1 💚	compile	5m 3s	master passed
+1 💚	checkstyle	1m 6s	master passed
-1 ❌	spotless	0m 43s	branch has 1 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	7m 20s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 52s	the patch passed
+1 💚	compile	4m 53s	the patch passed
+1 💚	javac	4m 53s	root generated 0 new + 927 unchanged - 1 fixed = 927 total (was 928)
+1 💚	checkstyle	1m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	5m 23s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		48m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5765/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5765
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
uname	Linux 281995b9548b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0763a74`
Default Java	Eclipse Adoptium-11.0.17+8
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5765/1/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count	175 (vs. ulimit of 30000)
modules	C: hbase-zookeeper . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5765/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault

LGTM, assuming the test suite succeeds

Apache-HBase · 2024-03-20T14:26:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 17s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 57s	master passed
+1 💚	compile	7m 1s	master passed
+1 💚	checkstyle	1m 33s	master passed
+1 💚	spotless	1m 2s	branch has no errors when running spotless:check.
+1 💚	spotbugs	10m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 31s	the patch passed
+1 💚	compile	6m 21s	the patch passed
+1 💚	javac	6m 21s	root generated 0 new + 927 unchanged - 1 fixed = 927 total (was 928)
+1 💚	checkstyle	1m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	6m 15s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 49s	patch has no errors when running spotless:check.
+1 💚	spotbugs	10m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		62m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5765/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5765
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
uname	Linux d787a4f1ccd7 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0763a74`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	175 (vs. ulimit of 30000)
modules	C: hbase-zookeeper . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5765/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell · 2024-03-20T16:06:59Z

You are unblocked if you'd like to merge this and cherry pick back to 2.6 @bbeaudreault

Apache-HBase · 2024-03-20T18:17:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 8s	master passed
+1 💚	compile	2m 15s	master passed
+1 💚	shadedjars	5m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 18s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 10s	the patch passed
+1 💚	compile	2m 3s	the patch passed
+1 💚	javac	2m 3s	the patch passed
+1 💚	shadedjars	5m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 14s	the patch passed
		_ Other Tests _
-1 ❌	unit	260m 16s	root in the patch failed.
		292m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5765/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5765
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cba4ab05803a 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0763a74`
Default Java	Eclipse Adoptium-17.0.10+7
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5765/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5765/2/testReport/
Max. process+thread count	5364 (vs. ulimit of 30000)
modules	C: hbase-zookeeper . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5765/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-03-21T03:28:59Z

Failed UTs are not related to zookeeper upgrading.

Let me merge.

Thanks for the quick reviewing! @apurtell @bbeaudreault

…5765) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit ade6ab2) Conflicts: hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKUtil.java

…5765) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit ade6ab2)

HBASE-28444 Bump org.apache.zookeeper:zookeeper from 3.8.3 to 3.8.4
0653973

Apache9 self-assigned this Mar 20, 2024

Apache9 requested review from apurtell and bbeaudreault March 20, 2024 09:25

bbeaudreault approved these changes Mar 20, 2024
View reviewed changes

apurtell approved these changes Mar 20, 2024
View reviewed changes

Apache9 merged commit ade6ab2 into apache:masterMar 21, 2024

Apache9 mentioned this pull request Mar 21, 2024
HBASE-28444 Bump org.apache.zookeeper:zookeeper from 3.8.3 to 3.8.4 #5763
Closed

Navigation Menu

Uh oh!

HBASE-28444 Bump org.apache.zookeeper:zookeeper from 3.8.3 to 3.8.4 - #5765

HBASE-28444 Bump org.apache.zookeeper:zookeeper from 3.8.3 to 3.8.4#5765
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28444

Apache9 commented Mar 20, 2024

Uh oh!

Apache9 commented Mar 20, 2024

Uh oh!

Apache-HBase commented Mar 20, 2024

Uh oh!

bbeaudreault left a comment

Uh oh!

Apache-HBase commented Mar 20, 2024

Uh oh!

apurtell commented Mar 20, 2024

Uh oh!

Apache-HBase commented Mar 20, 2024

Uh oh!

Apache9 commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Apache9 commented Mar 20, 2024

Uh oh!

Apache9 commented Mar 20, 2024

Uh oh!

Apache-HBase commented Mar 20, 2024

Uh oh!

bbeaudreault left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Mar 20, 2024

Uh oh!

apurtell commented Mar 20, 2024

Uh oh!

Apache-HBase commented Mar 20, 2024

Uh oh!

Apache9 commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants