Uh oh!
There was an error while loading. Please reload this page.
HBASE-22699 refactor isMetaClearingException - #578
Merged
Conversation
Apache-HBase
commented
Sep 5, 2019
💔 -1 overall
This message was automatically generated. |
saintstack
left a comment
Contributor
There was a problem hiding this comment.
Just one question. Otherwise, this LGTM.
| Throwable cur = (Throwable) exception; | ||
| while (cur != null) { | ||
| if (isSpecialException(cur)) { | ||
| if (isExceptionWeCare(cur)) { |
Contributor
There was a problem hiding this comment.
Ok. Good. isSpecialException is an awful name. isExceptionWeCare is too but you made it private and it is only used here so its ok.
| private static boolean isMetaCachePreservingException(Throwable t) { | ||
| return t instanceof RegionOpeningException || t instanceof RegionTooBusyException | ||
| || t instanceof RpcThrottlingException || t instanceof RetryImmediatelyException | ||
| || t instanceof RequestTooBigException; |
Contributor
There was a problem hiding this comment.
So, this list here is smaller than the list above in the old isSpecialException. I looked at one or two of the differences. It seems like superclasses are listed here and you drop the mention of subclasses. Is that the case? Just a little worried we're not catching something here that we used to.
ContributorAuthor
There was a problem hiding this comment.
Yes, just remove subclasses, you mean the detailed messages in the subclass?
| return isInstanceOfRegionServerOverloadedException(t); | ||
| } | ||
| private static boolean isInstanceOfRegionServerOverloadedException(Throwable t) { |
saintstack
approved these changes
Sep 16, 2019
asfgit pushed a commit
that referenced
this pull request
Sep 16, 2019
saintstack
commented
Sep 16, 2019
Contributor
Pulled back to branch-2.2 and branch-2.1 too as well as branch-2. Doesn't look like it makes sense on master. If not, all is good else, open new issue to forward parth. Thanks @johnhomsea . |
symat pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
(cherry picked from commit b1d4878) Change-Id: I0cee17d3d5bb80ddb880be07f0edab9ef7a8b890
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.