Skip to content

HBASE-22937 The RawBytesComparator in branch-1 have wrong comparison order - #582

Merged
openinx merged 1 commit into
apache:branch-1from
openinx:HBASE-22937
Sep 5, 2019
Merged

HBASE-22937 The RawBytesComparator in branch-1 have wrong comparison order#582
openinx merged 1 commit into
apache:branch-1from
openinx:HBASE-22937

Conversation

@openinx

Copy link
Copy Markdown
Member

No description provided.

@anoopsjohnanoopsjohn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Seems even in branch-1 we dont use this Comparator for sorting cells? Anyways good to correct

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 45sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
💚mvninstall8m 10sbranch-1 passed
💚compile0m 18sbranch-1 passed
💚checkstyle0m 31sbranch-1 passed
💔shadedjars0m 14sbranch has 10 errors when building our shaded downstream artifacts.
💚javadoc0m 25sbranch-1 passed
💙spotbugs0m 58sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs0m 56sbranch-1 passed
_ Patch Compile Tests _
💚mvninstall1m 47sthe patch passed
💚compile0m 18sthe patch passed
💚javac0m 18sthe patch passed
💚checkstyle0m 28sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💔shadedjars0m 11spatch has 10 errors when building our shaded downstream artifacts.
💚hadoopcheck4m 47sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚javadoc0m 18sthe patch passed
💚findbugs0m 46sthe patch passed
_ Other Tests _
💚unit2m 14shbase-common in the patch passed.
💚asflicense0m 16sThe patch does not generate ASF License warnings.
25m 34s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/artifact/out/Dockerfile
GITHUB PR#582
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux c86b15c83499 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-582/out/precommit/personality/provided.sh
git revisionbranch-1 / 157ffae
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/artifact/out/branch-shadedjars.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/artifact/out/patch-shadedjars.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/testReport/
Max. process+thread count196 (vs. ulimit of 10000)
modulesC: hbase-common U: hbase-common
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@openinx
openinx merged commit 4c2bf71 into apache:branch-1Sep 5, 2019
@openinx
openinx deleted the HBASE-22937 branch September 5, 2019 09:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@openinx@Apache-HBase@anoopsjohn