Skip to content

HBASE-22975 Add read and write QPS metrics at server level and table level - #586

Closed
ZhaoBQ wants to merge 3 commits into
apache:branch-1from
ZhaoBQ:HBASE-22975
Closed

HBASE-22975 Add read and write QPS metrics at server level and table level#586
ZhaoBQ wants to merge 3 commits into
apache:branch-1from
ZhaoBQ:HBASE-22975

Conversation

@ZhaoBQ

Copy link
Copy Markdown
Contributor

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 44sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
💙mvndep5m 53sMaven dependency ordering for branch
💚mvninstall3m 22sbranch-1 passed
💚compile1m 11sbranch-1 passed
💚checkstyle2m 8sbranch-1 passed
💔shadedjars0m 13sbranch has 10 errors when building our shaded downstream artifacts.
💚javadoc0m 59sbranch-1 passed
💙spotbugs2m 8sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs3m 9sbranch-1 passed
_ Patch Compile Tests _
💙mvndep0m 11sMaven dependency ordering for patch
💚mvninstall1m 54sthe patch passed
💚compile1m 9sthe patch passed
💚javac1m 9sthe patch passed
💔checkstyle0m 11shbase-hadoop-compat: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
💔checkstyle0m 13shbase-hadoop2-compat: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1)
💚whitespace0m 0sThe patch has no whitespace issues.
💔shadedjars0m 12spatch has 10 errors when building our shaded downstream artifacts.
💚hadoopcheck4m 47sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚javadoc0m 58sthe patch passed
💔findbugs0m 36shbase-hadoop2-compat generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
💚unit0m 23shbase-hadoop-compat in the patch passed.
💚unit0m 31shbase-hadoop2-compat in the patch passed.
💔unit116m 45shbase-server in the patch failed.
💔asflicense1m 3sThe patch generated 2 ASF License warnings.
155m 7s
ReasonTests
FindBugsmodule:hbase-hadoop2-compat
Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.hadoop.hbase.regionserver.MetricsTableQPSImpl.getOrCreateTableMeter(String) At MetricsTableQPSImpl.java:may not be atomic in org.apache.hadoop.hbase.regionserver.MetricsTableQPSImpl.getOrCreateTableMeter(String) At MetricsTableQPSImpl.java:[line 60]
Failed junit testshadoop.hbase.regionserver.TestCompactionWithCoprocessor
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/Dockerfile
GITHUB PR#586
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux e0a56bcbf623 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-586/out/precommit/personality/provided.sh
git revisionbranch-1 / 157ffae
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/branch-shadedjars.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/diff-checkstyle-hbase-hadoop-compat.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/diff-checkstyle-hbase-hadoop2-compat.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/patch-shadedjars.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/new-findbugs-hbase-hadoop2-compat.html
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/testReport/
asflicensehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count4586 (vs. ulimit of 10000)
modulesC: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/1/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 39sDocker mode activated.
_ Prechecks _
💚dupname0m 1sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
💙mvndep5m 55sMaven dependency ordering for branch
💚mvninstall3m 15sbranch-1 passed
💚compile1m 5sbranch-1 passed
💚checkstyle2m 2sbranch-1 passed
💔shadedjars0m 13sbranch has 10 errors when building our shaded downstream artifacts.
💚javadoc1m 0sbranch-1 passed
💙spotbugs2m 6sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs3m 0sbranch-1 passed
_ Patch Compile Tests _
💙mvndep0m 11sMaven dependency ordering for patch
💚mvninstall1m 47sthe patch passed
💚compile1m 6sthe patch passed
💚javac1m 6sthe patch passed
💔checkstyle0m 12shbase-hadoop2-compat: The patch generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1)
💚whitespace0m 0sThe patch has no whitespace issues.
💔shadedjars0m 11spatch has 10 errors when building our shaded downstream artifacts.
💚hadoopcheck4m 36sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚javadoc0m 56sthe patch passed
💔findbugs0m 36shbase-hadoop2-compat generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
💚unit0m 25shbase-hadoop-compat in the patch passed.
💚unit0m 30shbase-hadoop2-compat in the patch passed.
💚unit110m 24shbase-server in the patch passed.
💔asflicense1m 13sThe patch generated 2 ASF License warnings.
147m 33s
ReasonTests
FindBugsmodule:hbase-hadoop2-compat
Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.hadoop.hbase.regionserver.MetricsTableQPSImpl.getOrCreateTableMeter(String) At MetricsTableQPSImpl.java:may not be atomic in org.apache.hadoop.hbase.regionserver.MetricsTableQPSImpl.getOrCreateTableMeter(String) At MetricsTableQPSImpl.java:[line 60]
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/Dockerfile
GITHUB PR#586
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 4b4d25d74244 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-586/out/precommit/personality/provided.sh
git revisionbranch-1 / 352344c
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/branch-shadedjars.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/diff-checkstyle-hbase-hadoop2-compat.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/patch-shadedjars.txt
findbugshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/new-findbugs-hbase-hadoop2-compat.html
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/testReport/
asflicensehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/artifact/out/patch-asflicense-problems.txt
Max. process+thread count4318 (vs. ulimit of 10000)
modulesC: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/2/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 40sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
💙mvndep6m 42sMaven dependency ordering for branch
💚mvninstall3m 16sbranch-1 passed
💚compile1m 6sbranch-1 passed
💚checkstyle2m 0sbranch-1 passed
💔shadedjars0m 12sbranch has 10 errors when building our shaded downstream artifacts.
💚javadoc0m 59sbranch-1 passed
💙spotbugs2m 2sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs3m 0sbranch-1 passed
_ Patch Compile Tests _
💙mvndep0m 11sMaven dependency ordering for patch
💚mvninstall1m 47sthe patch passed
💚compile1m 7sthe patch passed
💚javac1m 7sthe patch passed
💚checkstyle1m 57sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💔shadedjars0m 12spatch has 10 errors when building our shaded downstream artifacts.
💚hadoopcheck4m 32sPatch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚javadoc0m 58sthe patch passed
💚findbugs3m 14sthe patch passed
_ Other Tests _
💚unit0m 24shbase-hadoop-compat in the patch passed.
💚unit0m 30shbase-hadoop2-compat in the patch passed.
💚unit109m 47shbase-server in the patch passed.
💔asflicense1m 13sThe patch generated 2 ASF License warnings.
147m 29s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/artifact/out/Dockerfile
GITHUB PR#586
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux d1d8c05d7ccc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-586/out/precommit/personality/provided.sh
git revisionbranch-1 / 352344c
Default Java1.8.0_222
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/artifact/out/branch-shadedjars.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/artifact/out/patch-shadedjars.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/testReport/
asflicensehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/artifact/out/patch-asflicense-problems.txt
Max. process+thread count4314 (vs. ulimit of 10000)
modulesC: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-586/3/console
versionsgit=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@ZhaoBQZhaoBQ closed this Sep 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ZhaoBQ@Apache-HBase