HBASE-28533 - On split procedure rollback revert parent region state … by droudnitsky · Pull Request #5863 · apache/hbase

droudnitsky · 2024-04-29T18:38:37Z

…back to OPEN

Apache-HBase · 2024-04-29T19:19:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 7s	master passed
+1 💚	compile	2m 43s	master passed
+1 💚	checkstyle	0m 37s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	2m 40s	the patch passed
+1 💚	javac	2m 40s	the patch passed
+1 💚	checkstyle	0m 33s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 8s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 35s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		29m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5863
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux a62334d65fdb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4230c42`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-29T23:14:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 43s	master passed
+1 💚	compile	0m 45s	master passed
+1 💚	shadedjars	5m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	5m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	240m 31s	hbase-server in the patch passed.
		264m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5863
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dee380dc1553 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4230c42`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/testReport/
Max. process+thread count	5025 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-29T23:25:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 53s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	7m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 4s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	6m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	244m 19s	hbase-server in the patch passed.
		274m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5863
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b5f697369f8f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4230c42`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/testReport/
Max. process+thread count	4650 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-29T23:44:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 41s	master passed
+1 💚	compile	1m 0s	master passed
+1 💚	shadedjars	5m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 18s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
+1 💚	shadedjars	6m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
-1 ❌	unit	266m 27s	hbase-server in the patch failed.
		293m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5863
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ff17d776d05a 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4230c42`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/testReport/
Max. process+thread count	5265 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5863/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-04-30T13:07:35Z

OK, we have a different pattern here comparing to MergeTableRegionsProcedure, and the SplitTableRegionProcedure's solution is clearer and simpler...

Let me think whether this is correct...

Apache9 · 2024-04-30T13:40:21Z

OK, for split region procedure, we only need to issue a single TRSP to close the region, so either we succesfully issue the TRSP and move to the next state, or we just fail without actually close the parent region, so the solution here is correct.

Let me merge.

Thanks @droudnitsky !

…ck to OPEN (#5863) Co-authored-by: Daniel Roudnitsky <droudnitsky1@bloomberg.net> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 8a2f3ef)

droudnitsky · 2024-04-30T20:06:31Z

Thank you @Apache9 for reviewing and merging

…ck to OPEN (apache#5863) Co-authored-by: Daniel Roudnitsky <droudnitsky1@bloomberg.net> Signed-off-by: Duo Zhang <zhangduo@apache.org>

…arent region state back to OPEN (apache#5863) (apache#138) (cherry picked from commit 8a2f3ef) Signed-off-by: Duo Zhang <zhangduo@apache.org> Co-authored-by: droudnitsky <168442446+droudnitsky@users.noreply.github.com> Co-authored-by: Daniel Roudnitsky <droudnitsky1@bloomberg.net>

HBASE-28533 - On split procedure rollback revert parent region state …
4f9e0d7
…back to OPEN

Apache9 approved these changes Apr 30, 2024
View reviewed changes

Apache9 merged commit 8a2f3ef into apache:masterApr 30, 2024

droudnitsky deleted the HBASE-28533 branch June 20, 2024 12:50

Navigation Menu

Uh oh!

HBASE-28533 - On split procedure rollback revert parent region state … - #5863

HBASE-28533 - On split procedure rollback revert parent region state …#5863
Apache9 merged 1 commit into
apache:masterfrom
droudnitsky:HBASE-28533

droudnitsky commented Apr 29, 2024

Uh oh!

Apache-HBase commented Apr 29, 2024

Uh oh!

Apache-HBase commented Apr 29, 2024

Uh oh!

Apache-HBase commented Apr 29, 2024

Uh oh!

Apache-HBase commented Apr 29, 2024

Uh oh!

Apache9 commented Apr 30, 2024

Uh oh!

Apache9 commented Apr 30, 2024

Uh oh!

droudnitsky commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

droudnitsky commented Apr 29, 2024

Uh oh!

Apache-HBase commented Apr 29, 2024

Uh oh!

Apache-HBase commented Apr 29, 2024

Uh oh!

Apache-HBase commented Apr 29, 2024

Uh oh!

Apache-HBase commented Apr 29, 2024

Uh oh!

Apache9 commented Apr 30, 2024

Uh oh!

Apache9 commented Apr 30, 2024

Uh oh!

droudnitsky commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants