Skip to content

HBASE-22982: region server suspend/resume and graceful rolling restart actions - #592

Merged
meszibalu merged 5 commits into
apache:masterfrom
BukrosSzabolcs:HBASE-22982
Sep 26, 2019
Merged

HBASE-22982: region server suspend/resume and graceful rolling restart actions#592
meszibalu merged 5 commits into
apache:masterfrom
BukrosSzabolcs:HBASE-22982

Conversation

@BukrosSzabolcs

Copy link
Copy Markdown
Contributor

Add chaos monkey action for suspend/resume region servers
Add chaos monkey action for graceful rolling restart
Add these to relevant chaos monkeys

Add chaos monkey action for suspend/resume region servers
Add chaos monkey action for graceful rolling restart
Add these to relevant chaos monkeys
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 41sDocker mode activated.
_ Prechecks _
💚dupname0m 1sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙mvndep0m 37sMaven dependency ordering for branch
💚mvninstall5m 39smaster passed
💚compile1m 26smaster passed
💚checkstyle1m 38smaster passed
💚shadedjars4m 33sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 50smaster passed
💙spotbugs4m 15sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 11smaster passed
_ Patch Compile Tests _
💙mvndep0m 15sMaven dependency ordering for patch
💚mvninstall5m 27sthe patch passed
💚compile1m 25sthe patch passed
💚javac1m 25sthe patch passed
💔checkstyle1m 25shbase-server: The patch generated 4 new + 26 unchanged - 0 fixed = 30 total (was 26)
💔checkstyle0m 19shbase-it: The patch generated 43 new + 74 unchanged - 1 fixed = 117 total (was 75)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 34spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck16m 2sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 49sthe patch passed
💚findbugs4m 3sthe patch passed
_ Other Tests _
💚unit167m 22shbase-server in the patch passed.
💚unit1m 9shbase-it in the patch passed.
💚asflicense1m 5sThe patch does not generate ASF License warnings.
230m 5s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/artifact/out/Dockerfile
GITHUB PR#592
JIRA IssueHBASE-22982
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 5421f3daabfb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revisionmaster / 51b6ce3
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/artifact/out/diff-checkstyle-hbase-server.txt
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/artifact/out/diff-checkstyle-hbase-it.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/testReport/
Max. process+thread count4455 (vs. ulimit of 10000)
modulesC: hbase-server hbase-it U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

checkstyle fixes
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 44sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 1sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙mvndep0m 37sMaven dependency ordering for branch
💚mvninstall6m 14smaster passed
💚compile1m 32smaster passed
💚checkstyle1m 39smaster passed
💚shadedjars4m 45sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 51smaster passed
💙spotbugs4m 7sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 4smaster passed
_ Patch Compile Tests _
💙mvndep0m 16sMaven dependency ordering for patch
💚mvninstall4m 50sthe patch passed
💚compile1m 23sthe patch passed
💚javac1m 23sthe patch passed
💚checkstyle1m 17sThe patch passed checkstyle in hbase-server
💚checkstyle0m 17shbase-it: The patch generated 0 new + 11 unchanged - 64 fixed = 11 total (was 75)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 41spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck16m 20sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 49sthe patch passed
💚findbugs4m 1sthe patch passed
_ Other Tests _
💔unit165m 6shbase-server in the patch failed.
💚unit1m 6shbase-it in the patch passed.
💚asflicense0m 58sThe patch does not generate ASF License warnings.
228m 7s
ReasonTests
Failed junit testshadoop.hbase.replication.regionserver.TestReplicator
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/2/artifact/out/Dockerfile
GITHUB PR#592
JIRA IssueHBASE-22982
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 8554dd261a27 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revisionmaster / 7648855
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/2/artifact/out/patch-unit-hbase-server.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/2/testReport/
Max. process+thread count4224 (vs. ulimit of 10000)
modulesC: hbase-server hbase-it U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@BukrosSzabolcs

Copy link
Copy Markdown
ContributorAuthor

The failing test (org.apache.hadoop.hbase.replication.regionserver.TestReplicator) seems to be flaky. I have run the test a few times locally on the master branch and it seems to fail once in every 6-7 runs for me even without my changes.

@BukrosSzabolcsBukrosSzabolcs changed the title HBASE-22982HBASE-22982: region server suspend/resume and graceful rolling restart actionsSep 9, 2019
Comment threadhbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java Outdated
Comment threadhbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java Outdated
use parametrized logging in affected classes
other small fixes
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
💙reexec0m 39sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙mvndep0m 34sMaven dependency ordering for branch
💚mvninstall5m 18smaster passed
💚compile1m 28smaster passed
💚checkstyle1m 38smaster passed
💚shadedjars4m 36sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 49smaster passed
💙spotbugs4m 17sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 16smaster passed
_ Patch Compile Tests _
💙mvndep0m 15sMaven dependency ordering for patch
💚mvninstall5m 8sthe patch passed
💚compile1m 25sthe patch passed
💚javac1m 25sthe patch passed
💚checkstyle1m 16sThe patch passed checkstyle in hbase-server
💚checkstyle0m 15shbase-it: The patch generated 0 new + 11 unchanged - 64 fixed = 11 total (was 75)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 35spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck16m 32sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 53sthe patch passed
💚findbugs4m 21sthe patch passed
_ Other Tests _
💚unit162m 40shbase-server in the patch passed.
💚unit1m 10shbase-it in the patch passed.
💚asflicense1m 6sThe patch does not generate ASF License warnings.
226m 11s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/3/artifact/out/Dockerfile
GITHUB PR#592
JIRA IssueHBASE-22982
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 6a18c5fb65b7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revisionmaster / ab076b0
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/3/testReport/
Max. process+thread count4348 (vs. ulimit of 10000)
modulesC: hbase-server hbase-it U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyipetersomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I left a couple of comments.

Comment threadhbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java Outdated
Comment threadhbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java Outdated
reverse formatting for otherwiseuntouched code
additional logging added
typos fixed
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 37sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙mvndep0m 38sMaven dependency ordering for branch
💚mvninstall5m 11smaster passed
💚compile1m 30smaster passed
💚checkstyle1m 39smaster passed
💚shadedjars4m 37sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 51smaster passed
💙spotbugs4m 14sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 11smaster passed
_ Patch Compile Tests _
💙mvndep0m 16sMaven dependency ordering for patch
💚mvninstall5m 1sthe patch passed
💚compile1m 28sthe patch passed
💚javac1m 28sthe patch passed
💔checkstyle0m 19shbase-it: The patch generated 1 new + 74 unchanged - 1 fixed = 75 total (was 75)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 35spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 52sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 52sthe patch passed
💚findbugs4m 10sthe patch passed
_ Other Tests _
💚unit161m 3shbase-server in the patch passed.
💚unit1m 9shbase-it in the patch passed.
💚asflicense1m 5sThe patch does not generate ASF License warnings.
223m 0s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/4/artifact/out/Dockerfile
GITHUB PR#592
JIRA IssueHBASE-22982
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 2a978432d40e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revisionmaster / 52f5a85
Default Java1.8.0_181
checkstylehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/4/artifact/out/diff-checkstyle-hbase-it.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/4/testReport/
Max. process+thread count4449 (vs. ulimit of 10000)
modulesC: hbase-server hbase-it U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

checkstlye fix
@meszibalu
meszibalu merged commit f0dddd1 into apache:masterSep 26, 2019
asfgit pushed a commit that referenced this pull request Sep 26, 2019
…t actions (#592)
* Add chaos monkey action for suspend/resume region servers
* Add chaos monkey action for graceful rolling restart
* Add these to relevant chaos monkeys
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
💙reexec1m 12sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚hbaseanti0m 0sPatch does not have any anti-patterns.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 13 new or modified test files.
_ master Compile Tests _
💙mvndep0m 36sMaven dependency ordering for branch
💚mvninstall5m 57smaster passed
💚compile1m 29smaster passed
💚checkstyle1m 45smaster passed
💚shadedjars5m 21sbranch has no errors when building our shaded downstream artifacts.
💚javadoc0m 48smaster passed
💙spotbugs4m 39sUsed deprecated FindBugs config; considering switching to SpotBugs.
💚findbugs4m 36smaster passed
_ Patch Compile Tests _
💙mvndep0m 15sMaven dependency ordering for patch
💚mvninstall5m 49sthe patch passed
💚compile1m 28sthe patch passed
💚javac1m 28sthe patch passed
💚checkstyle1m 29sThe patch passed checkstyle in hbase-server
💚checkstyle0m 17shbase-it: The patch generated 0 new + 74 unchanged - 1 fixed = 74 total (was 75)
💚whitespace0m 0sThe patch has no whitespace issues.
💚shadedjars4m 58spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck17m 25sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc0m 48sthe patch passed
💚findbugs4m 39sthe patch passed
_ Other Tests _
💚unit229m 9shbase-server in the patch passed.
💚unit1m 7shbase-it in the patch passed.
💚asflicense0m 49sThe patch does not generate ASF License warnings.
296m 58s
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/5/artifact/out/Dockerfile
GITHUB PR#592
JIRA IssueHBASE-22982
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
unameLinux 314f014e1735 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-592/out/precommit/personality/provided.sh
git revisionmaster / ea24ea7
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/5/testReport/
Max. process+thread count4901 (vs. ulimit of 10000)
modulesC: hbase-server hbase-it U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-592/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

BukrosSzabolcs added a commit to BukrosSzabolcs/hbase that referenced this pull request Nov 13, 2019
…t actions (apache#592)
* Add chaos monkey action for suspend/resume region servers
* Add chaos monkey action for graceful rolling restart
* Add these to relevant chaos monkeys
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
BukrosSzabolcs added a commit to BukrosSzabolcs/hbase that referenced this pull request Nov 13, 2019
…t actions (apache#592)
* Add chaos monkey action for suspend/resume region servers
* Add chaos monkey action for graceful rolling restart
* Add these to relevant chaos monkeys
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
bharathv pushed a commit to bharathv/hbase that referenced this pull request Jun 22, 2020
* Add chaos monkey action for suspend/resume region servers
* Add these to relevant chaos monkeys
branch-1-backport-note: Graceful regionserver restart action wasn't
backported due to a dependency of "RegionMover" script. Can be done
later if needed.
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
bharathv pushed a commit to bharathv/hbase that referenced this pull request Jun 22, 2020
* Add chaos monkey action for suspend/resume region servers
* Add these to relevant chaos monkeys
branch-1-backport-note: Graceful regionserver restart action wasn't
backported due to a dependency of "RegionMover" script. Can be done
later if needed.
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
bharathv pushed a commit to bharathv/hbase that referenced this pull request Jun 22, 2020
* Add chaos monkey action for suspend/resume region servers
* Add these to relevant chaos monkeys
branch-1-backport-note: Graceful regionserver restart action wasn't
backported due to a dependency of "RegionMover" script. Can be done
later if needed.
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
bharathv pushed a commit that referenced this pull request Jun 22, 2020
* Add chaos monkey action for suspend/resume region servers
* Add these to relevant chaos monkeys
branch-1-backport-note: Graceful regionserver restart action wasn't
backported due to a dependency of "RegionMover" script. Can be done
later if needed.
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
…t actions (apache#592)
* Add chaos monkey action for suspend/resume region servers
* Add chaos monkey action for graceful rolling restart
* Add these to relevant chaos monkeys
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@BukrosSzabolcs@Apache-HBase@petersomogyi@meszibalu