Skip to content

HBASE-22927 Upgrade Mockito version for jdk11 - #593

Merged
Apache9 merged 7 commits into
apache:masterfrom
rabi-kumar:HBASE-22927
Sep 18, 2019
Merged

HBASE-22927 Upgrade Mockito version for jdk11#593
Apache9 merged 7 commits into
apache:masterfrom
rabi-kumar:HBASE-22927

Conversation

@rabi-kumar

@rabi-kumarrabi-kumar commented Sep 6, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Original PR: #584 Added module-info class in ignore class as suggested in #584 (comment). Creating a new one and hopefully this will pass the test.

@rabi-kumar
HBASE-22927 Upgrade Mockito version for jdk11 and add module-info in …
aeef376
…ignore class of pom. Error while rebasing so creating new one.
@Apache-HBase

Apache-HBase commented Sep 6, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 35sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💚mvninstall5m 53smaster passed
💚compile3m 12smaster passed
💚shadedjars5m 0sbranch has no errors when building our shaded downstream artifacts.
💚javadoc2m 49smaster passed
_ Patch Compile Tests _
💚mvninstall5m 31sthe patch passed
💚compile3m 14sthe patch passed
💚javac3m 14sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚xml0m 2sThe patch has no ill-formed XML file.
💚shadedjars5m 15spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck17m 39sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc2m 50sthe patch passed
_ Other Tests _
💔unit175m 16sroot in the patch failed.
💚asflicense0m 31sThe patch does not generate ASF License warnings.
234m 32s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/1/artifact/out/Dockerfile
GITHUB PR#593
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 2f25d66a39f8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-593/out/precommit/personality/provided.sh
git revisionmaster / 51b6ce3
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/1/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/1/testReport/
Max. process+thread count4422 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

OK, seems good. Only one question, why not just upgrade to 2.28.2?

@rabi-kumar

rabi-kumar commented Sep 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Okay @Apache9 I will update the version to 2.28.2 and run the test.

@Apache-HBase

Apache-HBase commented Sep 9, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 44sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💚mvninstall7m 1smaster passed
💚compile4m 3smaster passed
💚shadedjars5m 50sbranch has no errors when building our shaded downstream artifacts.
💚javadoc3m 27smaster passed
_ Patch Compile Tests _
💚mvninstall6m 33sthe patch passed
💚compile3m 50sthe patch passed
💚javac3m 50sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚xml0m 2sThe patch has no ill-formed XML file.
💔shadedjars5m 39spatch has 10 errors when building our shaded downstream artifacts.
💚hadoopcheck19m 49sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc3m 31sthe patch passed
_ Other Tests _
💔unit219m 26sroot in the patch failed.
💚asflicense0m 43sThe patch does not generate ASF License warnings.
288m 38s
ReasonTests
Failed junit testshadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/2/artifact/out/Dockerfile
GITHUB PR#593
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux a975b62a711d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-593/out/precommit/personality/provided.sh
git revisionmaster / ac8fe16
Default Java1.8.0_181
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/2/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/2/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/2/testReport/
Max. process+thread count5659 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Oh, seems 2.28.2 is not good?

@Apache-HBase

Apache-HBase commented Sep 11, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 49sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💚mvninstall7m 4smaster passed
💚compile3m 51smaster passed
💚shadedjars5m 41sbranch has no errors when building our shaded downstream artifacts.
💚javadoc3m 26smaster passed
_ Patch Compile Tests _
💚mvninstall6m 12sthe patch passed
💚compile4m 0sthe patch passed
💚javac4m 0sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚xml0m 1sThe patch has no ill-formed XML file.
💔shadedjars6m 2spatch has 10 errors when building our shaded downstream artifacts.
💚hadoopcheck20m 11sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc3m 31sthe patch passed
_ Other Tests _
💔unit181m 59sroot in the patch failed.
💚asflicense0m 32sThe patch does not generate ASF License warnings.
251m 4s
ReasonTests
Failed junit testshadoop.hbase.replication.TestReplicationDroppedTables
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/artifact/out/Dockerfile
GITHUB PR#593
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux b67760cb5248 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-593/out/precommit/personality/provided.sh
git revisionmaster / b20d9b9
Default Java1.8.0_181
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/testReport/
Max. process+thread count4713 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/3/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@busbey

busbey commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

We still need the ignore class when using Mockito 2.28.2

@rabi-kumar

rabi-kumar commented Sep 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Added the module-info in ignore class again.

@Apache-HBase

Apache-HBase commented Sep 12, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 10sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💚mvninstall6m 55smaster passed
💚compile3m 16smaster passed
💚shadedjars4m 56sbranch has no errors when building our shaded downstream artifacts.
💚javadoc2m 52smaster passed
_ Patch Compile Tests _
💚mvninstall5m 32sthe patch passed
💚compile3m 15sthe patch passed
💚javac3m 15sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚xml0m 3sThe patch has no ill-formed XML file.
💔shadedjars4m 57spatch has 10 errors when building our shaded downstream artifacts.
💚hadoopcheck17m 9sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc2m 49sthe patch passed
_ Other Tests _
💔unit255m 45sroot in the patch failed.
💚asflicense0m 32sThe patch does not generate ASF License warnings.
315m 53s
ReasonTests
Failed junit testshadoop.hbase.master.TestMasterShutdown
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/4/artifact/out/Dockerfile
GITHUB PR#593
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux a03cc5b53732 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-593/out/precommit/personality/provided.sh
git revisionmaster / c0e5c15
Default Java1.8.0_181
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/4/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/4/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/4/testReport/
Max. process+thread count4652 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/4/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@rabi-kumar

rabi-kumar commented Sep 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Still test is failing with same error as previous one even though module-info.class was added in ignoreClass.

@busbey

busbey commented Sep 12, 2019

Copy link
Copy Markdown
Contributor

We ended up doing the same thing over in the hbase-operator-tools repo, and getting it to work required adding extra-enforcer-rules as a dependency on the enforcer plugin.

ex:

https://github.com/apache/hbase-operator-tools/pull/25/files#diff-600376dffeb79835ede4a0b285078036R419

@rabi-kumar

rabi-kumar commented Sep 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Made the changes @busbey . Hopefully this will pass the test.

@Apache-HBase

Apache-HBase commented Sep 12, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 8sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💚mvninstall5m 53smaster passed
💚compile3m 13smaster passed
💚shadedjars4m 55sbranch has no errors when building our shaded downstream artifacts.
💚javadoc2m 50smaster passed
_ Patch Compile Tests _
💚mvninstall5m 25sthe patch passed
💚compile3m 18sthe patch passed
💚javac3m 18sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚xml0m 1sThe patch has no ill-formed XML file.
💔shadedjars5m 7spatch has 10 errors when building our shaded downstream artifacts.
💚hadoopcheck17m 27sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc3m 25sthe patch passed
_ Other Tests _
💔unit277m 46sroot in the patch failed.
💚asflicense0m 31sThe patch does not generate ASF License warnings.
337m 57s
SubsystemReport/Notes
DockerClient=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/5/artifact/out/Dockerfile
GITHUB PR#593
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 8174f2aa71a3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-593/out/precommit/personality/provided.sh
git revisionmaster / c0e5c15
Default Java1.8.0_181
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/5/artifact/out/patch-shadedjars.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/5/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/5/testReport/
Max. process+thread count4594 (vs. ulimit of 10000)
modulesC: . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/5/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 13, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 38sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💙mvndep0m 47sMaven dependency ordering for branch
💚mvninstall5m 10smaster passed
💚compile3m 1smaster passed
💚shadedjars4m 42sbranch has no errors when building our shaded downstream artifacts.
💚javadoc3m 0smaster passed
_ Patch Compile Tests _
💙mvndep0m 22sMaven dependency ordering for patch
💔mvninstall4m 52sroot in the patch failed.
💔compile2m 53sroot in the patch failed.
💔javac2m 53sroot in the patch failed.
💚whitespace0m 0sThe patch has no whitespace issues.
💚xml0m 3sThe patch has no ill-formed XML file.
💔shadedjars4m 31spatch has 10 errors when building our shaded downstream artifacts.
💔hadoopcheck4m 51sThe patch causes 10 errors with Hadoop v2.8.5.
💔hadoopcheck9m 56sThe patch causes 10 errors with Hadoop v2.9.2.
💔hadoopcheck15m 10sThe patch causes 10 errors with Hadoop v3.1.2.
💔javadoc0m 13shbase-shaded-check-invariants in the patch failed.
💔javadoc2m 43sroot in the patch failed.
_ Other Tests _
💔unit237m 58sroot in the patch failed.
💚asflicense1m 26sThe patch does not generate ASF License warnings.
288m 56s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/Dockerfile
GITHUB PR#593
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux e3ddd761c737 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-593/out/precommit/personality/provided.sh
git revisionmaster / 1dcc8ee
Default Java1.8.0_181
mvninstallhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-mvninstall-root.txt
compilehttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-compile-root.txt
javachttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-compile-root.txt
shadedjarshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-shadedjars.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javac-2.8.5.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javac-2.9.2.txt
hadoopcheckhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javac-3.1.2.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javadoc-hbase-shaded_hbase-shaded-check-invariants.txt
javadochttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-javadoc-root.txt
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/testReport/
Max. process+thread count5475 (vs. ulimit of 10000)
modulesC: hbase-shaded/hbase-shaded-check-invariants . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/6/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 16, 2019

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec1m 25sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💛test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
💙mvndep0m 48sMaven dependency ordering for branch
💚mvninstall6m 8smaster passed
💚compile3m 1smaster passed
💚shadedjars4m 52sbranch has no errors when building our shaded downstream artifacts.
💚javadoc3m 15smaster passed
_ Patch Compile Tests _
💙mvndep0m 22sMaven dependency ordering for patch
💚mvninstall5m 7sthe patch passed
💚compile3m 7sthe patch passed
💚javac3m 7sthe patch passed
💚whitespace0m 0sThe patch has no whitespace issues.
💚xml0m 3sThe patch has no ill-formed XML file.
💚shadedjars4m 31spatch has no errors when building our shaded downstream artifacts.
💚hadoopcheck15m 22sPatch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚javadoc3m 3sthe patch passed
_ Other Tests _
💔unit213m 12sroot in the patch failed.
💚asflicense1m 19sThe patch does not generate ASF License warnings.
271m 48s
ReasonTests
Failed junit testshadoop.hbase.snapshot.TestExportSnapshotNoCluster
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/7/artifact/out/Dockerfile
GITHUB PR#593
Optional Testsdupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
unameLinux 70f1639321db 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-593/out/precommit/personality/provided.sh
git revisionmaster / 1cb4f68
Default Java1.8.0_181
unithttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/7/artifact/out/patch-unit-root.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/7/testReport/
Max. process+thread count5385 (vs. ulimit of 10000)
modulesC: hbase-shaded/hbase-shaded-check-invariants . U: .
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-593/7/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z)
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 approved these changes Sep 18, 2019
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@Apache9
Apache9 merged commit 18ac610 into apache:masterSep 18, 2019
asfgit pushed a commit that referenced this pull request Sep 18, 2019
@rabi-kumar@Apache9
HBASE-22927Upgrade Mockito version for jdk11 (#593)
37d49aa
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit that referenced this pull request Sep 18, 2019
@rabi-kumar@Apache9
HBASE-22927Upgrade Mockito version for jdk11 (#593)
8869b8e
Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit pushed a commit that referenced this pull request Sep 18, 2019
@rabi-kumar@Apache9
HBASE-22927Upgrade Mockito version for jdk11 (#593)
75a5f34
Signed-off-by: Duo Zhang <zhangduo@apache.org>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@rabi-kumar@Apache9
HBASE-22927 Upgrade Mockito version for jdk11 (apache#593)
27f18dc
Signed-off-by: Duo Zhang <zhangduo@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@rabi-kumarJenkins
HBASE-22927 Upgrade Mockito version for jdk11 (apache#593)
5c5d968
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 8869b8e)
Change-Id: Iaacf3c68b7247c7f3ff84a762908ee4ea2e78a0e
stoty pushed a commit to stoty/hbase that referenced this pull request Nov 22, 2025
@wchevreuilAmina Dinari
CDPD-83261: 2.6 rebase breaks TestHStore in cdh_main (apache#593)
4b2fe32
Co-authored-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rabi-kumar@Apache-HBase@Apache9@busbey