Uh oh!
There was an error while loading. Please reload this page.
HBASE-22971 Deprecated RSGroupAdminEndpoint and make RSGroup feature … - #595
Conversation
Apache9
commented
Sep 6, 2019
Not fully done yet, plan to only keep the Endpoint service for compatibility. Just put it here to see whether we break something. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1686157 to
4ca760fCompare
This comment has been minimized.
This comment has been minimized.
3dcc39b to
ce72633CompareApache-HBase
commented
Sep 11, 2019
💔 -1 overall
This message was automatically generated. |
e80c702 to
9300631CompareApache-HBase
commented
Sep 17, 2019
💔 -1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
| } | ||
| private FavoredNodesPromoter getFavoredNodePromoter() { | ||
| return (FavoredNodesPromoter) ((RSGroupBasedLoadBalancer) master.getLoadBalancer()) |
There was a problem hiding this comment.
No need to cast to RSGroupBasedLoadBalancer?
There was a problem hiding this comment.
The return value for the MasterServices interface is still LoadBalancer so...
There was a problem hiding this comment.
For 3.0, I thought we can change this in the future?
infraio
commented
Sep 18, 2019
The master ui show RSGroup info by the coprocessor "RSGroupEndpoint" config. Need to update too. |
Apache9
commented
Sep 18, 2019
It uses RSGroupTableAccessor to access the rsgroup table directly. I think the problem here is that we will use the coprocessor to test whether we should show rs group on master web page. This can be done in another issue, as I think maybe we still need a flag about whether to enable rs group. |
Apache-HBase
commented
Sep 18, 2019
💔 -1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Yes. May be another issue. Use RSGroupInfoManager to get the rsgroups directly. And only show the ui when there are more than one rsgroups. |
Apache-HBase
commented
Sep 19, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2019
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 23, 2019
💔 -1 overall
This message was automatically generated. |
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (apache#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled (apache#595) Signed-off-by: Guanghao Zhang <zghao@apache.org>
…always enabled