Uh oh!
There was an error while loading. Please reload this page.
HBASE-28642 Hide old PR comments when posting new - #5967
Conversation
fdf451e to
d881732Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d881732 to
4f3adb1Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4f3adb1 to
20357e8Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e56b870 to
f3ad29eCompare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ndimiduk
commented
Sep 12, 2024
This PR is now automatically hiding its own old comments :D |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
NihalJain
commented
Sep 12, 2024
Hey @ndimiduk thanks for this nice fix. LGTM, added some nits. This will make PRs comments very clean. Just to test the case that it does not hide actual user comment (which seems to be handled in code already), can we do a dummy build and see. |
ndimiduk
commented
Sep 12, 2024
I've been using a version of this script locally for all PRs i've reviewed since around April. It's never hidden a wrong comment by mistake. Indeed, you see that the commit author is hard-coded. |
f81c92d to
3a5335eCompareApache-HBase
commented
Sep 17, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Sep 17, 2024
🎊 +1 overall
This message was automatically generated. |
aalhour
commented
Sep 17, 2024
I looked at GitHub's GraphQL API docs and unfortunately it doesn't support mutations over filters. The API has the following input fields:
The |
petersomogyi
left a comment
There was a problem hiding this comment.
This is a lifesaver! :) Thanks @ndimiduk!
Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
It would be really nice if the build bot would hide the old commits when it posts new ones. When a PR has been open for a while, we end up with more build-bot activity than human activity and it's easy to lose human comments.