Skip to content

HBASE-28642 Hide old PR comments when posting new - #5967

Merged
ndimiduk merged 2 commits into
apache:masterfrom
ndimiduk:28642-hide-old-pr-comments
Sep 17, 2024
Merged

HBASE-28642 Hide old PR comments when posting new#5967
ndimiduk merged 2 commits into
apache:masterfrom
ndimiduk:28642-hide-old-pr-comments

Conversation

@ndimiduk

@ndimidukndimiduk commented Jun 6, 2024

Copy link
Copy Markdown
Member

It would be really nice if the build bot would hide the old commits when it posts new ones. When a PR has been open for a while, we end up with more build-bot activity than human activity and it's easy to lose human comments.

@ndimiduk
ndimidukforce-pushed the 28642-hide-old-pr-comments branch from fdf451e to d881732CompareJune 6, 2024 12:51
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk
ndimidukforce-pushed the 28642-hide-old-pr-comments branch from d881732 to 4f3adb1CompareJune 12, 2024 08:20
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk
ndimidukforce-pushed the 28642-hide-old-pr-comments branch from 4f3adb1 to 20357e8CompareSeptember 11, 2024 13:19
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk
ndimidukforce-pushed the 28642-hide-old-pr-comments branch from e56b870 to f3ad29eCompareSeptember 12, 2024 08:34
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

This PR is now automatically hiding its own old comments :D

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Comment threaddev-support/gh_hide_old_comments
Comment threaddev-support/gh_hide_old_comments
@NihalJain

Copy link
Copy Markdown
Contributor

This PR is now automatically hiding its own old comments :D

Hey @ndimiduk thanks for this nice fix. LGTM, added some nits. This will make PRs comments very clean. Just to test the case that it does not hide actual user comment (which seems to be handled in code already), can we do a dummy build and see.

@ndimiduk

Copy link
Copy Markdown
MemberAuthor

This PR is now automatically hiding its own old comments :D

Hey @ndimiduk thanks for this nice fix. LGTM, added some nits. This will make PRs comments very clean. Just to test the case that it does not hide actual user comment (which seems to be handled in code already), can we do a dummy build and see.

I've been using a version of this script locally for all PRs i've reviewed since around April. It's never hidden a wrong comment by mistake. Indeed, you see that the commit author is hard-coded.

@ndimiduk
ndimidukforce-pushed the 28642-hide-old-pr-comments branch from f81c92d to 3a5335eCompareSeptember 17, 2024 08:41
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
-0 ⚠️patch0m 13sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
_ Other Tests _
1m 34s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5967/18/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5967
Optional Tests
unameLinux 1f8e83ab18ed 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3a5335e
Max. process+thread count42 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5967/18/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
-0 ⚠️patch0m 43sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚shellcheck0m 0sNo new issues.
+1 💚spotless0m 41spatch has no errors when running spotless:check.
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
3m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5967/18/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5967
Optional Testsdupname asflicense codespell detsecrets shellcheck shelldocs spotless
unameLinux 543d4b7730a7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3a5335e
Max. process+thread count47 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5967/18/console
versionsgit=2.34.1 maven=3.9.8 shellcheck=0.8.0
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@aalhour

Copy link
Copy Markdown
Contributor

I looked at GitHub's GraphQL API docs and unfortunately it doesn't support mutations over filters. The API has the following input fields:

  1. classifier (ReportedContentClassifiers!)
  2. clientMutationId (String)
  3. subjectId (ID!)

The ! character in the type definition denotes a required field, which means you need to pass the commentID (subjectID) with each API call, if you want to use the API you'll have to fetch all comments and then iterate over all of them minimizing them one by one (N+1 API calls).

@petersomogyipetersomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lifesaver! :) Thanks @ndimiduk!

@ndimiduk
ndimiduk merged commit 125b502 into apache:masterSep 17, 2024
@ndimiduk
ndimiduk deleted the 28642-hide-old-pr-comments branch September 17, 2024 10:50
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
ndimiduk added a commit that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
ndimiduk added a commit that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
ndimiduk added a commit that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
ndimiduk added a commit that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ndimiduk@Apache-HBase@NihalJain@aalhour@petersomogyi