Skip to content

HBASE-28688 Correct the usage for blanks ignore options in yetus - #6026

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28688
Jun 23, 2024
Merged

HBASE-28688 Correct the usage for blanks ignore options in yetus#6026
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28688

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Jun 23, 2024
@Apache9

Copy link
Copy Markdown
ContributorAuthor

Tested with HBASE-28688 branch, there is an extra commit for only running general checks on the HBASE-28688 branch in the main repo so I created a new branch to open the PR we want to merge.

This is the nightly result, you can see that the blanks warnings are much less now
https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-28688/8/General_20Nightly_20Build_20Report/

This is the pre commit check, you can see that I manually added a line which ends with spaces but we just ignored it, which means the ignore file has taken effect.
#6025

Will try another round as I added some more entries in the ignore files, let's see if we can make the result more clear. But anyway, we can confirm that the blanks ignore file finally works.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 51sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
_ Other Tests _
1m 57s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6026/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6026
Optional Tests
unameLinux 25cc51222751 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bc19a09
Max. process+thread count39 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6026/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 49sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
_ Other Tests _
1m 49s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6026/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6026
Optional Tests
unameLinux 2efc1845f990 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bc19a09
Max. process+thread count43 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6026/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 1sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 8sMaven dependency ordering for patch
_ Other Tests _
2m 10s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6026/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#6026
Optional Tests
unameLinux 1284e58c8207 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bc19a09
Max. process+thread count28 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6026/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 51sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+0 🆗shelldocs0m 1sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚shellcheck0m 0sNo new issues.
+1 💚spotless0m 39spatch has no errors when running spotless:check.
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
3m 26s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6026/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6026
Optional Testsdupname asflicense codespell detsecrets spotless shellcheck shelldocs
unameLinux 6dd31528fc1e 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / bc19a09
Max. process+thread count44 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6026/1/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@infraioinfraio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache9
Apache9 merged commit d1015a6 into apache:masterJun 23, 2024
Apache9 added a commit that referenced this pull request Jun 23, 2024
Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit d1015a6)
Apache9 added a commit that referenced this pull request Jun 23, 2024
Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit d1015a6)
Apache9 added a commit that referenced this pull request Jun 23, 2024
Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit d1015a6)
Apache9 added a commit that referenced this pull request Jun 23, 2024
Signed-off-by: Guanghao Zhang <zghao@apache.org>
(cherry picked from commit d1015a6)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@infraio