Skip to content

HBASE-28684 Remove CellWrapper and use ExtendedCell internally in cli… - #6044

Merged
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-28684
Jul 11, 2024
Merged

HBASE-28684 Remove CellWrapper and use ExtendedCell internally in cli…#6044
Apache9 merged 2 commits into
apache:masterfrom
Apache9:HBASE-28684

Conversation

@Apache9

@Apache9Apache9 commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

…ent side data structure

@Apache-HBase

Apache-HBase commented Jul 3, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 1sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 50smaster passed
+1 💚compile8m 9smaster passed
+1 💚checkstyle2m 37smaster passed
+1 💚spotbugs6m 4smaster passed
+1 💚spotless0m 49sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 28sthe patch passed
+1 💚compile7m 33sthe patch passed
-0 ⚠️javac0m 49s/results-compile-javac-hbase-common.txthbase-common generated 2 new + 65 unchanged - 0 fixed = 67 total (was 65)
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 18s/results-checkstyle-hbase-common.txthbase-common: The patch generated 2 new + 17 unchanged - 11 fixed = 19 total (was 28)
+1 💚checkstyle0m 19shbase-client: The patch generated 0 new + 26 unchanged - 1 fixed = 26 total (was 27)
-0 ⚠️checkstyle0m 44s/results-checkstyle-hbase-server.txthbase-server: The patch generated 2 new + 70 unchanged - 4 fixed = 72 total (was 74)
+1 💚checkstyle0m 13shbase-mapreduce: The patch generated 0 new + 18 unchanged - 5 fixed = 18 total (was 23)
+1 💚checkstyle0m 36sThe patch passed checkstyle in hbase-thrift
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-endpoint
+1 💚checkstyle0m 12sThe patch passed checkstyle in hbase-backup
-1 ❌spotbugs0m 54s/new-spotbugs-hbase-common.htmlhbase-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
-1 ❌spotbugs2m 3s/new-spotbugs-hbase-server.htmlhbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚hadoopcheck6m 35sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 48spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense1m 17sThe patch does not generate ASF License warnings.
61m 51s
ReasonTests
SpotBugsmodule:hbase-common
instanceof will always return true for all non-null values in org.apache.hadoop.hbase.PrivateCellUtil.writeCell(ExtendedCell, OutputStream, boolean), since all org.apache.hadoop.hbase.ExtendedCell are instances of org.apache.hadoop.hbase.ExtendedCell At PrivateCellUtil.java:for all non-null values in org.apache.hadoop.hbase.PrivateCellUtil.writeCell(ExtendedCell, OutputStream, boolean), since all org.apache.hadoop.hbase.ExtendedCell are instances of org.apache.hadoop.hbase.ExtendedCell At PrivateCellUtil.java:[line 2244]
Possible null pointer dereference of cell in org.apache.hadoop.hbase.PrivateCellUtil.ensureExtendedCell(Cell) Dereferenced at PrivateCellUtil.java:cell in org.apache.hadoop.hbase.PrivateCellUtil.ensureExtendedCell(Cell) Dereferenced at PrivateCellUtil.java:[line 2960]
SpotBugsmodule:hbase-server
instanceof will always return true for all non-null values in org.apache.hadoop.hbase.regionserver.wal.SecureWALCellCodec$EncryptedKvEncoder.write(ExtendedCell), since all org.apache.hadoop.hbase.ExtendedCell are instances of org.apache.hadoop.hbase.ExtendedCell At SecureWALCellCodec.java:for all non-null values in org.apache.hadoop.hbase.regionserver.wal.SecureWALCellCodec$EncryptedKvEncoder.write(ExtendedCell), since all org.apache.hadoop.hbase.ExtendedCell are instances of org.apache.hadoop.hbase.ExtendedCell At SecureWALCellCodec.java:[line 182]
instanceof will always return true for all non-null values in org.apache.hadoop.hbase.security.visibility.VisibilityController.preBatchMutate(ObserverContext, MiniBatchOperationInProgress), since all org.apache.hadoop.hbase.ExtendedCell are instances of org.apache.hadoop.hbase.ExtendedCell At VisibilityController.java:for all non-null values in org.apache.hadoop.hbase.security.visibility.VisibilityController.preBatchMutate(ObserverContext, MiniBatchOperationInProgress), since all org.apache.hadoop.hbase.ExtendedCell are instances of org.apache.hadoop.hbase.ExtendedCell At VisibilityController.java:[line 305]
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6044
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 3613b01103da 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 578337b
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9Apache9 self-assigned this Jul 3, 2024
@Apache-HBase

Apache-HBase commented Jul 3, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 8smaster passed
+1 💚compile2m 51smaster passed
+1 💚javadoc2m 4smaster passed
+1 💚shadedjars5m 47sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 56sthe patch passed
+1 💚compile2m 52sthe patch passed
+1 💚javac2m 52sthe patch passed
+1 💚javadoc2m 3sthe patch passed
+1 💚shadedjars5m 46spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 13shbase-common in the patch passed.
+1 💚unit1m 34shbase-client in the patch passed.
-1 ❌unit12m 45s/patch-unit-hbase-server.txthbase-server in the patch failed.
-1 ❌unit28m 15s/patch-unit-hbase-mapreduce.txthbase-mapreduce in the patch failed.
-1 ❌unit418m 9s/patch-unit-hbase-thrift.txthbase-thrift in the patch failed.
-1 ❌unit3m 31s/patch-unit-hbase-endpoint.txthbase-endpoint in the patch failed.
+1 💚unit10m 15shbase-backup in the patch passed.
508m 38s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6044
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 38012932f11d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 578337b
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/1/testReport/
Max. process+thread count3725 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 4, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 57smaster passed
+1 💚compile6m 18smaster passed
+1 💚checkstyle1m 57smaster passed
+1 💚spotbugs5m 5smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
+1 💚compile6m 14sthe patch passed
-0 ⚠️javac0m 37s/results-compile-javac-hbase-common.txthbase-common generated 1 new + 65 unchanged - 0 fixed = 66 total (was 65)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 12shbase-common: The patch generated 0 new + 17 unchanged - 11 fixed = 17 total (was 28)
+1 💚checkstyle0m 15shbase-client: The patch generated 0 new + 26 unchanged - 1 fixed = 26 total (was 27)
-0 ⚠️checkstyle0m 34s/results-checkstyle-hbase-server.txthbase-server: The patch generated 2 new + 71 unchanged - 4 fixed = 73 total (was 75)
+1 💚checkstyle0m 11shbase-mapreduce: The patch generated 0 new + 18 unchanged - 5 fixed = 18 total (was 23)
+1 💚checkstyle0m 28sThe patch passed checkstyle in hbase-thrift
+1 💚checkstyle0m 8sThe patch passed checkstyle in hbase-endpoint
+1 💚checkstyle0m 8sThe patch passed checkstyle in hbase-backup
-1 ❌spotbugs1m 34s/new-spotbugs-hbase-server.htmlhbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚hadoopcheck5m 16sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 55sThe patch does not generate ASF License warnings.
49m 33s
ReasonTests
SpotBugsmodule:hbase-server
instanceof will always return true for all non-null values in org.apache.hadoop.hbase.security.visibility.VisibilityController.preBatchMutate(ObserverContext, MiniBatchOperationInProgress), since all org.apache.hadoop.hbase.ExtendedCell are instances of org.apache.hadoop.hbase.ExtendedCell At VisibilityController.java:for all non-null values in org.apache.hadoop.hbase.security.visibility.VisibilityController.preBatchMutate(ObserverContext, MiniBatchOperationInProgress), since all org.apache.hadoop.hbase.ExtendedCell are instances of org.apache.hadoop.hbase.ExtendedCell At VisibilityController.java:[line 306]
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6044
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 0c55166fb5cc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / e7d0791
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 48smaster passed
+1 💚compile6m 4smaster passed
+1 💚checkstyle1m 56smaster passed
+1 💚spotbugs4m 57smaster passed
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 38sthe patch passed
+1 💚compile6m 0sthe patch passed
-0 ⚠️javac0m 35s/results-compile-javac-hbase-common.txthbase-common generated 1 new + 65 unchanged - 0 fixed = 66 total (was 65)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 12shbase-common: The patch generated 0 new + 17 unchanged - 11 fixed = 17 total (was 28)
+1 💚checkstyle0m 14shbase-client: The patch generated 0 new + 26 unchanged - 1 fixed = 26 total (was 27)
-0 ⚠️checkstyle0m 34s/results-checkstyle-hbase-server.txthbase-server: The patch generated 2 new + 71 unchanged - 4 fixed = 73 total (was 75)
+1 💚checkstyle0m 10shbase-mapreduce: The patch generated 0 new + 18 unchanged - 5 fixed = 18 total (was 23)
+1 💚checkstyle0m 28sThe patch passed checkstyle in hbase-thrift
+1 💚checkstyle0m 8sThe patch passed checkstyle in hbase-endpoint
+1 💚checkstyle0m 8sThe patch passed checkstyle in hbase-backup
+1 💚spotbugs5m 36sthe patch passed
+1 💚hadoopcheck5m 3sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 39spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 54sThe patch does not generate ASF License warnings.
47m 44s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6044
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 4e8dc2d88cc1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b3c880
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 4, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 55smaster passed
+1 💚compile2m 52smaster passed
+1 💚javadoc2m 3smaster passed
+1 💚shadedjars5m 43sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 58sthe patch passed
+1 💚compile2m 52sthe patch passed
+1 💚javac2m 52sthe patch passed
+1 💚javadoc2m 3sthe patch passed
+1 💚shadedjars5m 45spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 17shbase-common in the patch passed.
+1 💚unit1m 33shbase-client in the patch passed.
-1 ❌unit219m 36s/patch-unit-hbase-server.txthbase-server in the patch failed.
+1 💚unit17m 51shbase-mapreduce in the patch passed.
+1 💚unit6m 42shbase-thrift in the patch passed.
+1 💚unit3m 34shbase-endpoint in the patch passed.
+1 💚unit10m 11shbase-backup in the patch passed.
296m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6044
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 8c0789dbbe25 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 9b3c880
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/3/testReport/
Max. process+thread count5356 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Jul 6, 2024

Copy link
Copy Markdown
ContributorAuthor

TestPassCustomCellViaRegionObserver is added by HBASE-19550, where we allow passing customized Cell implementations in CP, now we do not allow this, so I just remove the test.

@Apache-HBase

Apache-HBase commented Jul 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 56sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall3m 38smaster passed
+1 💚compile8m 43smaster passed
+1 💚checkstyle3m 0smaster passed
+1 💚spotbugs7m 15smaster passed
+1 💚spotless1m 3sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 33sthe patch passed
+1 💚compile10m 29sthe patch passed
-0 ⚠️javac1m 16s/results-compile-javac-hbase-common.txthbase-common generated 1 new + 65 unchanged - 0 fixed = 66 total (was 65)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 22shbase-common: The patch generated 0 new + 17 unchanged - 11 fixed = 17 total (was 28)
+1 💚checkstyle0m 25shbase-client: The patch generated 0 new + 26 unchanged - 1 fixed = 26 total (was 27)
-0 ⚠️checkstyle0m 57s/results-checkstyle-hbase-server.txthbase-server: The patch generated 2 new + 71 unchanged - 4 fixed = 73 total (was 75)
+1 💚checkstyle0m 17shbase-mapreduce: The patch generated 0 new + 18 unchanged - 5 fixed = 18 total (was 23)
+1 💚checkstyle0m 40sThe patch passed checkstyle in hbase-thrift
+1 💚checkstyle0m 13sThe patch passed checkstyle in hbase-endpoint
+1 💚checkstyle0m 15sThe patch passed checkstyle in hbase-backup
+1 💚spotbugs9m 34sthe patch passed
+1 💚hadoopcheck6m 40sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless1m 8spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense1m 34sThe patch does not generate ASF License warnings.
73m 14s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6044
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux c551da372639 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 36ba5ca
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count84 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/4/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 8smaster passed
+1 💚compile2m 51smaster passed
+1 💚javadoc2m 3smaster passed
+1 💚shadedjars5m 45sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile2m 54sthe patch passed
+1 💚javac2m 54sthe patch passed
+1 💚javadoc2m 2sthe patch passed
+1 💚shadedjars5m 46spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit2m 16shbase-common in the patch passed.
+1 💚unit1m 33shbase-client in the patch passed.
+1 💚unit210m 13shbase-server in the patch passed.
+1 💚unit17m 48shbase-mapreduce in the patch passed.
+1 💚unit6m 39shbase-thrift in the patch passed.
+1 💚unit4m 38shbase-endpoint in the patch passed.
+1 💚unit11m 4shbase-backup in the patch passed.
289m 11s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6044
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 0e367daf16d8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 36ba5ca
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/4/testReport/
Max. process+thread count4792 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6044/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 requested a review from apurtellJuly 8, 2024 02:06
ddupg
ddupg approved these changes Jul 10, 2024
View reviewed changes

@ddupgddupg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache9
Apache9 merged commit 2edd7e0 into apache:masterJul 11, 2024
Apache9 added a commit that referenced this pull request Jul 11, 2024
@Apache9
HBASE-28684Remove CellWrapper and use ExtendedCell internally in cli…
c2ce859
…ent side data structure (#6044)
Signed-off-by: Xin Sun <sunxin@apache.org>
(cherry picked from commit 2edd7e0)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddupgddupgddupg approved these changes
@apurtellapurtellAwaiting requested review from apurtell

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@ddupg