Skip to content

HBASE-28724 BucketCache.notifyFileCachingCompleted may throw IllegalMonitorStateException - #6074

Merged
wchevreuil merged 2 commits into
apache:masterfrom
wchevreuil:HBASE-28724
Jul 15, 2024
Merged

HBASE-28724 BucketCache.notifyFileCachingCompleted may throw IllegalMonitorStateException#6074
wchevreuil merged 2 commits into
apache:masterfrom
wchevreuil:HBASE-28724

Conversation

@wchevreuil

@wchevreuilwchevreuil commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@wchevreuil
HBASE-28724 BucketCache.notifyFileCachingCompleted may throw IllegalM…
0870efe
…onitorStateException
Change-Id: Ib7311f597fcde8cf72456e0defe50ae98a2da692
@Apache-HBase

Apache-HBase commented Jul 11, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 2smaster passed
+1 💚compile3m 4smaster passed
+1 💚checkstyle0m 38smaster passed
+1 💚spotbugs1m 35smaster passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 56sthe patch passed
+1 💚compile3m 0sthe patch passed
+1 💚javac3m 0sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 38s/results-checkstyle-hbase-server.txthbase-server: The patch generated 1 new + 10 unchanged - 0 fixed = 11 total (was 10)
+1 💚spotbugs1m 39sthe patch passed
+1 💚hadoopcheck10m 30sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌spotless0m 38spatch has 63 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
35m 44s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6074
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux bc1d3c2e57fe 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0870efe
Default JavaEclipse Adoptium-17.0.11+9
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count84 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 11, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 17smaster passed
+1 💚compile0m 58smaster passed
+1 💚javadoc0m 27smaster passed
+1 💚shadedjars5m 51sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 6sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚javadoc0m 26sthe patch passed
+1 💚shadedjars5m 50spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit216m 51shbase-server in the patch passed.
242m 5s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6074
Optional Testsjavac javadoc unit compile shadedjars
unameLinux f22de4f8a2db 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 0870efe
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/1/testReport/
Max. process+thread count5464 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
spotless
237f02b
Change-Id: I307b7347ba260e610b35d339c728e2cee74f3880
@Apache-HBase

Apache-HBase commented Jul 12, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 58smaster passed
+1 💚compile3m 46smaster passed
+1 💚checkstyle1m 2smaster passed
+1 💚spotbugs2m 24smaster passed
+1 💚spotless0m 56sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 49sthe patch passed
+1 💚compile4m 8sthe patch passed
+1 💚javac4m 8sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 50sthe patch passed
+1 💚spotbugs2m 13sthe patch passed
+1 💚hadoopcheck13m 7sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 57spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
46m 15s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6074
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 72a1730031a9 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 237f02b
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi
petersomogyi approved these changes Jul 12, 2024
View reviewed changes

@petersomogyipetersomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Apache-HBase

Apache-HBase commented Jul 12, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 4smaster passed
+1 💚compile0m 59smaster passed
+1 💚javadoc0m 31smaster passed
+1 💚shadedjars5m 20sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 55sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚javadoc0m 31sthe patch passed
+1 💚shadedjars6m 59spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit244m 23shbase-server in the patch passed.
270m 51s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6074
Optional Testsjavac javadoc unit compile shadedjars
unameLinux cf0a506df5a1 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 237f02b
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/2/testReport/
Max. process+thread count4681 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6074/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
wchevreuil merged commit 2b673bd into apache:masterJul 15, 2024
wchevreuil added a commit that referenced this pull request Jul 15, 2024
@wchevreuil
HBASE-28724BucketCache.notifyFileCachingCompleted may throw IllegalM…
946bc39
…onitorStateException (#6074)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit 2b673bd)
wchevreuil added a commit to wchevreuil/hbase that referenced this pull request Jul 15, 2024
@wchevreuil
HBASE-28724 BucketCache.notifyFileCachingCompleted may throw IllegalM…
617455c
…onitorStateException (apache#6074)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked by commit 2b673bd)
wchevreuil added a commit that referenced this pull request Jul 22, 2024
@wchevreuil
HBASE-28724BucketCache.notifyFileCachingCompleted may throw IllegalM…
317d3aa
…onitorStateException (#6074) (#6081)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
wchevreuil added a commit that referenced this pull request Jul 22, 2024
@wchevreuil
HBASE-28724BucketCache.notifyFileCachingCompleted may throw IllegalM…
eaa8e34
…onitorStateException (#6074) (#6081)
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyipetersomogyipetersomogyi approved these changes
@chrajeshbabuchrajeshbabuAwaiting requested review from chrajeshbabu
@ankitsinghalankitsinghalAwaiting requested review from ankitsinghal
@stotystotyAwaiting requested review from stoty

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wchevreuil@Apache-HBase@petersomogyi