Skip to content

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2.5 - #6100

Merged
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:28716-branch-2.5
Jul 24, 2024
Merged

Backport "HBASE-28716 Users of QuotaRetriever should pass an existing connection (#6065)" to branch-2.5#6100
ndimiduk merged 1 commit into
apache:branch-2.5from
ndimiduk:28716-branch-2.5

Conversation

@ndimiduk

@ndimidukndimiduk commented Jul 19, 2024

Copy link
Copy Markdown
Member

No description provided.

@ndimidukndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Jul 19, 2024
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
pankaj72981
pankaj72981 approved these changes Jul 22, 2024
View reviewed changes

@pankaj72981pankaj72981 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@ndimiduk@charlesconnell
HBASE-28716 Users of QuotaRetriever should pass an existing connection (
5efba33
apache#6065)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Signed-off-by: Pankaj Kumar <pankajkumar@apache.org>
Co-authored-by: Charles Connell <cconnell@hubspot.com>
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

Apache-HBase commented Jul 24, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall3m 9sbranch-2.5 passed
+1 💚compile3m 26sbranch-2.5 passed
+1 💚checkstyle0m 55sbranch-2.5 passed
+1 💚spotbugs2m 26sbranch-2.5 passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 56sthe patch passed
+1 💚compile3m 22sthe patch passed
+1 💚javac3m 22sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 54sthe patch passed
+1 💚spotbugs2m 41sthe patch passed
+1 💚hadoopcheck22m 10sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚spotless0m 47spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 19sThe patch does not generate ASF License warnings.
47m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6100
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux c6ce3545f2c0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 5efba33
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count78 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 24, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 49sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
-1 ❌mvninstall0m 42s/branch-mvninstall-root.txtroot in branch-2.5 failed.
-1 ❌compile0m 10s/branch-compile-hbase-client.txthbase-client in branch-2.5 failed.
-1 ❌compile0m 14s/branch-compile-hbase-server.txthbase-server in branch-2.5 failed.
-0 ⚠️javadoc0m 6s/branch-javadoc-hbase-client.txthbase-client in branch-2.5 failed.
-0 ⚠️javadoc0m 7s/branch-javadoc-hbase-server.txthbase-server in branch-2.5 failed.
+1 💚shadedjars5m 13sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 7sMaven dependency ordering for patch
+1 💚mvninstall2m 19sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
-0 ⚠️javadoc0m 21s/results-javadoc-javadoc-hbase-client.txthbase-client generated 31 new + 0 unchanged - 0 fixed = 31 total (was 0)
-0 ⚠️javadoc0m 31s/results-javadoc-javadoc-hbase-server.txthbase-server generated 18 new + 0 unchanged - 0 fixed = 18 total (was 0)
+1 💚shadedjars5m 38spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit7m 52shbase-client in the patch passed.
+1 💚unit196m 23shbase-server in the patch passed.
226m 7s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6100
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 4c8949478d2b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 5efba33
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/testReport/
Max. process+thread count4057 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 24, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 56sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall3m 20sbranch-2.5 passed
+1 💚compile1m 28sbranch-2.5 passed
+1 💚javadoc0m 56sbranch-2.5 passed
+1 💚shadedjars6m 9sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 31sthe patch passed
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
+1 💚javadoc0m 56sthe patch passed
+1 💚shadedjars5m 41spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit8m 14shbase-client in the patch passed.
+1 💚unit203m 21shbase-server in the patch passed.
240m 44s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6100
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 9febc24dc461 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 5efba33
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/testReport/
Max. process+thread count4252 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Jul 24, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall2m 50sbranch-2.5 passed
+1 💚compile1m 21sbranch-2.5 passed
+1 💚javadoc0m 51sbranch-2.5 passed
+1 💚shadedjars5m 5sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 50sthe patch passed
+1 💚compile1m 20sthe patch passed
+1 💚javac1m 20sthe patch passed
+1 💚javadoc0m 47sthe patch passed
+1 💚shadedjars5m 5spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit8m 4shbase-client in the patch passed.
+1 💚unit211m 3shbase-server in the patch passed.
245m 26s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6100
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 10dacae22d9b 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 5efba33
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/testReport/
Max. process+thread count4279 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6100/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk

ndimiduk commented Jul 24, 2024

Copy link
Copy Markdown
MemberAuthor

I'm not sure what's going on with jenkins. My local builds of branch-2.5 with jd8 are fine, with and without this patch. FYI @apurtell

@ndimiduk
ndimiduk merged commit 5cf4e21 into apache:branch-2.5Jul 24, 2024
@ndimiduk
ndimiduk deleted the 28716-branch-2.5 branch July 24, 2024 11:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pankaj72981pankaj72981pankaj72981 approved these changes

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@pankaj72981