HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region by guluo2016 · Pull Request #6117 · apache/hbase

guluo2016 · 2024-07-24T14:03:01Z

Apache-HBase · 2024-07-24T14:15:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+1 💚	mvninstall	3m 7s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 52s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		9m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6117
Optional Tests	dupname asflicense javac codespell detsecrets spotless
uname	Linux 966900a115cb 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bf0f90f`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-24T17:52:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 23s		master passed
+1 💚	javadoc	0m 28s		master passed
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed
			_ Other Tests _
+1 💚	unit	215m 20s		hbase-server in the patch passed.
		227m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6117
Optional Tests	javac javadoc unit
uname	Linux 9b3909b7d665 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bf0f90f`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/1/testReport/
Max. process+thread count	4990 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

guluo2016 · 2024-07-25T15:04:41Z

Hi @Apache9 , I also found that type conversion is no need in region.jsp, as fallow.

List<? extends Store> stores = region.getStores();
for (Store store : stores) {
String cf = store.getColumnFamilyName();
Collection<? extends StoreFile> storeFiles = store.getStorefiles(); %>

Maybe we can also fix it in this PR , Or we can open a new PR ?

Apache9 · 2024-07-25T15:08:27Z

If it is simple you can just fix it in this PR.

Apache-HBase · 2024-07-26T09:45:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+1 💚	mvninstall	3m 5s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		9m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6117
Optional Tests	dupname asflicense javac codespell detsecrets spotless
uname	Linux 3d4559709192 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `084cc4b`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-26T13:23:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 23s		master passed
+1 💚	javadoc	0m 26s		master passed
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	javadoc	0m 27s		the patch passed
			_ Other Tests _
+1 💚	unit	216m 8s		hbase-server in the patch passed.
		227m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6117
Optional Tests	javac javadoc unit
uname	Linux 5419c8db0a30 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `084cc4b`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/testReport/
Max. process+thread count	5258 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6117/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-07-27T03:03:40Z

@pankaj72981 Do you have any other concerns?

Thanks.

pankaj72981 · 2024-07-27T05:39:33Z

@pankaj72981 Do you have any other concerns?
Thanks.

No more suggestions, we are good to go now. Thanks @guluo2016

pankaj72981

+1 LGTM

…ca region (#6117) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Pankaj Kumar <pankajkumar@apache.org> (cherry picked from commit 6d89c63)

FNFE may occur when accessing the region.jsp of the replica region
bf0f90f

guluo2016 mentioned this pull request Jul 24, 2024
HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2) #6118
Merged

Apache9 approved these changes Jul 25, 2024
View reviewed changes

pankaj72981 reviewed Jul 25, 2024
View reviewed changes

Comment threadhbase-server/src/main/resources/hbase-webapps/regionserver/region.jsp Outdated

Add primary region check and fix the type conversion issue
084cc4b

pankaj72981 approved these changes Jul 27, 2024
View reviewed changes

Apache9 merged commit 6d89c63 into apache:masterJul 27, 2024

guluo2016 mentioned this pull request Jul 27, 2024
HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region (branch-2.5) #6123
Merged

guluo2016 deleted the hbase_HBASE-28753 branch July 31, 2024 03:09

Navigation Menu

Uh oh!

HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region - #6117

HBASE-28753 FNFE may occur when accessing the region.jsp of the replica region#6117
Apache9 merged 2 commits into
apache:masterfrom
guluo2016:hbase_HBASE-28753

guluo2016 commented Jul 24, 2024

Uh oh!

Apache-HBase commented Jul 24, 2024

Uh oh!

Apache-HBase commented Jul 24, 2024

Uh oh!

guluo2016 commented Jul 25, 2024

Uh oh!

Apache9 commented Jul 25, 2024

Uh oh!

Uh oh!

Apache-HBase commented Jul 26, 2024

Uh oh!

Apache-HBase commented Jul 26, 2024

Uh oh!

Apache9 commented Jul 27, 2024

Uh oh!

pankaj72981 commented Jul 27, 2024

Uh oh!

pankaj72981 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

guluo2016 commented Jul 24, 2024

Uh oh!

Apache-HBase commented Jul 24, 2024

Uh oh!

Apache-HBase commented Jul 24, 2024

Uh oh!

guluo2016 commented Jul 25, 2024

Uh oh!

Apache9 commented Jul 25, 2024

Uh oh!

Uh oh!

Apache-HBase commented Jul 26, 2024

Uh oh!

Apache-HBase commented Jul 26, 2024

Uh oh!

Apache9 commented Jul 27, 2024

Uh oh!

pankaj72981 commented Jul 27, 2024

Uh oh!

pankaj72981 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants