Skip to content

HBASE-28754 verify the first argument passed to compaction_switch - #6119

Merged
Apache9 merged 5 commits into
apache:masterfrom
ether1984:HBASE-28754
Mar 26, 2025
Merged

HBASE-28754 verify the first argument passed to compaction_switch#6119
Apache9 merged 5 commits into
apache:masterfrom
ether1984:HBASE-28754

Conversation

@ether1984

@ether1984ether1984 commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

Sometimes, users may inadvertently attempt to use compaction_switch; therefore, it is advisable to implement a verification step for the first argument passed to this function, ensuring that incorrect inputs do not accidentally disable compaction.

@ether1984
Update admin.rb
1c649da
Verify the first argument passed to compaction_switch to prevent incorrect inputs from accidentally disabling compaction.
@ether1984ether1984 changed the title verify the first argument passed to compaction_switchHBASE-6028 verify the first argument passed to compaction_switchJul 24, 2024
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache9

Apache9 commented Jul 27, 2024

Copy link
Copy Markdown
Contributor

Is this the correct jira issue number?

guluo2016
guluo2016 reviewed Jul 27, 2024
View reviewed changes
Comment threadhbase-shell/src/main/ruby/hbase/admin.rb Outdated
@ether1984ether1984 changed the title HBASE-6028 verify the first argument passed to compaction_switchHBASE-28754 verify the first argument passed to compaction_switchJul 27, 2024
@ether1984

ether1984 commented Jul 27, 2024

Copy link
Copy Markdown
ContributorAuthor

Is this the correct jira issue number?
I made a mistake the correct jira issue is:
https://issues.apache.org/jira/browse/HBASE-28754

@ether1984
Update admin.rb
5e4289b
change error message from compactionSwitch to compaction_switch
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache9

Apache9 commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Can we add a UT to verify the added code actually works?

Thanks.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@ether1984

ether1984 commented Aug 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Can we add a UT to verify the added code actually works?

Thanks.

@Apache9 UT has been added. The UT verifies both illegal and correct arguments, and returns the expected result.
Thanks for your review

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache9

Apache9 commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

Missed this one.

Let me kick the pre commit again.

@Apache-HBase

Apache-HBase commented Nov 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 3smaster passed
+1 💚spotless0m 42sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 48sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️rubocop0m 18s/results-rubocop.txtThe patch generated 3 new + 750 unchanged - 0 fixed = 753 total (was 750)
+1 💚spotless0m 40spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
9m 24s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6119
Optional Testsdupname asflicense javac codespell detsecrets rubocop spotless
unameLinux c9fd302d2812 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 107d5db
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/console
versionsgit=2.34.1 maven=3.9.8 rubocop=1.37.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 0smaster passed
+1 💚javadoc0m 13smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 55sthe patch passed
+1 💚javadoc0m 12sthe patch passed
_ Other Tests _
+1 💚unit7m 1shbase-shell in the patch passed.
14m 47s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6119
Optional Testsjavac javadoc unit
unameLinux baca0fbcf88c 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 107d5db
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/testReport/
Max. process+thread count2040 (vs. ulimit of 30000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6119/7/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@guluo2016

guluo2016 commented Mar 26, 2025

Copy link
Copy Markdown
Member

This PR seems to have been ready for a long time. @Apache9

@Apache9
Apache9 merged commit b625bda into apache:masterMar 26, 2025
Apache9 pushed a commit that referenced this pull request Mar 26, 2025
@ether1984wangjue@Apache9
HBASE-28754verify the first argument passed to compaction_switch (#6119
0b33724
)
Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
Apache9 pushed a commit that referenced this pull request Mar 26, 2025
@ether1984wangjue@Apache9
HBASE-28754verify the first argument passed to compaction_switch (#6119
b1d20d5
)
Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
Apache9 pushed a commit that referenced this pull request Mar 26, 2025
@ether1984wangjue@Apache9
HBASE-28754verify the first argument passed to compaction_switch (#6119
5f6b215
)
Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
Apache9 pushed a commit that referenced this pull request Mar 26, 2025
@ether1984wangjue@Apache9
HBASE-28754verify the first argument passed to compaction_switch (#6119
9331055
)
Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
@ether1984wangjue@mokai87
HBASE-28754 verify the first argument passed to compaction_switch (ap…
10f4881
…ache#6119)
Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
sanjeet006py pushed a commit to sanjeet006py/hbase that referenced this pull request Sep 26, 2025
@ether1984wangjuetok_sfci135 tok_sfci135
HBASE-28754 verify the first argument passed to compaction_switch (ap…
b1a6078
…ache#6119)
Co-authored-by: wangjue <ether1984@163.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: guluo <lupeng_nwpu@qq.com>
Reviewed-by: Chandra Sekhar K <chandrasekhar188k@gmail.com>
(cherry picked from commit b625bda)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes
@guluo2016guluo2016guluo2016 approved these changes
@chandrasekhar-188kchandrasekhar-188kchandrasekhar-188k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ether1984@Apache-HBase@Apache9@guluo2016@chandrasekhar-188k