HBASE-28690 Aborting Active HMaster is not rejecting reportRegionStateTransition if procedure is initialised by next Active master by Umeshkumar9414 · Pull Request #6129 · apache/hbase

Umeshkumar9414 · 2024-07-29T17:52:27Z

masterStartCode as a fencing token for remote procedures
There are 3 flows that I checked regionOpen, regionClose, and other remote Procedures. In might not be needed in the third flow but I added masterStartCode in all three.

Apache-HBase · 2024-07-29T18:55:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 9s		master passed
+1 💚	compile	4m 24s		master passed
+1 💚	checkstyle	0m 57s		master passed
+1 💚	spotbugs	4m 39s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	4m 21s		the patch passed
+1 💚	cc	4m 21s		the patch passed
+1 💚	javac	4m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 58s		the patch passed
+1 💚	spotbugs	4m 49s		the patch passed
+1 💚	hadoopcheck	11m 41s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 32s		the patch passed
+1 💚	spotless	0m 42s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		50m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux b3f783cab393 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c3e35e1`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-29T22:20:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s		master passed
+1 💚	compile	1m 59s		master passed
+1 💚	javadoc	1m 0s		master passed
+1 💚	shadedjars	5m 21s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 52s		the patch passed
+1 💚	compile	2m 0s		the patch passed
+1 💚	javac	2m 0s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed
+1 💚	shadedjars	5m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 37s		hbase-client in the patch passed.
+1 💚	unit	223m 39s		hbase-server in the patch passed.
		254m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a2f3b35df3e9 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c3e35e1`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/testReport/
Max. process+thread count	5531 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-29T23:10:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 1s		master passed
+1 💚	compile	4m 23s		master passed
+1 💚	checkstyle	0m 57s		master passed
+1 💚	spotbugs	4m 31s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 0s		the patch passed
+1 💚	compile	4m 24s		the patch passed
+1 💚	cc	4m 24s		the patch passed
+1 💚	javac	4m 24s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 56s		the patch passed
+1 💚	spotbugs	4m 56s		the patch passed
+1 💚	hadoopcheck	11m 23s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 33s		the patch passed
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 24s		The patch does not generate ASF License warnings.
		49m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 51007c278fa7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2a4203f`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-30T02:34:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 56s		master passed
+1 💚	compile	1m 59s		master passed
+1 💚	javadoc	0m 59s		master passed
+1 💚	shadedjars	5m 20s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	2m 0s		the patch passed
+1 💚	javac	2m 0s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed
+1 💚	shadedjars	5m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 36s		hbase-client in the patch passed.
+1 💚	unit	222m 12s		hbase-server in the patch passed.
		253m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 7c4b9dcca2c1 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2a4203f`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/testReport/
Max. process+thread count	5722 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Overall LGTM, just some logging and comments issues.

Thanks!

Apache9 · 2024-07-30T02:40:41Z

 return ReportProcedureDoneResponse.getDefaultInstance();
 }

+ private void throwOnOldMasterStartCode(Stream<Long> masterStartCodeStream)


Could use LongStream here, but for me I prefer we log more about the procedures here, like which procedure's master start code is greater than current master's start code, and also log the start codes for better debugging.

Apache9 · 2024-07-30T02:42:46Z

 private final HRegion region;
 private final long openProcId;
 private final long masterSystemTime;
+ private final long masterStartCode;


Better add some comments or give it a more clear name so developers will know that this is the start code of the master which scheduled this procedure, for fencing.

mnpoonia · 2024-07-31T10:23:31Z

Had a offline discussion with @Umeshkumar9414 and this logic has a flaw. Instead of using master start code we should be using master active time for fencing otherwise we will end up in a deadly loop of old master not processing rpc reequests.

Apache9 · 2024-07-31T10:39:42Z

Had a offline discussion with @Umeshkumar9414 and this logic has a flaw. Instead of using master start code we should be using master active time for fencing otherwise we will end up in a deadly loop of old master not processing rpc reequests.

I do not get the point...

The problem we want to solve here is to not allow old master to process rpc requests?

mnpoonia · 2024-07-31T11:21:15Z

@Apache9 - the problem with master start code is that if we are running 5 masters and one of the master which have highest start code creates the procedure and aborts. Now since all other masters have start code smaller than last active(which has aborted now), this check

 if (masterStartCodeFromProc > server.getStartcode()) {
// procedure is initiated by new active master but report received on different
throw new MasterNotRunningException("Another master is active");
}

will always pass and we will always throw exception. So instead of using the master start code we should be using master active time for this check. The misunderstanding i believe was that start code changes when a master becomes active which is false. Only master active time would update when a master becomes active.

Apache9 · 2024-07-31T13:01:18Z

@Apache9 - the problem with master start code is that if we are running 5 masters and one of the master which have highest start code creates the procedure and aborts. Now since all other masters have start code smaller than last active(which has aborted now), this check
 if (masterStartCodeFromProc > server.getStartcode()) {
// procedure is initiated by new active master but report received on different
throw new MasterNotRunningException("Another master is active");
}
will always pass and we will always throw exception. So instead of using the master start code we should be using master active time for this check. The misunderstanding i believe was that start code changes when a master becomes active which is false. Only master active time would update when a master becomes active.

OK, so the problem here is that, a backup master may have lower start code then the current active master, and once the backup master becomes the active master, it can not accept the procedure's report which was scheduled by the previous active master.

Makes sense. We should use the timestamp when the master becomes the active master.

Umeshkumar9414 · 2024-07-31T19:24:16Z

Yeah, I will change this to use masterActiveTime

Umeshkumar9414 · 2024-08-04T09:45:13Z

@Apache9 , @mnpoonia , @ranganathg , @virajjasani I try to resolve all the concerns. Please review.

Apache-HBase · 2024-08-04T10:11:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 23s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 10s		master passed
+1 💚	compile	4m 18s		master passed
+1 💚	checkstyle	0m 57s		master passed
+1 💚	spotbugs	4m 28s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	4m 24s		the patch passed
+1 💚	cc	4m 24s		the patch passed
+1 💚	javac	4m 24s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 35s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 2 new + 12 unchanged - 0 fixed = 14 total (was 12)
+1 💚	spotbugs	4m 56s		the patch passed
+1 💚	hadoopcheck	11m 30s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 31s		the patch passed
-1 ❌	spotless	0m 36s		patch has 33 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		51m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 3da8d4dc4804 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e201096`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	88 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-04T14:02:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	4m 3s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 7s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 59s		master passed
+1 💚	compile	1m 59s		master passed
+1 💚	javadoc	1m 0s		master passed
+1 💚	shadedjars	5m 23s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	1m 58s		the patch passed
+1 💚	javac	1m 58s		the patch passed
+1 💚	javadoc	1m 0s		the patch passed
+1 💚	shadedjars	5m 21s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 36s		hbase-client in the patch passed.
-1 ❌	unit	247m 51s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		282m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 6e71f28f524b 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e201096`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/3/testReport/
Max. process+thread count	5770 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-04T14:45:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s		master passed
+1 💚	compile	2m 1s		master passed
+1 💚	javadoc	0m 58s		master passed
+1 💚	shadedjars	5m 20s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 59s		the patch passed
+1 💚	compile	2m 0s		the patch passed
+1 💚	javac	2m 0s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed
+1 💚	shadedjars	5m 21s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 38s		hbase-client in the patch passed.
-1 ❌	unit	13m 40s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		41m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 3ce13875f5ab 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7f4511c`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/4/testReport/
Max. process+thread count	1429 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-04T14:52:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s		master passed
+1 💚	compile	4m 22s		master passed
+1 💚	checkstyle	0m 57s		master passed
+1 💚	spotbugs	4m 27s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 0s		the patch passed
+1 💚	compile	4m 21s		the patch passed
+1 💚	cc	4m 21s		the patch passed
+1 💚	javac	4m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)
+1 💚	spotbugs	4m 50s		the patch passed
+1 💚	hadoopcheck	11m 20s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 32s		the patch passed
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		48m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 007c8e0278ba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7f4511c`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-05T07:09:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 3s		master passed
+1 💚	compile	4m 23s		master passed
+1 💚	checkstyle	0m 58s		master passed
+1 💚	spotbugs	4m 31s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	4m 25s		the patch passed
+1 💚	cc	4m 25s		the patch passed
+1 💚	javac	4m 25s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 56s		the patch passed
+1 💚	spotbugs	4m 54s		the patch passed
+1 💚	hadoopcheck	11m 21s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 32s		the patch passed
+1 💚	spotless	0m 42s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 24s		The patch does not generate ASF License warnings.
		49m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 7f70c76cd6ba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fb427b9`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

mnpoonia

Looks good!!

Apache-HBase · 2024-08-05T11:34:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 53s		master passed
+1 💚	compile	2m 1s		master passed
+1 💚	javadoc	0m 59s		master passed
+1 💚	shadedjars	5m 23s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	1m 59s		the patch passed
+1 💚	javac	1m 59s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed
+1 💚	shadedjars	5m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 38s		hbase-client in the patch passed.
-1 ❌	unit	283m 25s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		314m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux e34b6810ae93 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fb427b9`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/5/testReport/
Max. process+thread count	5474 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Umeshkumar9414 · 2024-08-05T18:56:10Z

For branch-2 - #6136

Apache-HBase · 2024-08-09T20:11:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 16s		master passed
+1 💚	compile	4m 32s		master passed
+1 💚	checkstyle	0m 59s		master passed
+1 💚	spotbugs	4m 38s		master passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	4m 27s		the patch passed
+1 💚	cc	4m 27s		the patch passed
+1 💚	javac	4m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 57s		the patch passed
+1 💚	spotbugs	5m 7s		the patch passed
+1 💚	hadoopcheck	11m 46s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 33s		the patch passed
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 26s		The patch does not generate ASF License warnings.
		50m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 5fbe25067f01 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `587e08c`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	87 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/6/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-09T23:33:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 56s		master passed
+1 💚	compile	1m 59s		master passed
+1 💚	javadoc	0m 59s		master passed
+1 💚	shadedjars	5m 18s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	2m 0s		the patch passed
+1 💚	javac	2m 0s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed
+1 💚	shadedjars	5m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 37s		hbase-client in the patch passed.
+1 💚	unit	221m 46s		hbase-server in the patch passed.
		252m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux f4877ec34568 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `587e08c`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/6/testReport/
Max. process+thread count	5838 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-08-10T13:41:25Z

 public UnassignRegionHandler(HRegionServer server, String encodedName, long closeProcId,
 boolean abort, @Nullable ServerName destination, EventType eventType) {
- this(server, encodedName, closeProcId, abort, destination, eventType, false);
+ this(server, encodedName, closeProcId, abort, destination, eventType, -1, false);


Where do we call this constructor? Is it safe to just use -1 here?

I am not sure if anyone is using this. At least in the code, I didn't see any usage of this. As I was not aware I didn't change the signature. -1 is safe as it will not block the procedure reporting as -1 will be the smallest active code.
Should I follow the aggressive approach and ask for an argument and pass that further? I think that would be good. Let me change to that approch

I think best would be just remove it

Apache9 · 2024-08-10T14:26:26Z

 }

- public RemoteProcedureRequest buildRequest() {
+ public RemoteProcedureRequest buildRequest(long initiatingMasterActiveTime) {


I prefer we add initiatingMasterActiveTime as a field of the operation, instead of a method parameter.We can add a initiatingMasterActiveTime in ServerOperation and RegionOperation class.

@Umeshkumar9414 FYI

At that time I had some thoughts in my mind -
Including this in operation will introduce too many changes.
Should I add this to the Procedure class or in the Operation? But now I am clear in this perspective. I am adding this into operation as this is something related to dispatching not related to the procedure itself.

There were other reasons also like there is a difference in how we create requests for OpenRegion and CloseRegions. For OpenRegionRequest we create only one request for all the OpenRegionOperations but for close we create CloseRegoinRequest for each operation.
It would be all good in close but for OpenRegionRequest here, we need to get the activeCode from one of the entry.

It would be like this
builder.setInitiatingMasterActiveTime(operations.stream().map( RemoteOperation::getInitiatingMasterActiveTime).findAny().get());

changed it as well. Added that in RemoteOperations

Apache-HBase · 2024-08-14T21:58:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s		master passed
+1 💚	compile	4m 35s		master passed
+1 💚	checkstyle	1m 1s		master passed
+1 💚	spotbugs	4m 56s		master passed
+1 💚	spotless	0m 47s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 11s		the patch passed
+1 💚	compile	4m 30s		the patch passed
+1 💚	cc	4m 30s		the patch passed
+1 💚	javac	4m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 1s		the patch passed
+1 💚	spotbugs	5m 17s		the patch passed
+1 💚	hadoopcheck	11m 55s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 36s		the patch passed
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 26s		The patch does not generate ASF License warnings.
		52m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 87717ea1ed7d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1a1b78d`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/7/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-15T01:47:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 37s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 48s		master passed
+1 💚	compile	2m 56s		master passed
+1 💚	javadoc	1m 21s		master passed
+1 💚	shadedjars	8m 20s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 51s		the patch passed
+1 💚	compile	3m 2s		the patch passed
+1 💚	javac	3m 2s		the patch passed
+1 💚	javadoc	1m 26s		the patch passed
+1 💚	shadedjars	7m 27s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 46s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	2m 21s		hbase-client in the patch passed.
+1 💚	unit	238m 13s		hbase-server in the patch passed.
		281m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 939149b312f5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1a1b78d`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/7/testReport/
Max. process+thread count	5289 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/7/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…tion

Apache-HBase · 2024-08-17T13:14:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 8s		master passed
+1 💚	compile	4m 43s		master passed
+1 💚	checkstyle	1m 5s		master passed
+1 💚	spotbugs	4m 52s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 59s		the patch passed
+1 💚	compile	4m 46s		the patch passed
+1 💚	cc	4m 46s		the patch passed
+1 💚	javac	4m 46s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 8s		the patch passed
+1 💚	spotbugs	5m 29s		the patch passed
+1 💚	hadoopcheck	11m 26s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 44s		the patch passed
+1 💚	spotless	0m 42s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		54m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 98ca095e22cf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cf101ab`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	87 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/9/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-17T16:38:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s		master passed
+1 💚	compile	2m 16s		master passed
+1 💚	javadoc	1m 13s		master passed
+1 💚	shadedjars	5m 21s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	compile	2m 16s		the patch passed
+1 💚	javac	2m 16s		the patch passed
+1 💚	javadoc	1m 12s		the patch passed
+1 💚	shadedjars	5m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 37s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 38s		hbase-client in the patch passed.
+1 💚	unit	1m 28s		hbase-procedure in the patch passed.
-1 ❌	unit	223m 56s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		257m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 208887e6fb92 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cf101ab`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/9/testReport/
Max. process+thread count	6403 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/9/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-17T21:00:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	buf	0m 1s		buf was not available.
+0 🆗	buf	0m 1s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 9s		master passed
+1 💚	compile	5m 56s		master passed
+1 💚	checkstyle	1m 18s		master passed
+1 💚	spotbugs	6m 2s		master passed
+1 💚	spotless	0m 59s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 50s		the patch passed
+1 💚	compile	5m 48s		the patch passed
+1 💚	cc	5m 48s		the patch passed
+1 💚	javac	5m 48s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 16s		the patch passed
+1 💚	spotbugs	7m 39s		the patch passed
+1 💚	hadoopcheck	17m 16s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	2m 7s		the patch passed
+1 💚	spotless	0m 50s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		69m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux d72608859cf1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `56d2666`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/10/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-18T00:05:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 27s		master passed
+1 💚	compile	2m 48s		master passed
+1 💚	javadoc	1m 24s		master passed
+1 💚	shadedjars	6m 29s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 57s		the patch passed
+1 💚	compile	2m 56s		the patch passed
+1 💚	javac	2m 56s		the patch passed
+1 💚	javadoc	1m 18s		the patch passed
+1 💚	shadedjars	6m 48s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 42s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 56s		hbase-client in the patch passed.
+1 💚	unit	1m 42s		hbase-procedure in the patch passed.
+1 💚	unit	214m 12s		hbase-server in the patch passed.
		254m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/10/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 82e87ed194b2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `56d2666`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/10/testReport/
Max. process+thread count	5603 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/10/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Umeshkumar9414 · 2024-08-18T04:46:18Z

@Apache9 , @virajjasani kindly review and merge.

Apache9

Overall LGTM. Only a small nits.

Thanks @Umeshkumar9414 !

Apache9 · 2024-08-18T14:01:37Z

 final OpenRegionRequest.Builder builder = OpenRegionRequest.newBuilder();
- builder.setServerStartCode(serverName.getStartcode());
+ builder.setServerStartCode(serverName.getStartCode());
+ builder.setInitiatingMasterActiveTime(operations.stream()


If this field is optional in the pb message, better to use stream().findAny().IfPresent(builder::setInitiatingMasterActiveTime)

Umeshkumar9414 · 2024-08-18T18:56:21Z

PR for branch-2 #6136

Apache-HBase · 2024-08-18T19:44:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 1s		master passed
+1 💚	compile	4m 44s		master passed
+1 💚	checkstyle	1m 5s		master passed
+1 💚	spotbugs	4m 54s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	4m 47s		the patch passed
+1 💚	cc	4m 47s		the patch passed
+1 💚	javac	4m 47s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)
+1 💚	spotbugs	5m 25s		the patch passed
+1 💚	hadoopcheck	11m 22s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 44s		the patch passed
-1 ❌	spotless	0m 37s		patch has 23 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		51m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/11/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 8a33f03bf5a2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79366a6`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/11/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/11/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-18T23:08:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 54s		master passed
+1 💚	compile	2m 16s		master passed
+1 💚	javadoc	1m 11s		master passed
+1 💚	shadedjars	6m 7s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 28s		the patch passed
+1 💚	compile	2m 47s		the patch passed
+1 💚	javac	2m 47s		the patch passed
+1 💚	javadoc	1m 18s		the patch passed
+1 💚	shadedjars	5m 21s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 37s		hbase-client in the patch passed.
+1 💚	unit	1m 30s		hbase-procedure in the patch passed.
+1 💚	unit	222m 16s		hbase-server in the patch passed.
		257m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/11/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 65965301412e 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79366a6`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/11/testReport/
Max. process+thread count	5984 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/11/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-19T01:47:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	buf	0m 0s		buf was not available.
+0 🆗	buf	0m 0s		buf was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 27s		master passed
+1 💚	compile	5m 6s		master passed
+1 💚	checkstyle	1m 11s		master passed
+1 💚	spotbugs	5m 23s		master passed
+1 💚	spotless	0m 49s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 14s		the patch passed
+1 💚	compile	5m 2s		the patch passed
+1 💚	cc	5m 2s		the patch passed
+1 💚	javac	5m 2s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 13s		the patch passed
+1 💚	spotbugs	5m 54s		the patch passed
+1 💚	hadoopcheck	11m 56s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	hbaseprotoc	1m 51s		the patch passed
+1 💚	spotless	0m 47s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		55m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/12/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc
uname	Linux 69281cc66a4c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8a93f5d`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/12/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-19T05:16:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 52s		master passed
+1 💚	compile	2m 17s		master passed
+1 💚	javadoc	1m 13s		master passed
+1 💚	shadedjars	5m 22s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 59s		the patch passed
+1 💚	compile	2m 17s		the patch passed
+1 💚	javac	2m 17s		the patch passed
+1 💚	javadoc	1m 13s		the patch passed
+1 💚	shadedjars	5m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 37s		hbase-client in the patch passed.
+1 💚	unit	1m 30s		hbase-procedure in the patch passed.
+1 💚	unit	231m 46s		hbase-server in the patch passed.
		265m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/12/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6129
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a93e77a9c7bb 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8a93f5d`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/12/testReport/
Max. process+thread count	5357 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6129/12/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Umeshkumar9414 · 2024-08-19T16:20:39Z

@Apache9, @virajjasani can you please help me in merging this PR as well as #6136

ranganathg · 2024-08-21T04:54:08Z

Good work! @Umeshkumar9414

…eTransition if procedure is initialised by next Active master (apache#6129) Added masterActiveTime as fencing token for remote procedures Signed-off-by: Duo Zhang <zhangduo@apache.org> Reviewed-by: Aman Poonia <aman.poonia.29@gmail.com> (cherry picked from commit d2a1f19)

Apache9 reviewed Jul 30, 2024
View reviewed changes

virajjasani self-requested a review July 30, 2024 13:00

mnpoonia reviewed Jul 31, 2024
View reviewed changes

Umeshkumar9414 force-pushed the HBASE-28690 branch from 2a4203f to e201096Compare August 4, 2024 09:17

mnpoonia approved these changes Aug 5, 2024
View reviewed changes

Umeshkumar9414 force-pushed the HBASE-28690 branch from f5167cd to 587e08cCompare August 9, 2024 19:10

mnpoonia approved these changes Aug 10, 2024
View reviewed changes

Apache9 reviewed Aug 10, 2024
View reviewed changes

Umeshkumar9414 force-pushed the HBASE-28690 branch from 587e08c to 1a1b78dCompare August 14, 2024 20:52

ukumawat added 9 commits August 17, 2024 17:39

HBASE-28690 comments updated
66a0205

HBASE-28690 add masterStartCode for RemoteProcedureRequest
0e1f001

HBASE-28690 used master active time for fencing and review comments
39244df

HBASE-28690 minor comment addition
aef3cc1

HBASE-28690 spotless apply
960fed4

HBASE-28690 reduce log line length for checkstyle
708625b

HBASE-28690 added getMasterActiveTime in MasterServices for UT's
683133e

HBASE-28690 review comments
37efa65

HBASE-28690 add initiatingMasterActiveTime as a member of RemoteOpera…
cf101ab
…tion

Umeshkumar9414 force-pushed the HBASE-28690 branch from f73196e to cf101abCompare August 17, 2024 12:10

HBASE-28690 dummy commit to re build
56d2666

Apache9 approved these changes Aug 18, 2024
View reviewed changes

HBASE-28690 review comment for stream
79366a6

HBASE-28690 spotless apply
8a93f5d

mnpoonia approved these changes Aug 21, 2024
View reviewed changes

Apache9 changed the title ~~HBASE-28690 added masterStartCode as fencing token for remote procedures~~HBASE-28690 Aborting Active HMaster is not rejecting reportRegionStateTransition if procedure is initialised by next Active masterAug 25, 2024

Apache9 merged commit d2a1f19 into apache:masterAug 25, 2024

Uh oh!

Conversation

Umeshkumar9414 commented Jul 29, 2024

Uh oh!

Apache-HBase commented Jul 29, 2024

Uh oh!

Apache-HBase commented Jul 29, 2024

Uh oh!

Apache-HBase commented Jul 29, 2024

Uh oh!

Apache-HBase commented Jul 30, 2024

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnpoonia commented Jul 31, 2024

Uh oh!

Apache9 commented Jul 31, 2024

Uh oh!

mnpoonia commented Jul 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache9 commented Jul 31, 2024

Uh oh!

Umeshkumar9414 commented Jul 31, 2024

Uh oh!

Umeshkumar9414 commented Aug 4, 2024

Uh oh!

Apache-HBase commented Aug 4, 2024

Uh oh!

Apache-HBase commented Aug 4, 2024

Uh oh!

Apache-HBase commented Aug 4, 2024

Uh oh!

Apache-HBase commented Aug 4, 2024

Uh oh!

Apache-HBase commented Aug 5, 2024

Uh oh!

mnpoonia left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 5, 2024

Uh oh!

Umeshkumar9414 commented Aug 5, 2024

Uh oh!

Apache-HBase commented Aug 9, 2024

Uh oh!

Apache-HBase commented Aug 9, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented Aug 14, 2024

Uh oh!

mnpoonia commented Jul 31, 2024•
edited
Loading