Skip to content

HBASE-27118 Add security headers to Thrift/HTTP server (branch-2) - #6153

Merged
anmolnar merged 2 commits into
apache:branch-2from
anmolnar:HBASE-27118_x2
Aug 14, 2024
Merged

HBASE-27118 Add security headers to Thrift/HTTP server (branch-2)#6153
anmolnar merged 2 commits into
apache:branch-2from
anmolnar:HBASE-27118_x2

Conversation

@anmolnar

@anmolnaranmolnar commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

Backport of 97de291

@anmolnar
HBASE-27118 Add security headers to Thrift/HTTP server (apache#5864)
c384c03
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Istvan Toth <stoty@apache.org>
@anmolnar
anmolnar requested a review from stotyAugust 13, 2024 18:38
@Apache-HBase

Apache-HBase commented Aug 13, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 13sbranch-2 passed
+1 💚compile1m 30sbranch-2 passed
+1 💚checkstyle0m 50sbranch-2 passed
+1 💚spotbugs1m 52sbranch-2 passed
+1 💚spotless0m 47sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
-1 ❌mvninstall3m 6s/patch-mvninstall-root.txtroot in the patch failed.
-1 ❌compile0m 35s/patch-compile-hbase-thrift.txthbase-thrift in the patch failed.
-0 ⚠️javac0m 35s/patch-compile-hbase-thrift.txthbase-thrift in the patch failed.
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 46sthe patch passed
+1 💚xmllint0m 0sNo new issues.
-1 ❌spotbugs0m 17s/patch-spotbugs-hbase-thrift.txthbase-thrift in the patch failed.
-1 ❌hadoopcheck1m 50sThe patch causes 20 errors with Hadoop v2.10.2.
-1 ❌hadoopcheck4m 8sThe patch causes 20 errors with Hadoop v3.3.6.
-1 ❌hadoopcheck6m 31sThe patch causes 20 errors with Hadoop v3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
25m 42s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6153
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
unameLinux 3cf06187af75 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c384c03
Default JavaEclipse Adoptium-11.0.23+9
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count76 (vs. ulimit of 30000)
modulesC: hbase-http hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 13, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 34sbranch-2 passed
+1 💚compile0m 52sbranch-2 passed
+1 💚javadoc0m 47sbranch-2 passed
+1 💚shadedjars5m 20sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
-1 ❌mvninstall2m 31s/patch-mvninstall-root.txtroot in the patch failed.
-1 ❌compile0m 20s/patch-compile-hbase-thrift.txthbase-thrift in the patch failed.
-0 ⚠️javac0m 20s/patch-compile-hbase-thrift.txthbase-thrift in the patch failed.
+1 💚javadoc0m 46sthe patch passed
+1 💚shadedjars5m 19spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 44shbase-http in the patch passed.
-1 ❌unit0m 20s/patch-unit-hbase-thrift.txthbase-thrift in the patch failed.
+1 💚unit3m 59shbase-rest in the patch passed.
26m 45s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6153
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 17549be4c496 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c384c03
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/testReport/
Max. process+thread count1720 (vs. ulimit of 30000)
modulesC: hbase-http hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 13, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 38sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 5sbranch-2 passed
+1 💚compile1m 7sbranch-2 passed
+1 💚javadoc1m 4sbranch-2 passed
+1 💚shadedjars5m 33sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
-1 ❌mvninstall2m 59s/patch-mvninstall-root.txtroot in the patch failed.
-1 ❌compile0m 27s/patch-compile-hbase-thrift.txthbase-thrift in the patch failed.
-0 ⚠️javac0m 27s/patch-compile-hbase-thrift.txthbase-thrift in the patch failed.
+1 💚javadoc1m 2sthe patch passed
+1 💚shadedjars5m 31spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 52shbase-http in the patch passed.
-1 ❌unit0m 27s/patch-unit-hbase-thrift.txthbase-thrift in the patch failed.
+1 💚unit3m 24shbase-rest in the patch passed.
28m 49s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6153
Optional Testsjavac javadoc unit compile shadedjars
unameLinux f5a59f76cd3e 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c384c03
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/testReport/
Max. process+thread count1762 (vs. ulimit of 30000)
modulesC: hbase-http hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 13, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 1sbranch-2 passed
+1 💚compile1m 9sbranch-2 passed
+1 💚javadoc1m 5sbranch-2 passed
+1 💚shadedjars5m 29sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
-1 ❌mvninstall2m 58s/patch-mvninstall-root.txtroot in the patch failed.
-1 ❌compile0m 27s/patch-compile-hbase-thrift.txthbase-thrift in the patch failed.
-0 ⚠️javac0m 27s/patch-compile-hbase-thrift.txthbase-thrift in the patch failed.
+1 💚javadoc1m 5sthe patch passed
+1 💚shadedjars5m 32spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 50shbase-http in the patch passed.
-1 ❌unit0m 27s/patch-unit-hbase-thrift.txthbase-thrift in the patch failed.
+1 💚unit3m 26shbase-rest in the patch passed.
28m 52s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6153
Optional Testsjavac javadoc unit compile shadedjars
unameLinux d676845155f0 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / c384c03
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/testReport/
Max. process+thread count1761 (vs. ulimit of 30000)
modulesC: hbase-http hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 13, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 23sbranch-2 passed
+1 💚compile0m 52sbranch-2 passed
+1 💚javadoc0m 46sbranch-2 passed
+1 💚shadedjars5m 21sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile0m 53sthe patch passed
+1 💚javac0m 53sthe patch passed
+1 💚javadoc0m 45sthe patch passed
+1 💚shadedjars5m 19spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 45shbase-http in the patch passed.
+1 💚unit6m 39shbase-thrift in the patch passed.
+1 💚unit3m 56shbase-rest in the patch passed.
32m 37s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6153
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 0e0754df08f2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bfb3815
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/testReport/
Max. process+thread count1822 (vs. ulimit of 30000)
modulesC: hbase-http hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 13, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall3m 6sbranch-2 passed
+1 💚compile1m 10sbranch-2 passed
+1 💚javadoc1m 6sbranch-2 passed
+1 💚shadedjars5m 28sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 6sthe patch passed
+1 💚compile1m 8sthe patch passed
+1 💚javac1m 8sthe patch passed
+1 💚javadoc1m 5sthe patch passed
+1 💚shadedjars5m 31spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 51shbase-http in the patch passed.
+1 💚unit6m 47shbase-thrift in the patch passed.
+1 💚unit3m 26shbase-rest in the patch passed.
35m 14s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6153
Optional Testsjavac javadoc unit compile shadedjars
unameLinux b7c97d0b2cdf 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bfb3815
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/testReport/
Max. process+thread count1560 (vs. ulimit of 30000)
modulesC: hbase-http hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 13, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 1scodespell was not available.
+0 🆗detsecrets0m 1sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 9sbranch-2 passed
+1 💚compile1m 27sbranch-2 passed
+1 💚checkstyle0m 46sbranch-2 passed
+1 💚spotbugs1m 50sbranch-2 passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 5sthe patch passed
+1 💚compile1m 30sthe patch passed
+1 💚javac1m 30sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 47sthe patch passed
+1 💚xmllint0m 0sNo new issues.
+1 💚spotbugs2m 18sthe patch passed
+1 💚hadoopcheck16m 42sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 45spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 24sThe patch does not generate ASF License warnings.
36m 54s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6153
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
unameLinux af9630b148ea 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bfb3815
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-http hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 13, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 59sbranch-2 passed
+1 💚compile1m 7sbranch-2 passed
+1 💚javadoc1m 3sbranch-2 passed
+1 💚shadedjars5m 32sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 3sthe patch passed
+1 💚compile1m 7sthe patch passed
+1 💚javac1m 7sthe patch passed
+1 💚javadoc1m 3sthe patch passed
+1 💚shadedjars5m 33spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit0m 52shbase-http in the patch passed.
+1 💚unit8m 47shbase-thrift in the patch passed.
+1 💚unit3m 27shbase-rest in the patch passed.
37m 0s
SubsystemReport/Notes
DockerClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6153
Optional Testsjavac javadoc unit compile shadedjars
unameLinux c50215673d4a 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / bfb3815
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/testReport/
Max. process+thread count1853 (vs. ulimit of 30000)
modulesC: hbase-http hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6153/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@anmolnar

anmolnar commented Aug 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@Apache9@stoty Please review this backport.

stoty
stoty approved these changes Aug 14, 2024
View reviewed changes

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

BTW branch-2 backport PRs don't need reviews, we only use them to run the CI checks.

@anmolnar
anmolnar merged commit be762db into apache:branch-2Aug 14, 2024
anmolnar added a commit that referenced this pull request Aug 14, 2024
@anmolnar
HBASE-27118Add security headers to Thrift/HTTP server (branch-2) (#6153
d855593
)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Istvan Toth <stoty@apache.org>
@anmolnar
anmolnar deleted the HBASE-27118_x2 branch August 14, 2024 19:55
anmolnar added a commit to anmolnar/hbase that referenced this pull request Aug 15, 2024
@anmolnar
HBASE-27118 Add security headers to Thrift/HTTP server (branch-2) (ap…
4aba4eb
…ache#6153)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj <pankajkumar@apache.org>
Signed-off-by: Istvan Toth <stoty@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@stotystotystoty approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anmolnar@Apache-HBase@stoty