HBASE-28804: Implement asynchronous retrieval of bucket-cache data from persistence by jhungund · Pull Request #6182 · apache/hbase

jhungund · 2024-08-28T16:22:31Z

During the retrieval of data from bucket cache persistence file, a transient structure that stores the blocks ordered by filename is constructed from the backing map entries. The population of this transient structure is done during the server start-up. This process increases the region-server startup time, if the bucketcache has large number of blocks.

This population happens inline with the server restart and blocks the server for several minutes. This makes the server restart inconvenient for the external users. Restarts during upgrade can run into timeout issues due to this delay in the server startup.

Hence, the recommendation in this Jira is to make the cache-retrieval asynchronous to the server startup. During a server startup, a new thread is spawn that reads the persistence file and creates the required structures from persistence file. The server continues with the restart and does not wait for the bucket-cache initialisation to complete.

Note that the bucket cache is not available immediately for usage and will only be ready to use after the data is repopulated from persistence into memory.

The prefetch thread that may start before the bucket-cache is initialized is modified to wait until the bucket cache is initialized.

Change-Id: I2c136d7b1d884f74642d29923172a1ad4ada36e4

Apache-HBase · 2024-08-28T17:15:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 9s		master passed
+1 💚	compile	3m 35s		master passed
+1 💚	checkstyle	0m 46s		master passed
+1 💚	spotbugs	1m 57s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 0s		the patch passed
+1 💚	compile	3m 31s		the patch passed
+1 💚	javac	3m 31s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 37s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 18 new + 61 unchanged - 1 fixed = 79 total (was 62)
-1 ❌	spotbugs	1m 42s	/new-spotbugs-hbase-server.html	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	hadoopcheck	11m 24s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌	spotless	0m 39s		patch has 68 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 18s		The patch does not generate ASF License warnings.
		40m 1s

Reason	Tests
SpotBugs	module:hbase-server
	new org.apache.hadoop.hbase.io.hfile.bucket.BucketCache(String, long, int, int[], int, int, String, int, Configuration) invokes Thread.start() At BucketCache.java:int, int, String, int, Configuration) invokes Thread.start() At BucketCache.java:[line 373]

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 134b68122884 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `479899f`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-28T20:59:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 0s		master passed
+1 💚	compile	1m 16s		master passed
+1 💚	javadoc	0m 43s		master passed
+1 💚	shadedjars	5m 18s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	1m 18s		the patch passed
+1 💚	javac	1m 18s		the patch passed
-0 ⚠️	javadoc	0m 29s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48)
+1 💚	shadedjars	5m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 21s		hbase-balancer in the patch passed.
+1 💚	unit	228m 43s		hbase-server in the patch passed.
		264m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 7a8e5c05b7e6 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `479899f`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/1/testReport/
Max. process+thread count	4630 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-29T05:59:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 1s		master passed
+1 💚	compile	3m 23s		master passed
+1 💚	checkstyle	0m 45s		master passed
+1 💚	spotbugs	1m 55s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	3m 22s		the patch passed
+1 💚	javac	3m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 18 new + 61 unchanged - 1 fixed = 79 total (was 62)
-1 ❌	spotbugs	1m 37s	/new-spotbugs-hbase-server.html	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	hadoopcheck	10m 52s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌	spotless	0m 36s		patch has 68 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 17s		The patch does not generate ASF License warnings.
		38m 26s

Reason	Tests
SpotBugs	module:hbase-server
	new org.apache.hadoop.hbase.io.hfile.bucket.BucketCache(String, long, int, int[], int, int, String, int, Configuration) invokes Thread.start() At BucketCache.java:int, int, String, int, Configuration) invokes Thread.start() At BucketCache.java:[line 379]

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux d63672b7081b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9de9770`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil · 2024-08-29T09:36:07Z

+ assertTrue(reader.prefetchStarted() || reader.prefetchComplete());
+
+ // Added some delay as we have started the timer a bit late.
+ Thread.sleep(500);


Why do we need this extra sleep after the loop above?

This was present earlier along with the comment at line 378.

I will try to remove this one and check if the test passes.

Yeah, but I assume now that we have an extra wait of 10000, we don't need this one anymore?

wchevreuil · 2024-08-29T09:39:56Z

+ while (!reader.prefetchStarted() && !reader.prefetchComplete()) {
+ // Wait until the prefetch is triggered.
 Thread.sleep(500);
-assertTrue("Prefetch should start post configured delay",
- getElapsedTime(startTime) > PrefetchExecutor.getPrefetchDelay());
+if (timeout <= 0) break;
+timeout -= 500;
 }


Use Waiter.waitFor(Configuration conf, long timeout, long interval, Predicate<E> predicate)

wchevreuil · 2024-08-29T09:40:47Z

+ long timeout = 120000;
+ try {
+ while (!cache.backingMap.containsKey(cacheKey) || cache.ramCache.containsKey(cacheKey)) {
+ Thread.sleep(100);
+ if (timeout <= 0) {
+ break;
+ }
+ timeout -= 100;
+ }
+ } finally {
+ Thread.sleep(1000);


Use Waiter.waitFor(Configuration conf, long timeout, long interval, Predicate<E> predicate)

Hi @wchevreuil , the config object is not available with us here. Probably I can leave out the change this. I had tried to change it to avoid infinite wait.

Just create one HBaseConfiguration.create() and pass along? Waiter only uses it to check for the hbase.test.wait.for.ratio property anyways.

wchevreuil · 2024-08-29T09:41:55Z

+ long timeout = 120000;
+ while (!cache.backingMap.containsKey(cacheKey) || cache.ramCache.containsKey(cacheKey)) {
+ Thread.sleep(100);
+ if (timeout <= 0) {
+ break;
+ }
+ timeout -= 100;
+ }


Use Waiter.waitFor(Configuration conf, long timeout, long interval, Predicate<E> predicate)

Lot more changes needed to get config to this location. I will leave out this change for now.

wchevreuil · 2024-08-29T09:45:08Z

We should add UTs for checking the behaviour of all methods changed as part of this async initialisation.

I could validate all public methods. I am not sure if we can do it for private methods.

Public methods are enough.

Apache-HBase · 2024-08-29T09:48:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 51s		master passed
+1 💚	compile	1m 15s		master passed
+1 💚	javadoc	0m 42s		master passed
+1 💚	shadedjars	5m 15s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	1m 16s		the patch passed
+1 💚	javac	1m 16s		the patch passed
-0 ⚠️	javadoc	0m 30s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48)
+1 💚	shadedjars	5m 16s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 22s		hbase-balancer in the patch passed.
+1 💚	unit	232m 6s		hbase-server in the patch passed.
		267m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 2083cce2fd84 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9de9770`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/2/testReport/
Max. process+thread count	4704 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-29T10:28:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 7s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 59s		master passed
+1 💚	compile	3m 23s		master passed
+1 💚	checkstyle	0m 50s		master passed
+1 💚	spotbugs	2m 2s		master passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	3m 24s		the patch passed
+1 💚	javac	3m 24s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 38s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 6 new + 61 unchanged - 1 fixed = 67 total (was 62)
+1 💚	spotbugs	2m 12s		the patch passed
+1 💚	hadoopcheck	10m 33s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		38m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux e21a198e246f 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8377eb9`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-29T14:31:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 4s		master passed
+1 💚	compile	1m 16s		master passed
+1 💚	javadoc	0m 44s		master passed
+1 💚	shadedjars	5m 15s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	1m 16s		the patch passed
+1 💚	javac	1m 16s		the patch passed
-0 ⚠️	javadoc	0m 33s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48)
+1 💚	shadedjars	6m 29s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 44s		hbase-balancer in the patch passed.
-1 ❌	unit	244m 16s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		281m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux f66b306abaac 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8377eb9`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/3/testReport/
Max. process+thread count	4585 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-29T15:11:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 59s		master passed
+1 💚	compile	3m 23s		master passed
+1 💚	checkstyle	0m 50s		master passed
+1 💚	spotbugs	1m 58s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	3m 23s		the patch passed
+1 💚	javac	3m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 5 new + 61 unchanged - 1 fixed = 66 total (was 62)
+1 💚	spotbugs	2m 13s		the patch passed
+1 💚	hadoopcheck	10m 36s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌	spotless	0m 39s		patch has 24 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 21s		The patch does not generate ASF License warnings.
		38m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux baaefe06142d 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d1b5a6b`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/4/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-29T19:06:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 54s		master passed
+1 💚	compile	1m 16s		master passed
+1 💚	javadoc	0m 43s		master passed
+1 💚	shadedjars	5m 16s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 53s		the patch passed
+1 💚	compile	1m 16s		the patch passed
+1 💚	javac	1m 16s		the patch passed
-0 ⚠️	javadoc	0m 30s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48)
+1 💚	shadedjars	5m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 22s		hbase-balancer in the patch passed.
-1 ❌	unit	238m 50s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		274m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c77273ca925e 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d1b5a6b`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/4/testReport/
Max. process+thread count	4614 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-29T19:48:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s		master passed
+1 💚	compile	3m 20s		master passed
+1 💚	checkstyle	0m 48s		master passed
+1 💚	spotbugs	1m 58s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	compile	3m 22s		the patch passed
+1 💚	javac	3m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 38s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 7 new + 61 unchanged - 1 fixed = 68 total (was 62)
+1 💚	spotbugs	2m 11s		the patch passed
+1 💚	hadoopcheck	11m 15s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌	spotless	0m 47s		patch has 54 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 19s		The patch does not generate ASF License warnings.
		40m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 3a460710acc2 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ab41aac`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/5/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-29T23:31:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 56s		master passed
+1 💚	compile	1m 16s		master passed
+1 💚	javadoc	0m 43s		master passed
+1 💚	shadedjars	5m 16s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	1m 15s		the patch passed
+1 💚	javac	1m 15s		the patch passed
-0 ⚠️	javadoc	0m 29s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48)
+1 💚	shadedjars	5m 16s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 23s		hbase-balancer in the patch passed.
+1 💚	unit	228m 12s		hbase-server in the patch passed.
		263m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 4d144862926f 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ab41aac`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/5/testReport/
Max. process+thread count	4618 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-30T03:58:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 50s		master passed
+1 💚	compile	3m 21s		master passed
+1 💚	checkstyle	0m 43s		master passed
+1 💚	spotbugs	1m 50s		master passed
+1 💚	spotless	0m 42s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	3m 21s		the patch passed
+1 💚	javac	3m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 35s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 5 new + 61 unchanged - 1 fixed = 66 total (was 62)
+1 💚	spotbugs	2m 4s		the patch passed
+1 💚	hadoopcheck	10m 46s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 42s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 17s		The patch does not generate ASF License warnings.
		38m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 0e3cdc44fe8b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bc95794`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/6/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-30T07:29:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 13s		master passed
+1 💚	compile	1m 11s		master passed
+1 💚	javadoc	0m 39s		master passed
+1 💚	shadedjars	5m 46s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	1m 11s		the patch passed
+1 💚	javac	1m 11s		the patch passed
-0 ⚠️	javadoc	0m 27s	/results-javadoc-javadoc-hbase-server.txt	hbase-server generated 1 new + 48 unchanged - 0 fixed = 49 total (was 48)
+1 💚	shadedjars	5m 46s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 12s		hbase-balancer in the patch passed.
+1 💚	unit	212m 30s		hbase-server in the patch passed.
		248m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 6a6df3ccab3a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `bc95794`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/6/testReport/
Max. process+thread count	4703 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil

LGTM, +1.

Apache-HBase · 2024-09-03T14:31:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 18s		master passed
+1 💚	compile	3m 41s		master passed
+1 💚	checkstyle	0m 46s		master passed
+1 💚	spotbugs	1m 59s		master passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 8s		the patch passed
+1 💚	compile	3m 35s		the patch passed
+1 💚	javac	3m 35s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 9 new + 61 unchanged - 1 fixed = 70 total (was 62)
+1 💚	spotbugs	2m 11s		the patch passed
+1 💚	hadoopcheck	11m 35s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌	spotless	0m 37s		patch has 49 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 17s		The patch does not generate ASF License warnings.
		40m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux c25d142d7a6d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d79f091`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/7/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/7/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-03T18:25:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 2s		master passed
+1 💚	compile	1m 16s		master passed
+1 💚	javadoc	0m 43s		master passed
+1 💚	shadedjars	5m 14s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 59s		the patch passed
+1 💚	compile	1m 35s		the patch passed
+1 💚	javac	1m 35s		the patch passed
+1 💚	javadoc	1m 4s		the patch passed
+1 💚	shadedjars	6m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 45s		hbase-balancer in the patch passed.
+1 💚	unit	236m 48s		hbase-server in the patch passed.
		274m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 2f77f50ee414 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d79f091`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/7/testReport/
Max. process+thread count	4649 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/7/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-04T10:06:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 19s		master passed
+1 💚	compile	4m 13s		master passed
+1 💚	checkstyle	0m 55s		master passed
+1 💚	spotbugs	2m 30s		master passed
+1 💚	spotless	1m 5s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 46s		the patch passed
+1 💚	compile	3m 55s		the patch passed
+1 💚	javac	3m 55s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 55s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 4 new + 61 unchanged - 1 fixed = 65 total (was 62)
+1 💚	spotbugs	2m 20s		the patch passed
+1 💚	hadoopcheck	12m 4s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌	spotless	0m 40s		patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 22s		The patch does not generate ASF License warnings.
		45m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux b4db9eb3d860 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `69295b8`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/9/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/9/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-04T13:59:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s		master passed
+1 💚	compile	1m 15s		master passed
+1 💚	javadoc	0m 43s		master passed
+1 💚	shadedjars	5m 16s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	1m 16s		the patch passed
+1 💚	javac	1m 16s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed
+1 💚	shadedjars	5m 14s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 23s		hbase-balancer in the patch passed.
-1 ❌	unit	242m 12s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		278m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux d02884b6f0dc 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `69295b8`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/9/testReport/
Max. process+thread count	4581 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/9/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-04T14:41:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s		master passed
+1 💚	compile	3m 34s		master passed
+1 💚	checkstyle	0m 45s		master passed
+1 💚	spotbugs	1m 58s		master passed
+1 💚	spotless	0m 47s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	3m 34s		the patch passed
+1 💚	javac	3m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 36s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 4 new + 61 unchanged - 1 fixed = 65 total (was 62)
+1 💚	spotbugs	2m 10s		the patch passed
+1 💚	hadoopcheck	11m 35s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 17s		The patch does not generate ASF License warnings.
		40m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/10/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 10aa59b1d15b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `64b2a5e`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/10/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

jhungund · 2024-09-05T04:22:39Z

retest

…om persistence During the retrieval of data from bucket cache persistence file, a transient structure that stores the blocks ordered by filename is constructed from the backing map entries. The population of this transient structure is done during the server start-up. This process increases the region-server startup time, if the bucketcache has large number of blocks. This population happens inline with the server restart and blocks the server for several minutes. This makes the server restart inconvenient for the external users. Restarts during upgrade can run into timeout issues due to this delay in the server startup. Hence, the recommendation in this Jira is to make the cache-retrieval asynchronous to the server startup. During a server startup, a new thread is spawn that reads the persistence file and creates the required structures from persistence file. The server continues with the restart and does not wait for the bucket-cache initialisation to complete. Note that the bucket cache is not available immediately for usage and will only be ready to use after the data is repopulated from persistence into memory. The prefetch thread that may start before the bucket-cache is initialized is modified to wait until the bucket cache is initialized. Change-Id: I2c136d7b1d884f74642d29923172a1ad4ada36e4

Change-Id: I239c357a135a058650a20c5707c7c7303a248c85

Change-Id: Ie160b249f6a2bff18fd8a577ae32a263b7de25ea

…on state. Change-Id: Ib54f565152c391da727be7413dd775fb507daea7

Change-Id: I446475dc84d52403f67762b878af874b9cbe1937

Change-Id: I49d8e39cafff6cbe103f300235bec4aacd42934d

Change-Id: I8db2162c8237c05fd98d3c771f50e5a92c9b78b5

Change-Id: I391e5e453e077b7e5733cd997130467b356a3e66

Change-Id: Ieb6b5841cb7b23d919fbebbe420c0083167d6d0b

Apache-HBase · 2024-09-05T09:45:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 0s		master passed
+1 💚	compile	3m 34s		master passed
+1 💚	checkstyle	0m 44s		master passed
+1 💚	spotbugs	1m 53s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	3m 31s		the patch passed
+1 💚	javac	3m 31s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 9s		The patch passed checkstyle in hbase-balancer
+1 💚	checkstyle	0m 35s		hbase-server: The patch generated 0 new + 61 unchanged - 1 fixed = 61 total (was 62)
+1 💚	spotbugs	2m 10s		the patch passed
+1 💚	hadoopcheck	11m 26s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 16s		The patch does not generate ASF License warnings.
		40m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/11/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 18db424fa444 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c8438d`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/11/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-05T14:08:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 14s		master passed
+1 💚	compile	1m 56s		master passed
+1 💚	javadoc	0m 56s		master passed
+1 💚	shadedjars	6m 27s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 0s		the patch passed
+1 💚	compile	1m 19s		the patch passed
+1 💚	javac	1m 19s		the patch passed
+1 💚	javadoc	0m 51s		the patch passed
+1 💚	shadedjars	5m 22s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 21s		hbase-balancer in the patch passed.
-1 ❌	unit	263m 0s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		302m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/11/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux fac298fe8d69 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c8438d`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/11/testReport/
Max. process+thread count	4627 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/11/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

jhungund · 2024-09-06T04:04:21Z

Hi @wchevreuil, I checked that the failing test is:
org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe
org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe.testLockLeakWithDelta
The failure seems unrelated to this change. Also, I verified that this test does not fail locally with the change.

`(base) janardhan.hungund@MacBook-Pro-4 hbase % git log
commit 2c8438d (HEAD -> HBASE-28804, upstream-fork/HBASE-28804)
Author: Janardhan Hungund janardhan.hungund@cloudera.com
Date: Thu Sep 5 14:27:07 2024 +0530
HBASE-28804: Fixed check-style warnings
Change-Id: Ieb6b5841cb7b23d919fbebbe420c0083167d6d0b

[INFO] Running org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe WARNING: A terminally deprecated method in java.lang.System has been called WARNING: System::setSecurityManager has been called by org.apache.hadoop.hbase.SystemExitRule (file:/Users/janardhan.hungund/hbase-down/hbase/hbase-common/target/hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar) WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.SystemExitRule WARNING: System::setSecurityManager will be removed in a future release WARNING: A terminally deprecated method in java.lang.System has been called WARNING: System::setSecurityManager has been called by org.apache.hadoop.hbase.SystemExitRule$1 (file:/Users/janardhan.hungund/hbase-down/hbase/hbase-common/target/hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar) WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.SystemExitRule$1 WARNING: System::setSecurityManager will be removed in a future release [INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 106.455 s - in org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe [INFO] [INFO] Results: [INFO] [INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0

Hence, the failure does not seem to be related to this change.

Thanks,
Janardhan

Apache-HBase · 2024-09-06T21:57:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 23s		master passed
+1 💚	compile	3m 35s		master passed
+1 💚	checkstyle	0m 45s		master passed
+1 💚	spotbugs	1m 56s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	3m 32s		the patch passed
+1 💚	javac	3m 32s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 9s		The patch passed checkstyle in hbase-balancer
+1 💚	checkstyle	0m 35s		hbase-server: The patch generated 0 new + 61 unchanged - 1 fixed = 61 total (was 62)
+1 💚	spotbugs	2m 7s		the patch passed
+1 💚	hadoopcheck	13m 31s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 58s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 24s		The patch does not generate ASF License warnings.
		44m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/12/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux a77c6a72b7c7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c8438d`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/12/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-07T02:05:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 14s		master passed
+1 💚	compile	1m 42s		master passed
+1 💚	javadoc	0m 56s		master passed
+1 💚	shadedjars	6m 43s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 26s		the patch passed
+1 💚	compile	1m 22s		the patch passed
+1 💚	javac	1m 22s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed
+1 💚	shadedjars	6m 13s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 15s		hbase-balancer in the patch passed.
+1 💚	unit	251m 25s		hbase-server in the patch passed.
		291m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/12/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux d32d7941b0ea 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c8438d`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/12/testReport/
Max. process+thread count	4475 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/12/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-07T02:54:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 16s		master passed
+1 💚	compile	3m 57s		master passed
+1 💚	checkstyle	0m 55s		master passed
+1 💚	spotbugs	2m 41s		master passed
+1 💚	spotless	1m 26s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 39s		the patch passed
+1 💚	compile	4m 13s		the patch passed
+1 💚	javac	4m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 11s		The patch passed checkstyle in hbase-balancer
+1 💚	checkstyle	0m 47s		hbase-server: The patch generated 0 new + 61 unchanged - 1 fixed = 61 total (was 62)
+1 💚	spotbugs	2m 46s		the patch passed
+1 💚	hadoopcheck	12m 0s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 55s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 22s		The patch does not generate ASF License warnings.
		46m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/13/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 673680a03c60 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c8438d`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/13/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-09-07T07:04:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 56s		master passed
+1 💚	compile	1m 30s		master passed
+1 💚	javadoc	0m 46s		master passed
+1 💚	shadedjars	6m 31s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 46s		the patch passed
+1 💚	compile	1m 29s		the patch passed
+1 💚	javac	1m 29s		the patch passed
+1 💚	javadoc	0m 46s		the patch passed
+1 💚	shadedjars	6m 41s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	9m 21s		hbase-balancer in the patch passed.
-1 ❌	unit	255m 49s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		296m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/13/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6182
JIRA Issue	HBASE-28804
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 8756fd78d042 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c8438d`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/13/testReport/
Max. process+thread count	4439 (vs. ulimit of 30000)
modules	C: hbase-balancer hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6182/13/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

jhungund · 2024-09-09T04:37:50Z

Hi @wchevreuil, The failing unit test, org.apache.hadoop.hbase.master.janitor.TestCatalogJanitor.testAlreadyRunningStatus does not seem to be related to this change. The local execution of the test passed on the same branch.

commit 2c8438d2aa6f5f56f785a45b065e4962ad7fa685 (HEAD -> HBASE-28804, upstream-fork/HBASE-28804) Author: Janardhan Hungund <janardhan.hungund@cloudera.com> Date: Thu Sep 5 14:27:07 2024 +0530 HBASE-28804: Fixed check-style warnings Change-Id: Ieb6b5841cb7b23d919fbebbe420c0083167d6d0b

[INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.master.janitor.TestCatalogJanitor WARNING: A terminally deprecated method in java.lang.System has been called WARNING: System::setSecurityManager has been called by org.apache.hadoop.hbase.SystemExitRule (file:/Users/janardhan.hungund/hbase-down/hbase/hbase-common/target/test-classes/) WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.SystemExitRule WARNING: System::setSecurityManager will be removed in a future release WARNING: A terminally deprecated method in java.lang.System has been called WARNING: System::setSecurityManager has been called by org.apache.hadoop.hbase.SystemExitRule$1 (file:/Users/janardhan.hungund/hbase-down/hbase/hbase-common/target/test-classes/) WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.SystemExitRule$1 WARNING: System::setSecurityManager will be removed in a future release [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.862 s - in org.apache.hadoop.hbase.master.janitor.TestCatalogJanitor [INFO] [INFO] Results: [INFO] [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
Please take a look.
Thanks,
Janardhan

…om persistence (apache#6182) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Change-Id: I515d81fdc484cd49308d3164067a2287b8901520

…om persistence (#6182) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

…om persistence (#6182) (#6219) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

… bucket-cache data from persistence (apache#6182) (apache#6219) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

…om persistence (apache#6182) (apache#6219) The cherry-pick of HBASE-29727 into branch-2.6 accidently brought most of HBASE-28804 into branch-2, this is to backport the remaining original change in HBASE-28804. Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Change-Id: I816141ccebf91191aaa4cb6afa04343b64663eb0

wchevreuil reviewed Aug 28, 2024
View reviewed changes

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java Outdated

jhungund force-pushed the HBASE-28804 branch from 479899f to 9de9770Compare August 29, 2024 05:13

jhungund force-pushed the HBASE-28804 branch 2 times, most recently from 7853e54 to 8377eb9Compare August 29, 2024 07:17

wchevreuil reviewed Aug 29, 2024
View reviewed changes

jhungund force-pushed the HBASE-28804 branch from da0a694 to 45c5253Compare August 29, 2024 12:27

jhungund requested a review from wchevreuil August 29, 2024 14:32

wchevreuil reviewed Sep 3, 2024
View reviewed changes

jhungund force-pushed the HBASE-28804 branch from 9ba3087 to d79f091Compare September 3, 2024 13:43

wchevreuil approved these changes Sep 3, 2024
View reviewed changes

jhungund force-pushed the HBASE-28804 branch from d79f091 to 52ee5e5Compare September 3, 2024 15:12

jhungund force-pushed the HBASE-28804 branch from 52ee5e5 to 69295b8Compare September 4, 2024 09:17

jhungund force-pushed the HBASE-28804 branch from 69295b8 to 64b2a5eCompare September 4, 2024 10:09

jhungund added 9 commits September 5, 2024 14:31

HBASE-28804: Apply splotless and spotbugs changes.
6210a96
Change-Id: I239c357a135a058650a20c5707c7c7303a248c85

HBASE-28804: Addressing first round of review comments.
a5a75b7
Change-Id: Ie160b249f6a2bff18fd8a577ae32a263b7de25ea

HBASE-28804: Added unit tests for validation of cache in initializati…
01c5608
…on state. Change-Id: Ib54f565152c391da727be7413dd775fb507daea7

HBASE-28804: Address further review comments.
dbb9403
Change-Id: I446475dc84d52403f67762b878af874b9cbe1937

HBASE-28804: Fix spotless bugs.
cb18e0f
Change-Id: I49d8e39cafff6cbe103f300235bec4aacd42934d

HBASE-28804: Address review comments.
2f2fce8
Change-Id: I8db2162c8237c05fd98d3c771f50e5a92c9b78b5

HBASE-28804: Fix unit test.
06aa65c
Change-Id: I391e5e453e077b7e5733cd997130467b356a3e66

HBASE-28804: Fixed check-style warnings
2c8438d
Change-Id: Ieb6b5841cb7b23d919fbebbe420c0083167d6d0b

jhungund force-pushed the HBASE-28804 branch from 64b2a5e to 2c8438dCompare September 5, 2024 09:01

wchevreuil approved these changes Sep 9, 2024
View reviewed changes

wchevreuil merged commit 0a19b08 into apache:masterSep 9, 2024

wchevreuil pushed a commit that referenced this pull request Sep 9, 2024
HBASE-28804: Implement asynchronous retrieval of bucket-cache data fr…
dced684
…om persistence (#6182) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

wchevreuil pushed a commit that referenced this pull request Sep 11, 2024
HBASE-28804: Implement asynchronous retrieval of bucket-cache data fr…
d4cffea
…om persistence (#6182) (#6219) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

stoty pushed a commit to stoty/hbase that referenced this pull request Nov 22, 2025
CDPD-72949: Backport HBASE-28804: Implement asynchronous retrieval of…
0bf6d65
… bucket-cache data from persistence (apache#6182) (apache#6219) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Uh oh!

Conversation

jhungund commented Aug 28, 2024

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Aug 28, 2024

Uh oh!

Apache-HBase commented Aug 28, 2024

Uh oh!

Apache-HBase commented Aug 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 29, 2024

Uh oh!

Apache-HBase commented Aug 29, 2024

Uh oh!

Apache-HBase commented Aug 29, 2024

Uh oh!

Apache-HBase commented Aug 29, 2024

Uh oh!

Apache-HBase commented Aug 29, 2024

Uh oh!

Apache-HBase commented Aug 29, 2024

Uh oh!

Apache-HBase commented Aug 29, 2024

Uh oh!

Apache-HBase commented Aug 30, 2024

Uh oh!

Apache-HBase commented Aug 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wchevreuil left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Sep 3, 2024

Uh oh!

Apache-HBase commented Sep 3, 2024

Uh oh!

Apache-HBase commented Sep 4, 2024

Uh oh!

Apache-HBase commented Sep 4, 2024

Uh oh!

jhungund commented Sep 6, 2024•
edited
Loading

jhungund commented Sep 9, 2024•
edited
Loading