HBASE-28807 Remove some useless code and add some logs for CanaryTool by wangxin97-02 · Pull Request #6187 · apache/hbase

wangxin97-02 · 2024-08-31T05:06:34Z

Remove some useless code in CanaryTool.sniff.
Add some logs when get null location for table region.

Apache-HBase · 2024-08-31T05:58:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 16s		master passed
+1 💚	compile	3m 6s		master passed
+1 💚	checkstyle	0m 36s		master passed
+1 💚	spotbugs	1m 34s		master passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	3m 9s		the patch passed
+1 💚	javac	3m 9s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 36s		the patch passed
+1 💚	spotbugs	1m 39s		the patch passed
+1 💚	hadoopcheck	11m 31s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		37m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6187
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 51b7b28d3c61 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `217f0c4`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-31T09:16:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 12s		master passed
+1 💚	compile	0m 56s		master passed
+1 💚	javadoc	0m 27s		master passed
+1 💚	shadedjars	5m 46s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	0m 57s		the patch passed
+1 💚	javac	0m 57s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed
+1 💚	shadedjars	5m 44s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	210m 48s		hbase-server in the patch passed.
		236m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6187
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 9571d9f67bc5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `217f0c4`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/1/testReport/
Max. process+thread count	4707 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-31T09:56:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 10s		master passed
+1 💚	compile	3m 12s		master passed
+1 💚	checkstyle	0m 36s		master passed
+1 💚	spotbugs	1m 31s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	compile	3m 9s		the patch passed
+1 💚	javac	3m 9s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 35s		the patch passed
+1 💚	spotbugs	1m 37s		the patch passed
+1 💚	hadoopcheck	11m 29s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 9s		The patch does not generate ASF License warnings.
		37m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6187
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 8dc16ae939ce 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6c0d533`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-31T13:16:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 11s		master passed
+1 💚	compile	0m 57s		master passed
+1 💚	javadoc	0m 26s		master passed
+1 💚	shadedjars	5m 44s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	0m 57s		the patch passed
+1 💚	javac	0m 57s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed
+1 💚	shadedjars	5m 42s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	212m 40s		hbase-server in the patch passed.
		237m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6187
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 0aa7228154b2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6c0d533`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/2/testReport/
Max. process+thread count	5080 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-31T13:56:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 3s		master passed
+1 💚	compile	3m 2s		master passed
+1 💚	checkstyle	0m 36s		master passed
+1 💚	spotbugs	1m 31s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	3m 13s		the patch passed
+1 💚	javac	3m 13s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 37s		the patch passed
+1 💚	spotbugs	1m 40s		the patch passed
+1 💚	hadoopcheck	11m 24s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 9s		The patch does not generate ASF License warnings.
		37m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6187
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 49319678ec8e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6c0d533`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-31T17:16:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 3s		master passed
+1 💚	compile	0m 55s		master passed
+1 💚	javadoc	0m 27s		master passed
+1 💚	shadedjars	5m 31s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 51s		the patch passed
+1 💚	compile	0m 53s		the patch passed
+1 💚	javac	0m 53s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed
+1 💚	shadedjars	5m 32s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	212m 45s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		236m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6187
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 10d3f3a55952 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6c0d533`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/3/testReport/
Max. process+thread count	5572 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6187/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-09-05T11:55:33Z

Hi @1458451310 could you please see if failures are relevant?

wangxin97-02 · 2024-09-06T09:18:48Z

Hi @1458451310 could you please see if failures are relevant?

That's not relevant

[ERROR] Errors:
[ERROR] org.apache.hadoop.hbase.master.assignment.TestRollbackSCP.testFailAndRollback
[ERROR] Run 1: TestRollbackSCP.testFailAndRollback:180 Â» IllegalArgument scheduler queue not empty: MasterProcedureScheduler[running=true,tableMap=TableQueue[key=test,lockStatus=LockAndQueue[exclusiveLock=false,sharedLockCount=0],size=1,namespaceLockStatus=LockAndQueue[exclusiveLock=false,sharedLockCount=0]],tableWaitingMap={},peerMap=,metaMap=,globalMap=]
[ERROR] Run 2: TestRollbackSCP.testFailAndRollback:177 Waiting timed out after [30,000] msec
[ERROR] Run 3: TestRollbackSCP.testFailAndRollback:177 Waiting timed out after [30,000] msec
[INFO]
[INFO]
[ERROR] Tests run: 7004, Failures: 0, Errors: 1, Skipped: 35

NihalJain · 2024-09-06T13:08:50Z

Hi @1458451310 Thanks for the contribution I have merged the PR to codebase.

…apache#6187) Co-authored-by: wangxin <wangxin9702@gmail.com> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit b161ad5)

…#6187) (#6216) Co-authored-by: WangXin <1458451310@qq.com> Co-authored-by: wangxin <wangxin9702@gmail.com> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit b161ad5)

…#6187) (#6214) Co-authored-by: WangXin <1458451310@qq.com> Co-authored-by: wangxin <wangxin9702@gmail.com> Signed-off-by: Nihal Jain <nihaljain@apache.org> (cherry picked from commit b161ad5)

wangxin97-02 force-pushed the HBASE-28807 branch from 217f0c4 to e483795Compare August 31, 2024 08:25

HBASE-28807 Remove some useless code and add some logs for CanaryTool
6c0d533

wangxin97-02 force-pushed the HBASE-28807 branch from e483795 to 6c0d533Compare August 31, 2024 09:05

NihalJain reviewed Sep 4, 2024
View reviewed changes

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java

wangxin97-02 requested a review from NihalJain September 4, 2024 12:06

NihalJain approved these changes Sep 4, 2024
View reviewed changes

NihalJain merged commit b161ad5 into apache:masterSep 6, 2024

NihalJain mentioned this pull request Sep 6, 2024
Backport "HBASE-28807 Remove some useless code and add some logs for CanaryTool" to branch-3 #6213
Closed

NihalJain mentioned this pull request Sep 6, 2024
Backport "HBASE-28807 Remove some useless code and add some logs for CanaryTool" to branch-2 #6214
Merged

NihalJain mentioned this pull request Sep 6, 2024
Backport "HBASE-28807 Remove some useless code and add some logs for CanaryTool" to branch-3 #6216
Merged

Navigation Menu

Uh oh!

HBASE-28807 Remove some useless code and add some logs for CanaryTool - #6187

HBASE-28807 Remove some useless code and add some logs for CanaryTool#6187
NihalJain merged 1 commit into
apache:masterfrom
wangxin97-02:HBASE-28807

wangxin97-02 commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Uh oh!

NihalJain commented Sep 5, 2024

Uh oh!

wangxin97-02 commented Sep 6, 2024

Uh oh!

NihalJain commented Sep 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

wangxin97-02 commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Apache-HBase commented Aug 31, 2024

Uh oh!

Uh oh!

NihalJain commented Sep 5, 2024

Uh oh!

wangxin97-02 commented Sep 6, 2024

Uh oh!

NihalJain commented Sep 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants