Skip to content

HBASE-28811 Use region server configuration for evicting the cache wh… - #6197

Merged
wchevreuil merged 1 commit into
apache:masterfrom
ragarkar:hbase-28811
Sep 6, 2024
Merged

HBASE-28811 Use region server configuration for evicting the cache wh…#6197
wchevreuil merged 1 commit into
apache:masterfrom
ragarkar:hbase-28811

Conversation

@ragarkar

@ragarkarragarkar commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

…ile unassigning a region

@Apache-HBase

Apache-HBase commented Sep 4, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 3smaster passed
+1 💚compile3m 0smaster passed
+1 💚checkstyle0m 38smaster passed
+1 💚spotbugs1m 37smaster passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile3m 2sthe patch passed
+1 💚javac3m 2sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
-0 ⚠️checkstyle0m 36s/results-checkstyle-hbase-server.txthbase-server: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1 💚spotbugs1m 39sthe patch passed
+1 💚hadoopcheck10m 36sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌spotless0m 38spatch has 63 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
35m 49s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6197
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 35ed6fc47e5a 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c288161
Default JavaEclipse Adoptium-17.0.11+9
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 59smaster passed
+1 💚compile0m 59smaster passed
+1 💚javadoc0m 30smaster passed
+1 💚shadedjars5m 22sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 55sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
+1 💚javadoc0m 29sthe patch passed
+1 💚shadedjars5m 19spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit226m 23shbase-server in the patch passed.
251m 28s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6197
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 0c330eb4e6ca 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / c288161
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/testReport/
Max. process+thread count5956 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 32smaster passed
+1 💚compile4m 1smaster passed
+1 💚checkstyle0m 45smaster passed
+1 💚spotbugs1m 51smaster passed
+1 💚spotless0m 49sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 37sthe patch passed
+1 💚compile3m 57sthe patch passed
+1 💚javac3m 57sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 47sthe patch passed
+1 💚spotbugs1m 58sthe patch passed
+1 💚hadoopcheck11m 41sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 45spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
42m 8s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6197
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux e3bcc601def3 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 016ed65
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count84 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed Sep 4, 2024
View reviewed changes

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add UT for the changed behaviour? Something similar to TestSplitWithCache, but start with a given value for evictOnClose, change it for RSes only, trigger a region close, check the cache:

  1. Set evictOnClose to false:
    UTIL.getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, false);
  2. Start cluster:
    UTIL.startMiniCluster(1);
  3. Change the config for the RS only:
    UTIL.getMiniHBaseCluster().getRegionServer(0).getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, true);
  4. Disable table:
    UTIL.getAdmin().disableTable();
  5. Check blocks got evicted:

Comment thread...ver/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java Outdated
private void closeRegionAfterUpdatingMeta(MasterProcedureEnv env, RegionStateNode regionNode) {
CloseRegionProcedure closeProc =
LOG.debug("Close region: isSplit: {}: evictOnClose: {}", isSplit,
isSplit

@wchevreuilwchevreuilSep 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this log is misleading, we should just pass the evictCache valure for evictOnClose.

Comment thread...ver/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java
@Apache-HBase

Apache-HBase commented Sep 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 30smaster passed
+1 💚compile1m 34smaster passed
+1 💚javadoc0m 47smaster passed
+1 💚shadedjars7m 9sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 45sthe patch passed
+1 💚compile1m 17sthe patch passed
+1 💚javac1m 17sthe patch passed
+1 💚javadoc0m 42sthe patch passed
+1 💚shadedjars6m 3spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit258m 5shbase-server in the patch passed.
289m 43s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6197
Optional Testsjavac javadoc unit compile shadedjars
unameLinux a0ba97b39097 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 016ed65
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/testReport/
Max. process+thread count5336 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 15smaster passed
+1 💚compile3m 6smaster passed
+1 💚checkstyle0m 35smaster passed
+1 💚spotbugs1m 35smaster passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 2sthe patch passed
+1 💚compile3m 6sthe patch passed
+1 💚javac3m 6sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 36sthe patch passed
+1 💚spotbugs1m 40sthe patch passed
+1 💚hadoopcheck11m 43sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 43spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
37m 50s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6197
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 20783683072d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 578ca4d
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 4, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 1smaster passed
+1 💚compile0m 59smaster passed
+1 💚javadoc0m 29smaster passed
+1 💚shadedjars5m 23sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 59sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚javadoc0m 31sthe patch passed
+1 💚shadedjars5m 23spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit231m 10shbase-server in the patch passed.
256m 8s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6197
Optional Testsjavac javadoc unit compile shadedjars
unameLinux fa5d4ce7a853 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 578ca4d
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/testReport/
Max. process+thread count4906 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ragarkar

ragarkar commented Sep 5, 2024

Copy link
Copy Markdown
ContributorAuthor

Can we add UT for the changed behaviour? Something similar to TestSplitWithCache, but start with a given value for evictOnClose, change it for RSes only, trigger a region close, check the cache:

  1. Set evictOnClose to false:
    UTIL.getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, false);
  2. Start cluster:
    UTIL.startMiniCluster(1);
  3. Change the config for the RS only:
    UTIL.getMiniHBaseCluster().getRegionServer(0).getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, true);
  4. Disable table:
    UTIL.getAdmin().disableTable();
  5. Check blocks got evicted:

Added the unit test TestUseRSCacheConfigWhileClosingRegion.java

wchevreuil
wchevreuil requested changes Sep 5, 2024
View reviewed changes

@wchevreuilwchevreuil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UT seems correct, but let's refrain from duplicating code whenever possible. Please move these new tests to TestSplitWithCache, and reuse as much of the code from there.

@ragarkar

ragarkar commented Sep 5, 2024

Copy link
Copy Markdown
ContributorAuthor

The UT seems correct, but let's refrain from duplicating code whenever possible. Please move these new tests to TestSplitWithCache, and reuse as much of the code from there.

Refactored the unit test and renamed TestSplitWithCache to TestCacheEviction. The new test can be used to test other eviction scenarios in the future.

@Apache-HBase

Apache-HBase commented Sep 5, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall2m 52smaster passed
+1 💚compile3m 0smaster passed
+1 💚checkstyle0m 39smaster passed
+1 💚spotbugs1m 34smaster passed
+1 💚spotless0m 46sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
-1 ❌mvninstall1m 42s/patch-mvninstall-root.txtroot in the patch failed.
-1 ❌compile1m 41s/patch-compile-hbase-server.txthbase-server in the patch failed.
-0 ⚠️javac1m 41s/patch-compile-hbase-server.txthbase-server in the patch failed.
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 35sthe patch passed
-1 ❌spotbugs0m 49s/patch-spotbugs-hbase-server.txthbase-server in the patch failed.
-1 ❌hadoopcheck2m 1sThe patch causes 16 errors with Hadoop v3.3.6.
-1 ❌hadoopcheck4m 3sThe patch causes 16 errors with Hadoop v3.4.0.
+1 💚spotless0m 42spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
20m 34s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6197
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 12d3f4abfab2 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 87759d0
Default JavaEclipse Adoptium-17.0.11+9
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheckhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count85 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 5, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 52smaster passed
+1 💚compile1m 11smaster passed
+1 💚javadoc0m 35smaster passed
+1 💚shadedjars6m 50sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
-1 ❌mvninstall2m 11s/patch-mvninstall-root.txtroot in the patch failed.
-1 ❌compile1m 10s/patch-compile-hbase-server.txthbase-server in the patch failed.
-0 ⚠️javac1m 10s/patch-compile-hbase-server.txthbase-server in the patch failed.
+1 💚javadoc0m 34sthe patch passed
-1 ❌shadedjars5m 20spatch has 16 errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit1m 19s/patch-unit-hbase-server.txthbase-server in the patch failed.
24m 55s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6197
Optional Testsjavac javadoc unit compile shadedjars
unameLinux adde2e4b6722 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 87759d0
Default JavaEclipse Adoptium-17.0.11+9
shadedjarshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/testReport/
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 0smaster passed
+1 💚compile2m 58smaster passed
+1 💚checkstyle0m 38smaster passed
+1 💚spotbugs1m 34smaster passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile2m 58sthe patch passed
+1 💚javac2m 58sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 38sthe patch passed
+1 💚spotbugs1m 41sthe patch passed
+1 💚hadoopcheck10m 21sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 11sThe patch does not generate ASF License warnings.
35m 26s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6197
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux ecef815891c3 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8955e45
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 6, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 2smaster passed
+1 💚compile0m 57smaster passed
+1 💚javadoc0m 31smaster passed
+1 💚shadedjars5m 16sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 56sthe patch passed
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
+1 💚javadoc0m 28sthe patch passed
+1 💚shadedjars5m 15spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit236m 11shbase-server in the patch passed.
260m 30s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6197
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 9ffbb5282671 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 8955e45
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/testReport/
Max. process+thread count5388 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
wchevreuil merged commit 888e4dd into apache:masterSep 6, 2024
wchevreuil pushed a commit that referenced this pull request Sep 6, 2024
@ragarkar@wchevreuil
HBASE-28811Use region server configuration for evicting the cache wh…
7bce8e6
…ile unassigning a region (#6197)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
ragarkar added a commit to ragarkar/hbase that referenced this pull request Sep 7, 2024
@ragarkar
HBASE-28811 Use region server configuration for evicting the cache wh…
cb59bee
…ile unassigning a region (apache#6197)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 888e4dd)
@ragarkarragarkar mentioned this pull request Sep 7, 2024
Merged
wchevreuil pushed a commit that referenced this pull request Sep 9, 2024
@ragarkar
HBASE-28811Use region server configuration for evicting the cache wh…
6669e3c
…ile unassigning a region (#6197) (#6217)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 888e4dd)
szucsvillo pushed a commit to szucsvillo/hbase that referenced this pull request Feb 7, 2025
@ragarkarVillő Szűcs
CDPD-74150: Backport HBASE-28811 Use region server configuration for …
c4423a4
…evicting the cache while unassigning a region (apache#6197)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 888e4dd)
stoty pushed a commit to stoty/hbase that referenced this pull request Nov 22, 2025
@ragarkarAmina Dinari
CDPD-74150: Backport HBASE-28811 Use region server configuration for …
57a98da
…evicting the cache while unassigning a region (apache#6197)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 888e4dd)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ragarkar@Apache-HBase@wchevreuil