Skip to content

HBASE-28865 Implement proper string builder for MoveRegionRequest in ProtobufUtil.getShortTextFormat - #6318

Merged
stoty merged 5 commits into
apache:masterfrom
PDavid:HBASE-28865-MoveRegionRequest-toString
Oct 14, 2024
Merged

HBASE-28865 Implement proper string builder for MoveRegionRequest in ProtobufUtil.getShortTextFormat#6318
stoty merged 5 commits into
apache:masterfrom
PDavid:HBASE-28865-MoveRegionRequest-toString

Conversation

@PDavid

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid
PDavid marked this pull request as ready for review September 30, 2024 10:08
@PDavid
PDavidforce-pushed the HBASE-28865-MoveRegionRequest-toString branch from 7b3a71e to ce6146eCompareOctober 1, 2024 09:27
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid
PDavidforce-pushed the HBASE-28865-MoveRegionRequest-toString branch from ce6146e to 1b20c92CompareOctober 8, 2024 16:28
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@Apache-HBase

This comment has been minimized.

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the too long line checkstyle warning.

@PDavid

Copy link
Copy Markdown
ContributorAuthor

Please fix the too long line checkstyle warning.

Thanks. 👍 Strange it did not broke the build. To be honest it was quite hard to find this checkstyle warning. Will fix it. 🤔

@stoty

Copy link
Copy Markdown
Contributor

Thanks.
There is a link from the Yetus report in the PR conversation to the checkstyle report.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 57smaster passed
+1 💚compile0m 24smaster passed
+1 💚javadoc0m 19smaster passed
+1 💚shadedjars5m 20sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 59sthe patch passed
+1 💚compile0m 23sthe patch passed
+1 💚javac0m 23sthe patch passed
+1 💚javadoc0m 19sthe patch passed
+1 💚shadedjars5m 19spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit1m 38shbase-client in the patch passed.
21m 23s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6318
Optional Testsjavac javadoc unit compile shadedjars
unameLinux cc9936ed8dce 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4755420
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/testReport/
Max. process+thread count289 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stoty

Copy link
Copy Markdown
Contributor

Please prepare a backport of this patch for branch-2.
It is needed for committing this on the 2.x branches.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 3smaster passed
+1 💚compile0m 46smaster passed
+1 💚checkstyle0m 16smaster passed
+1 💚spotbugs0m 41smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile0m 46sthe patch passed
-0 ⚠️javac0m 46s/results-compile-javac-hbase-client.txthbase-client generated 1 new + 102 unchanged - 1 fixed = 103 total (was 103)
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 15shbase-client: The patch generated 0 new + 18 unchanged - 1 fixed = 18 total (was 19)
+1 💚spotbugs0m 48sthe patch passed
+1 💚hadoopcheck12m 0sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 51spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
31m 28s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6318
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux cfbfa67c3397 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 4755420
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-client U: hbase-client
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6318/6/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@PDavid

Copy link
Copy Markdown
ContributorAuthor

Please prepare a backport of this patch for branch-2. It is needed for committing this on the 2.x branches.

Thanks, the backport to branch-2 is prepared here:
#6362

@stoty
stoty merged commit f2e52f3 into apache:masterOct 14, 2024
stoty pushed a commit that referenced this pull request Oct 14, 2024
…ProtobufUtil.getShortTextFormat (#6318)
Signed-off-by: Istvan Toth <stoty@apache.org>
(cherry picked from commit f2e52f3)
@PDavid
PDavid deleted the HBASE-28865-MoveRegionRequest-toString branch October 15, 2024 07:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@PDavid@Apache-HBase@stoty