Skip to content

HBASE-28346: Expose checkQuota to Coprocessor Endpoints (#6066) (addendum) - #6350

Merged
ndimiduk merged 1 commit into
apache:branch-2.6from
ndimiduk:28346-addendum-branch-2.6
Oct 8, 2024
Merged

HBASE-28346: Expose checkQuota to Coprocessor Endpoints (#6066) (addendum)#6350
ndimiduk merged 1 commit into
apache:branch-2.6from
ndimiduk:28346-addendum-branch-2.6

Conversation

@ndimiduk

@ndimidukndimiduk commented Oct 7, 2024

Copy link
Copy Markdown
Member

Add default implementations of the new methods so that a custom implementation of RegionCoprocessorEnvironment will not fail to compile after upgrade. This PR introduces default interface implementations for the new methods. This is intended to address the build failures in Phoenix mentioned during the RC0 VOTE thread. By my read of the policy outlined in our book, we need to apply this patch to branch-2 and branch-2.6. PTAL. @stoty@NihalJain@Apache9@apurtell@charlesconnell

@ndimiduk
HBASE-28346: Expose checkQuota to Coprocessor Endpoints (apache#6066)…
e431d84
… (addendum)
Add default implementations of the new methods so that a custom implementation of
RegionCoprocessorEnvironment will not fail to compile after upgrade.
@Apache-HBase

Apache-HBase commented Oct 7, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 45sbranch-2.6 passed
+1 💚compile3m 6sbranch-2.6 passed
+1 💚checkstyle0m 42sbranch-2.6 passed
+1 💚spotbugs1m 51sbranch-2.6 passed
+1 💚spotless0m 50sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall3m 32sthe patch passed
+1 💚compile3m 18sthe patch passed
+1 💚javac3m 18sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 39sthe patch passed
+1 💚spotbugs1m 54sthe patch passed
+1 💚hadoopcheck16m 15sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 43spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
39m 16s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6350
JIRA IssueHBASE-28346
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 756e20fc562f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / e431d84
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 7, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall3m 13sbranch-2.6 passed
+1 💚compile0m 55sbranch-2.6 passed
+1 💚javadoc0m 27sbranch-2.6 passed
+1 💚shadedjars5m 52sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 2sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚javadoc0m 25sthe patch passed
+1 💚shadedjars5m 45spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit200m 38shbase-server in the patch passed.
226m 37s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6350
JIRA IssueHBASE-28346
Optional Testsjavac javadoc unit compile shadedjars
unameLinux bbe66cd8fbc0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / e431d84
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/testReport/
Max. process+thread count4505 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 7, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 21sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall2m 53sbranch-2.6 passed
+1 💚compile0m 44sbranch-2.6 passed
+1 💚javadoc0m 27sbranch-2.6 passed
+1 💚shadedjars4m 54sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 27sthe patch passed
+1 💚compile0m 45sthe patch passed
+1 💚javac0m 45sthe patch passed
+1 💚javadoc0m 26sthe patch passed
+1 💚shadedjars5m 45spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit221m 50shbase-server in the patch passed.
245m 18s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6350
JIRA IssueHBASE-28346
Optional Testsjavac javadoc unit compile shadedjars
unameLinux ff201783b6ce 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / e431d84
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/testReport/
Max. process+thread count4608 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 7, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 55sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚mvninstall5m 16sbranch-2.6 passed
+1 💚compile1m 26sbranch-2.6 passed
+1 💚javadoc0m 44sbranch-2.6 passed
+1 💚shadedjars8m 0sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall4m 35sthe patch passed
+1 💚compile1m 36sthe patch passed
+1 💚javac1m 36sthe patch passed
+1 💚javadoc0m 48sthe patch passed
+1 💚shadedjars8m 4spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit230m 19shbase-server in the patch passed.
266m 28s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6350
JIRA IssueHBASE-28346
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 26ff7209c065 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.6 / e431d84
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/testReport/
Max. process+thread count4473 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6350/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit 8dbd7a8 into apache:branch-2.6Oct 8, 2024
@ndimiduk
ndimiduk deleted the 28346-addendum-branch-2.6 branch October 8, 2024 09:59
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Oct 8, 2024
@ndimiduk
HBASE-28346: Expose checkQuota to Coprocessor Endpoints (apache#6066)…
f13d423
… (addendum) (apache#6350)
Add default implementations of the new methods so that a custom implementation of
RegionCoprocessorEnvironment will not fail to compile after upgrade.
Signed-off-by: Nihal Jain <nihaljain@apache.org>
ndimiduk added a commit that referenced this pull request Oct 8, 2024
@ndimiduk
HBASE-28346: Expose checkQuota to Coprocessor Endpoints (#6066) (adde…
7ffba05
…ndum) (#6350)
Add default implementations of the new methods so that a custom implementation of
RegionCoprocessorEnvironment will not fail to compile after upgrade.
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NihalJainNihalJainNihalJain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@NihalJain