Skip to content

HBASE-28900: Avoid resetting the bucket cache during recovery from persistence. (#6360) - #6365

Merged
wchevreuil merged 1 commit into
apache:branch-2from
janardhanrh:branch-2-for-HBASE-28900
Oct 15, 2024
Merged

HBASE-28900: Avoid resetting the bucket cache during recovery from persistence. (#6360)#6365
wchevreuil merged 1 commit into
apache:branch-2from
janardhanrh:branch-2-for-HBASE-28900

Conversation

@jhungund

@jhungundjhungund commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Backport the fix of HBASE-28900 to branch-2.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@jhungund
HBASE-28900: Avoid resetting the bucket cache during recovery from pe…
968aa56
…rsistence. (apache#6360)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Change-Id: If7e7a76723cf7d2d6e8c9e2ce0aeccfdba81c0bb
@jhungund
jhungundforce-pushed the branch-2-for-HBASE-28900 branch from 2f750ad to 968aa56CompareOctober 15, 2024 03:13
@Apache-HBase

Apache-HBase commented Oct 15, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 0sDocker mode activated.
-1 ❌docker0m 6sDocker failed to build run-specific yetus/hbase:tp-6445}.
SubsystemReport/Notes
GITHUB PR#6365
JIRA IssueHBASE-28900
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/console
versionsgit=2.25.1
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 15, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚mvninstall4m 34sbranch-2 passed
+1 💚compile4m 0sbranch-2 passed
+1 💚checkstyle0m 42sbranch-2 passed
+1 💚spotbugs1m 56sbranch-2 passed
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall4m 22sthe patch passed
+1 💚compile3m 46sthe patch passed
+1 💚javac3m 46sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 45shbase-server: The patch generated 0 new + 25 unchanged - 1 fixed = 25 total (was 26)
+1 💚spotbugs2m 0sthe patch passed
+1 💚hadoopcheck23m 50sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless0m 55spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
50m 12s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6365
JIRA IssueHBASE-28900
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux e2ee75349da3 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 968aa56
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 15, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 25sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall4m 36sbranch-2 passed
+1 💚compile1m 19sbranch-2 passed
+1 💚javadoc0m 35sbranch-2 passed
+1 💚shadedjars6m 47sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall4m 22sthe patch passed
+1 💚compile1m 11sthe patch passed
+1 💚javac1m 11sthe patch passed
-0 ⚠️javadoc0m 33s/results-javadoc-javadoc-hbase-server.txthbase-server generated 7 new + 44 unchanged - 0 fixed = 51 total (was 44)
+1 💚shadedjars6m 33spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit214m 53shbase-server in the patch passed.
245m 57s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6365
JIRA IssueHBASE-28900
Optional Testsjavac javadoc unit compile shadedjars
unameLinux b2f63a019c06 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 968aa56
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/testReport/
Max. process+thread count4954 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 15, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚mvninstall2m 39sbranch-2 passed
+1 💚compile0m 41sbranch-2 passed
+1 💚javadoc0m 26sbranch-2 passed
+1 💚shadedjars5m 15sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 26sthe patch passed
+1 💚compile0m 41sthe patch passed
+1 💚javac0m 41sthe patch passed
-0 ⚠️javadoc0m 23s/results-javadoc-javadoc-hbase-server.txthbase-server generated 4 new + 21 unchanged - 0 fixed = 25 total (was 21)
+1 💚shadedjars5m 13spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit233m 3s/patch-unit-hbase-server.txthbase-server in the patch failed.
255m 57s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6365
JIRA IssueHBASE-28900
Optional Testsjavac javadoc unit compile shadedjars
unameLinux 03c4dbb51064 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 968aa56
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/testReport/
Max. process+thread count4294 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6365/2/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
wchevreuil merged commit 47536f4 into apache:branch-2Oct 15, 2024
wchevreuil pushed a commit that referenced this pull request Oct 15, 2024
@jhungund@wchevreuil
HBASE-28900: Avoid resetting the bucket cache during recovery from pe…
15e4705
…rsistence. (#6360) (#6365)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhungund@Apache-HBase@wchevreuil