Skip to content

HBASE-28924 Create the start time right before creating the reader to calculate elapsedTime in testPrefetchWithDelay - #6371

Merged
apurtell merged 1 commit into
apache:masterfrom
gvprathyusha6:HBASE-28924
Oct 18, 2024
Merged

HBASE-28924 Create the start time right before creating the reader to calculate elapsedTime in testPrefetchWithDelay#6371
apurtell merged 1 commit into
apache:masterfrom
gvprathyusha6:HBASE-28924

Conversation

@gvprathyusha6

@gvprathyusha6gvprathyusha6 commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

This test currently fails intermittently in master branch, as startime is post reader creation
Elapsed time is sometimes 25074ms and sometimes 24994ms (but delay is 25000ms) since starttime was calculated after reader creation

@gvprathyusha6gvprathyusha6 changed the title HBASE-28924 Create the start time right before creating the reader to calculate e…HBASE-28924 Create the start time right before creating the reader to calculate elapsedTime in testPrefetchWithDelayOct 17, 2024
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 17sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall3m 7smaster passed
+1 💚compile2m 58smaster passed
+1 💚checkstyle0m 39smaster passed
-1 ❌spotbugs1m 37s/branch-spotbugs-hbase-server-warnings.htmlhbase-server in master has 1 extant spotbugs warnings.
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 54sthe patch passed
+1 💚compile3m 3sthe patch passed
+1 💚javac3m 3sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 37sthe patch passed
+1 💚spotbugs1m 43sthe patch passed
+1 💚hadoopcheck10m 32sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 44spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 12sThe patch does not generate ASF License warnings.
35m 42s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6371
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 4b3b3dc2df97 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3994500
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count84 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@apurtell

apurtell commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

@gvprathyusha6 Approved. The spotbugs warning is unrelated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 14smaster passed
+1 💚compile0m 56smaster passed
+1 💚javadoc0m 28smaster passed
+1 💚shadedjars5m 45sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall3m 4sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚javadoc0m 27sthe patch passed
+1 💚shadedjars5m 41spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌unit213m 26s/patch-unit-hbase-server.txthbase-server in the patch failed.
239m 7s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6371
Optional Testsjavac javadoc unit compile shadedjars
unameLinux ce932b5d984f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 3994500
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/testReport/
Max. process+thread count5285 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6371/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain

Copy link
Copy Markdown
Contributor

The spotbugs warning is unrelated.

Raised HBASE-28927 for spotbugs, introduced in HBASE-28432. Sorry for the noise !

@apurtell
apurtell merged commit 15e0905 into apache:masterOct 18, 2024
asfgit pushed a commit that referenced this pull request Oct 18, 2024
…lapsedTime in testPrefetchWithDelay (#6371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Oct 18, 2024
…lapsedTime in testPrefetchWithDelay (#6371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@NihalJain

Copy link
Copy Markdown
Contributor

Hi @apurtell just a heads up. Seems JIRA# somehow got lost during merge of this PR

apurtell pushed a commit to apurtell/hbase that referenced this pull request Oct 22, 2024
…lapsedTime in testPrefetchWithDelay (apache#6371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Oct 22, 2024
…lapsedTime in testPrefetchWithDelay (apache#6371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Oct 22, 2024
…culate elapsedTime in testPrefetchWithDelay (#6371)"
This reverts commit 7154ca4.
asfgit pushed a commit that referenced this pull request Oct 22, 2024
…6371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Oct 22, 2024
…culate elapsedTime in testPrefetchWithDelay (#6371)"
This reverts commit 2b2996d.
asfgit pushed a commit that referenced this pull request Oct 22, 2024
…6371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Oct 22, 2024
…culate elapsedTime in testPrefetchWithDelay (#6371)"
This reverts commit 15e0905.
asfgit pushed a commit that referenced this pull request Oct 22, 2024
…6371)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
stoty pushed a commit to stoty/hbase that referenced this pull request Nov 22, 2025
…ails intermittently (apache#6371) (apache#600)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Co-authored-by: gvprathyusha6 <70918688+gvprathyusha6@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gvprathyusha6@Apache-HBase@apurtell@NihalJain@wchevreuil