Skip to content

HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCache.freespace - #6373

Merged
wchevreuil merged 3 commits into
apache:masterfrom
wchevreuil:HBASE-28923-master
Oct 30, 2024
Merged

HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCache.freespace#6373
wchevreuil merged 3 commits into
apache:masterfrom
wchevreuil:HBASE-28923-master

Conversation

@wchevreuil

@wchevreuilwchevreuil commented Oct 18, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@wchevreuil
HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCach…
41a9744
…e.freespace
Change-Id: Id3c9c7d3fdbdd2ca21d55b53d1743fe31a77d4ea
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@wchevreuil
pruning some lines due to checkstyles
95f7c96
Change-Id: Id96f80df1266ae8251ae881fcef2b183c5c01a64
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
vinayakphegde
vinayakphegde reviewed Oct 29, 2024
View reviewed changes

@vinayakphegdevinayakphegde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! added one comment. not very important though!

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java Outdated
private static final boolean STRONG_REF_DEFAULT = false;

/** The cache age of blocks to check if the related file is present on any online regions. */
static final String BLOCK_ORPHAN_GRACE_PERIOD = "hbase.bucketcache.block.orphan.evictgraceperiod";

@vinayakphegdevinayakphegdeOct 29, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Since this configuration is in seconds, can we define it directly in the config, as we usually do? Something like "hbase.bucketcache.block.orphan.evictgraceperiod.seconds".

Kota-SH
Kota-SH approved these changes Oct 30, 2024
View reviewed changes

@Kota-SHKota-SH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wchevreuil
addressing constant name suggestions
5e39188
Change-Id: I34f6f19f09343423122575ea40e79e1ef19017b3
@wchevreuil
wchevreuil merged commit d2c0350 into apache:masterOct 30, 2024
wchevreuil added a commit that referenced this pull request Oct 30, 2024
@wchevreuil
HBASE-28923Prioritize "orphan" blocks for eviction inside BucketCach…
f7558f7
…e.freespace (#6373)
Signed-off-by: Ankit Singhal <ankit@apache.org>
Reviewed by: Kota-SH <shanmukhaharipriya@gmail.com>
Reviewed by: Vinayak Hegde <vinayakph123@gmail.com>
@Apache-HBase

Apache-HBase commented Oct 30, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+1 💚mvninstall2m 58smaster passed
+1 💚compile2m 57smaster passed
+1 💚checkstyle0m 38smaster passed
+1 💚spotbugs1m 36smaster passed
+1 💚spotless0m 45sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚mvninstall2m 49sthe patch passed
+1 💚compile3m 19sthe patch passed
+1 💚javac3m 19sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle0m 50sthe patch passed
+1 💚spotbugs2m 14sthe patch passed
+1 💚hadoopcheck12m 8sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 52spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
38m 33s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6373
Optional Testsdupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
unameLinux 433849435f21 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e39188
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count83 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil added a commit to wchevreuil/hbase that referenced this pull request Oct 30, 2024
@wchevreuil
HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCach…
54bb187
…e.freespace (apache#6373)
Signed-off-by: Ankit Singhal <ankit@apache.org>
Reviewed by: Kota-SH <shanmukhaharipriya@gmail.com>
Reviewed by: Vinayak Hegde <vinayakph123@gmail.com>
Change-Id: Ide3eb5573dc2ef16e60435181a688dbfa6b6177a
@Apache-HBase

Apache-HBase commented Oct 30, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 36smaster passed
+1 💚compile1m 1smaster passed
+1 💚javadoc0m 37smaster passed
+1 💚shadedjars5m 57sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚mvninstall2m 51sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 57sthe patch passed
+1 💚javadoc0m 30sthe patch passed
+1 💚shadedjars5m 20spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit224m 9shbase-server in the patch passed.
250m 25s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6373
Optional Testsjavac javadoc unit compile shadedjars
unameLinux ef782f6a8bc5 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 5e39188
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/testReport/
Max. process+thread count4568 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil added a commit that referenced this pull request Oct 31, 2024
@wchevreuil
HBASE-28923Prioritize "orphan" blocks for eviction inside BucketCach…
ec9073c
…e.freespace (#6373) (#6416)
Reviewed by: Kota-SH <shanmukhaharipriya@gmail.com>
Reviewed by: Vinayak Hegde <vinayakph123@gmail.com>
Signed-off-by: Ankit Singhal <ankit@apache.org>
wchevreuil added a commit that referenced this pull request Oct 31, 2024
@wchevreuil
HBASE-28923Prioritize "orphan" blocks for eviction inside BucketCach…
037c4d8
…e.freespace (#6373) (#6416)
Reviewed by: Kota-SH <shanmukhaharipriya@gmail.com>
Reviewed by: Vinayak Hegde <vinayakph123@gmail.com>
Signed-off-by: Ankit Singhal <ankit@apache.org>
Change-Id: Ic1b4cb24b2f395488cd76bf34538f725e9fd1826
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitsinghalankitsinghalankitsinghal approved these changes
@anmolnaranmolnarAwaiting requested review from anmolnar
@petersomogyipetersomogyiAwaiting requested review from petersomogyi
@taklwutaklwuAwaiting requested review from taklwu
+2 more reviewers
@vinayakphegdevinayakphegdevinayakphegde left review comments
@Kota-SHKota-SHKota-SH approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wchevreuil@Apache-HBase@ankitsinghal@Kota-SH@vinayakphegde