Skip to content

HBASE-28921 Skip bundling hbase-webapps folder in jars (#6368) - #6377

Closed
NihalJain wants to merge 1 commit into
apache:branch-2from
NihalJain:HBASE-28921_branch-2
Closed

HBASE-28921 Skip bundling hbase-webapps folder in jars (#6368)#6377
NihalJain wants to merge 1 commit into
apache:branch-2from
NihalJain:HBASE-28921_branch-2

Conversation

@NihalJain

@NihalJainNihalJain commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

Backports #6368

@NihalJain
HBASE-28921 Skip bundling hbase-webapps folder in jars (apache#6368)
6cdd046
We are bundling all webapp resources in hbase-server, hbase-thrift, hbase-rest and transitively to hbase-shaded-mapreduce jar. This can be an issue, say if any of the Js projects used by hbase are vulnerable, security scan tools like sonatype start flagging the jars too as vulnerable since they contain vulnerable code.
With this JIRA, we skip bundling static webapp resources in our jars.
Signed-off-by: Istvan Toth <stoty@apache.org>
Reviewed-by: Dávid Paksy <paksyd@cloudera.com>
(cherry picked from commit 8366304)
@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Oct 21, 2024
@Apache-HBase

Apache-HBase commented Oct 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 57sbranch-2 passed
+1 💚compile6m 1sbranch-2 passed
+1 💚spotless1m 18sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 19sthe patch passed
+1 💚compile5m 31sthe patch passed
+1 💚javac5m 31sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck20m 54sPatch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚spotless1m 10spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 39sThe patch does not generate ASF License warnings.
49m 25s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6377
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
unameLinux 4cfc4c0305e1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6cdd046
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 10sbranch-2 passed
+1 💚compile1m 40sbranch-2 passed
+1 💚javadoc0m 56sbranch-2 passed
+1 💚shadedjars5m 46sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 1sthe patch passed
+1 💚compile1m 43sthe patch passed
+1 💚javac1m 43sthe patch passed
+1 💚javadoc0m 56sthe patch passed
+1 💚shadedjars5m 48spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit203m 2shbase-server in the patch passed.
+1 💚unit6m 49shbase-thrift in the patch passed.
+1 💚unit3m 40shbase-rest in the patch passed.
242m 42s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6377
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f86083635c7f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6cdd046
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/testReport/
Max. process+thread count4442 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 43sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 32sbranch-2 passed
+1 💚compile1m 19sbranch-2 passed
+1 💚javadoc1m 1sbranch-2 passed
+1 💚shadedjars5m 18sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 20sthe patch passed
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
+1 💚javadoc0m 59sthe patch passed
+1 💚shadedjars5m 16spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit217m 54shbase-server in the patch passed.
+1 💚unit7m 16shbase-thrift in the patch passed.
+1 💚unit4m 15shbase-rest in the patch passed.
255m 46s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6377
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 80ef3f9dcf86 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6cdd046
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/testReport/
Max. process+thread count4208 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 56sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall4m 11sbranch-2 passed
+1 💚compile2m 18sbranch-2 passed
+1 💚javadoc1m 7sbranch-2 passed
+1 💚shadedjars8m 1sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for patch
+1 💚mvninstall4m 51sthe patch passed
+1 💚compile2m 51sthe patch passed
+1 💚javac2m 51sthe patch passed
+1 💚javadoc1m 43sthe patch passed
+1 💚shadedjars6m 33spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit231m 43shbase-server in the patch passed.
+1 💚unit7m 19shbase-thrift in the patch passed.
+1 💚unit4m 15shbase-rest in the patch passed.
281m 58s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6377
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ec7f39e53a64 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6cdd046
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/testReport/
Max. process+thread count4437 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6377/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
NihalJain marked this pull request as draft October 21, 2024 22:06
@NihalJain

NihalJain commented Oct 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Stale

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NihalJain@Apache-HBase