Skip to content

HBASE-28921 Skip bundling hbase-webapps folder in jars (#6368) - #6379

Closed
NihalJain wants to merge 1 commit into
apache:branch-2.5from
NihalJain:HBASE-28921_branch-2.5
Closed

HBASE-28921 Skip bundling hbase-webapps folder in jars (#6368)#6379
NihalJain wants to merge 1 commit into
apache:branch-2.5from
NihalJain:HBASE-28921_branch-2.5

Conversation

@NihalJain

@NihalJainNihalJain commented Oct 21, 2024

Copy link
Copy Markdown
Contributor

Backports #6368

@NihalJain
HBASE-28921 Skip bundling hbase-webapps folder in jars (apache#6368)
90ab638
We are bundling all webapp resources in hbase-server, hbase-thrift, hbase-rest and transitively to hbase-shaded-mapreduce jar. This can be an issue, say if any of the Js projects used by hbase are vulnerable, security scan tools like sonatype start flagging the jars too as vulnerable since they contain vulnerable code.
With this JIRA, we skip bundling static webapp resources in our jars.
Signed-off-by: Istvan Toth <stoty@apache.org>
Reviewed-by: Dávid Paksy <paksyd@cloudera.com>
(cherry picked from commit 8366304)
@NihalJainNihalJain added the backport This PR is a back port of some issue or issues already committed to master label Oct 21, 2024
@Apache-HBase

Apache-HBase commented Oct 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall2m 50sbranch-2.5 passed
+1 💚compile3m 41sbranch-2.5 passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 46sthe patch passed
+1 💚compile3m 38sthe patch passed
+1 💚javac3m 38sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚xmllint0m 0sNo new issues.
+1 💚hadoopcheck19m 18sPatch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚spotless0m 43spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
37m 12s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6379
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
unameLinux 199ca130d7b1 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 90ab638
Default JavaEclipse Adoptium-11.0.23+9
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/console
versionsgit=2.34.1 maven=3.9.8 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 14sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 43sbranch-2.5 passed
+1 💚compile2m 8sbranch-2.5 passed
+1 💚javadoc1m 10sbranch-2.5 passed
+1 💚shadedjars5m 30sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall2m 52sthe patch passed
+1 💚compile2m 24sthe patch passed
+1 💚javac2m 24sthe patch passed
+1 💚javadoc1m 14sthe patch passed
+1 💚shadedjars6m 2spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit224m 6shbase-server in the patch passed.
+1 💚unit8m 27shbase-thrift in the patch passed.
+1 💚unit3m 50shbase-rest in the patch passed.
268m 30s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6379
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c2e08c5fadb3 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 90ab638
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/testReport/
Max. process+thread count3968 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 47sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall2m 51sbranch-2.5 passed
+1 💚compile1m 44sbranch-2.5 passed
+1 💚javadoc1m 22sbranch-2.5 passed
+1 💚shadedjars6m 33sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 53sthe patch passed
+1 💚compile1m 37sthe patch passed
+1 💚javac1m 37sthe patch passed
+1 💚javadoc1m 13sthe patch passed
+1 💚shadedjars5m 23spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit234m 40shbase-server in the patch passed.
+1 💚unit8m 50shbase-thrift in the patch passed.
+1 💚unit3m 44shbase-rest in the patch passed.
276m 54s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#6379
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4ce300ec3d7b 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 90ab638
Default JavaTemurin-1.8.0_412-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/testReport/
Max. process+thread count3931 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 21, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec1m 2sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2.5 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 9sbranch-2.5 passed
+1 💚compile2m 6sbranch-2.5 passed
+1 💚javadoc1m 16sbranch-2.5 passed
+1 💚shadedjars6m 45sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 26sthe patch passed
+1 💚compile1m 49sthe patch passed
+1 💚javac1m 49sthe patch passed
+1 💚javadoc1m 1sthe patch passed
+1 💚shadedjars6m 23spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit254m 41shbase-server in the patch passed.
+1 💚unit7m 53shbase-thrift in the patch passed.
+1 💚unit3m 32shbase-rest in the patch passed.
299m 33s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#6379
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 673a35b9be9e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2.5 / 90ab638
Default JavaEclipse Adoptium-11.0.23+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/testReport/
Max. process+thread count3770 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6379/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
NihalJain marked this pull request as draft October 21, 2024 22:07
@NihalJain

NihalJain commented Oct 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Stale

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backportThis PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NihalJain@Apache-HBase