Skip to content

HBASE-23046 Remove compatibility case from truncate command - #638

Merged
petersomogyi merged 2 commits into
apache:masterfrom
petersomogyi:HBASE-23046
Sep 19, 2019
Merged

HBASE-23046 Remove compatibility case from truncate command#638
petersomogyi merged 2 commits into
apache:masterfrom
petersomogyi:HBASE-23046

Conversation

@petersomogyi

Copy link
Copy Markdown
Contributor

No description provided.

@busbeybusbey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a release note that the admin won't work when talking to a pre-1.0 cluster? I have a hard time believing admin in e.g. branch-2 worked with a pre-1.0 cluster before this change.

@petersomogyi

Copy link
Copy Markdown
ContributorAuthor

I don't think upgrade works from pre-1.0 to 2+ cluster. I can add a release note to the Jira if you think it's needed.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
💙reexec0m 36sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚mvninstall8m 1smaster passed
💚javadoc0m 17smaster passed
_ Patch Compile Tests _
💚mvninstall6m 23sthe patch passed
💔rubocop0m 14sThe patch generated 4 new + 436 unchanged - 14 fixed = 440 total (was 450)
💚whitespace0m 0sThe patch has no whitespace issues.
💚javadoc0m 14sthe patch passed
_ Other Tests _
💚unit7m 6shbase-shell in the patch passed.
💚asflicense0m 14sThe patch does not generate ASF License warnings.
24m 24s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/1/artifact/out/Dockerfile
GITHUB PR#638
Optional Testsdupname asflicense javac javadoc unit rubocop
unameLinux 23f37109836c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-638/out/precommit/personality/provided.sh
git revisionmaster / 25bcc91
Default Java1.8.0_181
rubocophttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/1/artifact/out/diff-patch-rubocop.txt
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/1/testReport/
Max. process+thread count2625 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/1/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
💙reexec0m 32sDocker mode activated.
_ Prechecks _
💚dupname0m 0sNo case conflicting files found.
💚@author0m 0sThe patch does not contain any @author tags.
💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚mvninstall6m 31smaster passed
💚javadoc0m 18smaster passed
_ Patch Compile Tests _
💚mvninstall5m 56sthe patch passed
💚rubocop0m 18sThe patch generated 0 new + 419 unchanged - 31 fixed = 419 total (was 450)
💚whitespace0m 0sThe patch has no whitespace issues.
💚javadoc0m 15sthe patch passed
_ Other Tests _
💚unit8m 6shbase-shell in the patch passed.
💚asflicense0m 13sThe patch does not generate ASF License warnings.
23m 16s
SubsystemReport/Notes
DockerClient=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/2/artifact/out/Dockerfile
GITHUB PR#638
Optional Testsdupname asflicense javac javadoc unit rubocop
unameLinux 760389f003dc 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build toolmaven
Personality/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-638/out/precommit/personality/provided.sh
git revisionmaster / 25bcc91
Default Java1.8.0_181
Test Resultshttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/2/testReport/
Max. process+thread count2759 (vs. ulimit of 10000)
modulesC: hbase-shell U: hbase-shell
Console outputhttps://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/2/console
versionsgit=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered byApache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi
petersomogyi merged commit 08b82c5 into apache:masterSep 19, 2019
asfgit pushed a commit that referenced this pull request Sep 19, 2019
Signed-off-by: Sean Busbey <busbey@apache.org>
@petersomogyi
petersomogyi deleted the HBASE-23046 branch September 23, 2019 07:19
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
Author: Peter Somogyi
Reason: Bug
Ref: CDH-82052
Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit 08b82c5)
Change-Id: I9a748ea60a2e6e1b3bb17c52892909b694bab07e
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@petersomogyi@Apache-HBase@busbey