Revert "HBASE-28921 Skip bundling hbase-webapps folder in jars"

[NihalJain]

Reverts #6368

I see some test failures during debugging some other code. Apparently we use hbase-webapps folder to create an instance hbase local cluster for tests and the folder needs to be present in classpath. I am seeing following since we have removed hbase-webapps from hbase-server jar and hence tests in other modules can't find it in classpath now:

Caused by: java.io.FileNotFoundException: hbase-webapps/master not found in CLASSPATH
at org.apache.hadoop.hbase.http.HttpServer.getWebAppsPath(HttpServer.java:1086)
at org.apache.hadoop.hbase.http.HttpServer.getWebAppsPath(HttpServer.java:1073)
at org.apache.hadoop.hbase.http.HttpServer.<init>(HttpServer.java:589)
at org.apache.hadoop.hbase.http.HttpServer$Builder.build(HttpServer.java:431)
at org.apache.hadoop.hbase.http.InfoServer.<init>(InfoServer.java:92)
at org.apache.hadoop.hbase.HBaseServerBase.putUpWebUI(HBaseServerBase.java:345)
at org.apache.hadoop.hbase.HBaseServerBase.<init>(HBaseServerBase.java:307)
at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:511)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:124)
... 40 more

Fix is to include hbase-webapps in classpath for each impacted module's test resources. Reverting this for now to unblock any new PRs which may get impacted due to this change. Will raise another PR to handle the above case along with current change.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s		master passed
+1 💚	compile	4m 23s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 0s		the patch passed
+1 💚	compile	4m 28s		the patch passed
+1 💚	javac	4m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	11m 40s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 25s		The patch does not generate ASF License warnings.
		36m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6382/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6382
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname	Linux 39122720321d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / ece0fdb
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	87 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6382/1/console
versions	git=2.34.1 maven=3.9.8 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s		master passed
+1 💚	compile	1m 36s		master passed
+1 💚	javadoc	1m 11s		master passed
+1 💚	shadedjars	5m 29s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	1m 36s		the patch passed
+1 💚	javac	1m 36s		the patch passed
+1 💚	javadoc	1m 9s		the patch passed
+1 💚	shadedjars	5m 26s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	209m 21s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	6m 56s		hbase-thrift in the patch passed.
+1 💚	unit	3m 50s		hbase-rest in the patch passed.
		248m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6382/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6382
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4bea67a25296 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / ece0fdb
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6382/1/testReport/
Max. process+thread count	4865 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6382/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.