HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-diagnostics with HBASE-28432

[NihalJain]

• Backports HBASE-28927 Fix spotbugs issues introduced by refactoring to hbase-di… #6384

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-3 Compile Tests _
+0 🆗	mvndep	0m 8s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 0s		branch-3 passed
+1 💚	compile	3m 23s		branch-3 passed
+1 💚	checkstyle	0m 50s		branch-3 passed
-1 ❌	spotbugs	0m 32s	/branch-spotbugs-hbase-diagnostics-warnings.html	hbase-diagnostics in branch-3 has 12 extant spotbugs warnings.
-1 ❌	spotbugs	1m 30s	/branch-spotbugs-hbase-server-warnings.html	hbase-server in branch-3 has 1 extant spotbugs warnings.
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 52s		the patch passed
+1 💚	compile	3m 21s		the patch passed
-0 ⚠️	javac	0m 27s	/results-compile-javac-hbase-diagnostics.txt	hbase-diagnostics generated 1 new + 55 unchanged - 5 fixed = 56 total (was 60)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 36s		The patch passed checkstyle in hbase-server
+1 💚	checkstyle	0m 10s		hbase-diagnostics: The patch generated 0 new + 43 unchanged - 1 fixed = 43 total (was 44)
+1 💚	spotbugs	1m 39s		hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	0m 36s		hbase-diagnostics generated 0 new + 0 unchanged - 12 fixed = 0 total (was 12)
+1 💚	hadoopcheck	10m 19s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		38m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6387/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6387
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux eebf4f742bc2 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-3 / 22c2047
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server hbase-diagnostics U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6387/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-3 Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 16s		branch-3 passed
+1 💚	compile	1m 16s		branch-3 passed
+1 💚	javadoc	0m 42s		branch-3 passed
+1 💚	shadedjars	5m 48s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	1m 20s		the patch passed
+1 💚	javac	1m 20s		the patch passed
+1 💚	javadoc	0m 45s		the patch passed
+1 💚	shadedjars	7m 45s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	225m 45s		hbase-server in the patch passed.
+1 💚	unit	5m 55s		hbase-diagnostics in the patch passed.
		261m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6387/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6387
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 6b27fe526d27 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-3 / 22c2047
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6387/1/testReport/
Max. process+thread count	5057 (vs. ulimit of 30000)
modules	C: hbase-server hbase-diagnostics U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6387/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.