HBASE-28937 Should check if compaction are needed after flushing

[guluo2016]

Details see: HBASE-28937

[Apache9]

We still use this to flush regions?

IIRC we have introduced a FlushTableProcedure at mastert side and use the proc-v2 framework to trigger flush table operation?

[guluo2016]

Yes.

• When flush procdure is enabled, the flush operation will ultimately execute FlushRegionCallable.doCall()
• When flush procedure is disabled, the flush operation will ultimately execute FlushTableSubprocedure.RegionFlushTask.call()

[guluo2016]

The related tests failed, i will update it later.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	4m 35s		master passed
+1 💚	compile	3m 58s		master passed
+1 💚	checkstyle	0m 42s		master passed
+1 💚	spotbugs	1m 53s		master passed
+1 💚	spotless	0m 51s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 1s		the patch passed
+1 💚	compile	3m 44s		the patch passed
+1 💚	javac	3m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 44s		the patch passed
+1 💚	spotbugs	1m 55s		the patch passed
+1 💚	hadoopcheck	16m 32s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	1m 3s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		50m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6396/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6396
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 6c21826c1f22 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 7e8ff11
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6396/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 0s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	4m 32s		master passed
+1 💚	compile	1m 21s		master passed
+1 💚	javadoc	0m 34s		master passed
+1 💚	shadedjars	6m 36s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 55s		the patch passed
+1 💚	compile	1m 11s		the patch passed
+1 💚	javac	1m 11s		the patch passed
+1 💚	javadoc	0m 36s		the patch passed
+1 💚	shadedjars	6m 26s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	229m 9s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		259m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6396/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6396
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 94ab4a98417d 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 7e8ff11
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6396/3/testReport/
Max. process+thread count	4714 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6396/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[guluo2016]

Maybe my idea is wrong.
After manually triggering flush, no need for HBase to check internally whether compaction is required , because there are threads within HBase that periodically check it.