Skip to content

HBASE-28942 Purge all netty 3 dependencies by default - #6406

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28942
Oct 30, 2024
Merged

HBASE-28942 Purge all netty 3 dependencies by default#6406
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-28942

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Oct 28, 2024
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗codespell0m 0scodespell was not available.
+0 🆗detsecrets0m 0sdetect-secrets was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall4m 28smaster passed
+1 💚compile8m 35smaster passed
+1 💚checkstyle1m 12smaster passed
+1 💚spotbugs7m 48smaster passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 0sthe patch passed
+1 💚compile7m 52sthe patch passed
+1 💚javac7m 52sthe patch passed
+1 💚blanks0m 0sThe patch has no blanks issues.
+1 💚checkstyle1m 12sthe patch passed
+1 💚xmllint0m 0sNo new issues.
+1 💚spotbugs7m 50sthe patch passed
+1 💚hadoopcheck12m 14sPatch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚spotless0m 51spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
66m 3s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#6406
Optional Testsdupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
unameLinux 31a3a5d3a8c8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f399717
Default JavaEclipse Adoptium-17.0.11+9
Max. process+thread count188 (vs. ulimit of 30000)
modulesC: hbase-external-blockcache . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/console
versionsgit=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeLogfileComment
+0 🆗reexec0m 15sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 5smaster passed
+1 💚compile2m 11smaster passed
+1 💚javadoc2m 17smaster passed
+1 💚shadedjars5m 23sbranch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall2m 51sthe patch passed
+1 💚compile2m 10sthe patch passed
+1 💚javac2m 10sthe patch passed
+1 💚javadoc2m 17sthe patch passed
+1 💚shadedjars5m 22spatch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚unit295m 55sroot in the patch passed.
329m 12s
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#6406
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 71c8374cce63 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / f399717
Default JavaEclipse Adoptium-17.0.11+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/testReport/
Max. process+thread count9271 (vs. ulimit of 30000)
modulesC: hbase-external-blockcache . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6406/1/console
versionsgit=2.34.1 maven=3.9.8
Powered byApache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@jojochuangjojochuang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a rule to ban netty3 from transitive dependencies like in here: https://github.com/apache/hbase/blob/master/hbase-shaded/hbase-shaded-with-hadoop-check-invariants/pom.xml#L94

@Apache9

Copy link
Copy Markdown
ContributorAuthor

We have lots of enforcer rule in the root pom but unfortunately we still need to support compiling with hadoop 3.x so we can not add this rule...

@Apache9
Apache9 requested a review from ndimidukOctober 30, 2024 01:50

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite see how these changes match the title. Nett3 was a transitive dependency of one of these removed jars?

@Apache9

Copy link
Copy Markdown
ContributorAuthor

The jmemcahed daemon depends on netty, so here I used mockito to inject the memcached client, then we do not need to start the jmemcached daemon any more.

Jmemcached is not active for more than 10 years...

@Apache9
Apache9 merged commit a2d508a into apache:masterOct 30, 2024
Apache9 added a commit to Apache9/hbase that referenced this pull request Oct 30, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
Apache9 added a commit that referenced this pull request Oct 30, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
Apache9 added a commit that referenced this pull request Nov 1, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
Apache9 added a commit that referenced this pull request Nov 1, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
(cherry picked from commit 286bd69)
Apache9 added a commit that referenced this pull request Nov 1, 2024
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a2d508a)
(cherry picked from commit 286bd69)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@ndimiduk@jojochuang