Uh oh!
There was an error while loading. Please reload this page.
HBASE-28942 Purge all netty 3 dependencies by default - #6406
Conversation
Apache-HBase
commented
Oct 28, 2024
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Oct 28, 2024
🎊 +1 overall
This message was automatically generated. |
jojochuang
left a comment
There was a problem hiding this comment.
Would be nice to have a rule to ban netty3 from transitive dependencies like in here: https://github.com/apache/hbase/blob/master/hbase-shaded/hbase-shaded-with-hadoop-check-invariants/pom.xml#L94
Apache9
commented
Oct 29, 2024
We have lots of enforcer rule in the root pom but unfortunately we still need to support compiling with hadoop 3.x so we can not add this rule... |
ndimiduk
left a comment
There was a problem hiding this comment.
I don't quite see how these changes match the title. Nett3 was a transitive dependency of one of these removed jars?
Apache9
commented
Oct 30, 2024
The jmemcahed daemon depends on netty, so here I used mockito to inject the memcached client, then we do not need to start the jmemcached daemon any more. Jmemcached is not active for more than 10 years... |
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit a2d508a)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit a2d508a)
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit a2d508a)
No description provided.